Fix clang modules [chromium/src : main]

0 views

Skip to first unread message

Takuto Ikuta (Gerrit)

unread,

May 12, 2025, 12:35:04 AM5/12/25

to Matt Stark, Takuto Ikuta, Kaan Icer, Christian Biesinger, AyeAye, asvitki...@chromium.org, chromiumme...@microsoft.com, npm+...@chromium.org, chromotin...@chromium.org, yigu+...@chromium.org, feature-me...@chromium.org

Attention needed from Matt Stark

Takuto Ikuta added 3 comments

File build/linux/amd64/module.modulemap

Line 1, Patchset 1 (Latest):module sysroot_features [system] [extern_c] {

Takuto Ikuta . unresolved

Could you make a separate CL to import this?

File chrome/browser/ui/webid/identity_ui_utils.h

Line 8, Patchset 1 (Latest):#include <optional>

Takuto Ikuta . unresolved

Could you make separate CL for this?

File third_party/crashpad/crashpad/util/stdlib/strlcpy.h

Line 18, Patchset 1 (Latest):#include <stddef.h>

Takuto Ikuta . unresolved

Could you fix this in upstream and import?

Open in Gerrit

Related details

Attention is currently required from:

Matt Stark

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Stark (Gerrit)

unread,

Jul 7, 2025, 11:16:08 PM7/7/25

to Takuto Ikuta, Kaan Icer, Christian Biesinger, AyeAye, asvitki...@chromium.org, chromiumme...@microsoft.com, npm+...@chromium.org, chromotin...@chromium.org, yigu+...@chromium.org, feature-me...@chromium.org

Matt Stark abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages