Add parser for EXT-X-SESSION-DATA HLS tag [chromium/src : main]

0 views
Skip to first unread message

Ted (Chromium) Meyer (Gerrit)

unread,
Jul 7, 2025, 6:29:11 PM7/7/25
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov

Ted (Chromium) Meyer voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac9251c752bd4856a42742a7b655da91d05351d6
Gerrit-Change-Number: 6695717
Gerrit-PatchSet: 2
Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Mon, 07 Jul 2025 22:29:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eugene Zemtsov (Gerrit)

unread,
Jul 7, 2025, 10:01:25 PM7/7/25
to Ted (Chromium) Meyer, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Eugene Zemtsov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iac9251c752bd4856a42742a7b655da91d05351d6
    Gerrit-Change-Number: 6695717
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Comment-Date: Tue, 08 Jul 2025 02:01:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ted (Chromium) Meyer (Gerrit)

    unread,
    Jul 8, 2025, 1:43:51 PM7/8/25
    to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

    Ted (Chromium) Meyer voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iac9251c752bd4856a42742a7b655da91d05351d6
    Gerrit-Change-Number: 6695717
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Comment-Date: Tue, 08 Jul 2025 17:43:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 8, 2025, 1:50:14 PM7/8/25
    to Ted (Chromium) Meyer, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add parser for EXT-X-SESSION-DATA HLS tag

    This is part of a series of changes to finish adding all the tags that
    are specified in the HLS spec. They'll be added to the manifest parsers
    in follow up CLs.
    Fixed: 314834411
    Change-Id: Iac9251c752bd4856a42742a7b655da91d05351d6
    Commit-Queue: Ted (Chromium) Meyer <tmath...@chromium.org>
    Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1483873}
    Files:
    • M media/formats/hls/tags.cc
    • M media/formats/hls/tags.h
    • M media/formats/hls/tags_unittest.cc
    Change size: M
    Delta: 3 files changed, 137 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eugene Zemtsov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iac9251c752bd4856a42742a7b655da91d05351d6
    Gerrit-Change-Number: 6695717
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages