Reland "media/gpu/vaapiWrapper: Add native pixmap validation" [chromium/src : main]

0 views

Skip to first unread message

Hirokazu Honda (Gerrit)

unread,

4:21 AM (5 hours ago) 4:21 AM

to chromium...@chromium.org, feature-me...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org

Hirokazu Honda has uploaded the change for review

Commit message

Reland "media/gpu/vaapiWrapper: Add native pixmap validation"

> This CL introduces more rigorous validation for plane metadata when
> populating VADRMPRIMESurfaceDescriptor:
>
> - Verifying that plane pitch is at least the minimum required stride.
> - Ensuring that the plane's memory range (offset + size) stays within
>   the bounds of the DMA-buf.
>
> Bug: 495819067
> Test: webrtc.RTCPeerConnection.*
> Change-Id: I5d27d3a21ab692367931406e9c345a4a61ee2bb6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7834744
> Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
> Commit-Queue: Kai Ninomiya <kai...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1631660}

Bug: 495819067

Test: video_decode_accelerator_tests

Change-Id: Ie3b60a2e066c86b6bff7e85b115f90d9d8a3c259

Change diff

Change information

Files:

M media/gpu/vaapi/BUILD.gn
M media/gpu/vaapi/vaapi_wrapper.cc

Change size: M

Delta: 2 files changed, 78 insertions(+), 17 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hirokazu Honda (Gerrit)

unread,

4:24 AM (5 hours ago) 4:24 AM

to Nathan Hebert, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org

Attention needed from Nathan Hebert

Hirokazu Honda voted and added 1 comment

Votes added by Hirokazu Honda

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Hirokazu Honda . resolved

Fix: https://chromium-review.git.corp.google.com/c/chromium/src/+/7855566/1..2

Open in Gerrit

Related details

Attention is currently required from:

Nathan Hebert

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages