Radu Nitescu (Gerrit)

unread,

3:57 AM (14 hours ago) 3:57 AM

to Christian Xu, Ameur Hosni, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ameur Hosni and Christian Xu

Radu Nitescu voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Ameur Hosni
Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ameur Hosni (Gerrit)

unread,

4:16 AM (14 hours ago) 4:16 AM

to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ameur Hosni voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:05 AM (13 hours ago) 5:05 AM

to Radu Nitescu, Ameur Hosni, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[iOS] Relocate WebStateDeferredExecutor to its own file

Change-Id: I8f1e5f63bcc9db7dcfe7977f1c2522058d5b9694

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7141299

Auto-Submit: Radu Nitescu <radun...@google.com>

Commit-Queue: Radu Nitescu <radun...@google.com>

Commit-Queue: Ameur Hosni <ameur...@google.com>

Reviewed-by: Ameur Hosni <ameur...@google.com>

Cr-Commit-Position: refs/heads/main@{#1543614}

Files:

M ios/chrome/browser/composebox/coordinator/BUILD.gn
M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
A ios/chrome/browser/composebox/coordinator/web_state_deferred_executor.h
A ios/chrome/browser/composebox/coordinator/web_state_deferred_executor.mm

Change size: M

Delta: 4 files changed, 131 insertions(+), 111 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ameur Hosni

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[iOS] Relocate WebStateDeferredExecutor to its own file [chromium/src : main]

Radu Nitescu (Gerrit)

Radu Nitescu voted

Related details

Ameur Hosni (Gerrit)

Ameur Hosni voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information