[MediaRecorder] Cleanup how start events are emitted [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Jul 7, 2025, 5:36:27 PM7/7/25
to Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
Attention needed from Markus Handell

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dale Curtis . resolved

Whoops, I should have just done what you suggested on the other patch set!

Open in Gerrit

Related details

Attention is currently required from:
  • Markus Handell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
Gerrit-Change-Number: 6711232
Gerrit-PatchSet: 1
Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Markus Handell <hand...@google.com>
Gerrit-Attention: Markus Handell <hand...@google.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 21:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Jul 7, 2025, 7:03:19 PM7/7/25
to Eugene Zemtsov, Chromium LUCI CQ, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
Attention needed from Eugene Zemtsov and Markus Handell

Dale Curtis added 1 comment

Patchset-level comments
Dale Curtis . resolved

=>Eugene since Markus is OOO again.

Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
  • Markus Handell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
Gerrit-Change-Number: 6711232
Gerrit-PatchSet: 1
Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Markus Handell <hand...@google.com>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Markus Handell <hand...@google.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 23:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Eugene Zemtsov (Gerrit)

unread,
Jul 7, 2025, 7:11:36 PM7/7/25
to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
Attention needed from Dale Curtis and Markus Handell

Eugene Zemtsov voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Markus Handell
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
    Gerrit-Change-Number: 6711232
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Markus Handell <hand...@google.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Attention: Markus Handell <hand...@google.com>
    Gerrit-Comment-Date: Mon, 07 Jul 2025 23:11:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Jul 7, 2025, 7:24:52 PM7/7/25
    to Eugene Zemtsov, Chromium LUCI CQ, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
    Attention needed from Eugene Zemtsov and Markus Handell

    Dale Curtis voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    • Markus Handell
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
    Gerrit-Change-Number: 6711232
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Markus Handell <hand...@google.com>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Markus Handell <hand...@google.com>
    Gerrit-Comment-Date: Mon, 07 Jul 2025 23:24:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Jul 7, 2025, 8:18:11 PM7/7/25
    to Eugene Zemtsov, Chromium LUCI CQ, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
    Attention needed from Markus Handell

    Dale Curtis voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Markus Handell
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
    Gerrit-Change-Number: 6711232
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Markus Handell <hand...@google.com>
    Gerrit-Attention: Markus Handell <hand...@google.com>
    Gerrit-Comment-Date: Tue, 08 Jul 2025 00:18:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Jul 7, 2025, 8:35:55 PM7/7/25
    to Eugene Zemtsov, Chromium LUCI CQ, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org
    Gerrit-Comment-Date: Tue, 08 Jul 2025 00:35:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 7, 2025, 8:39:03 PM7/7/25
    to Dale Curtis, Eugene Zemtsov, Markus Handell, chromium...@chromium.org, blink-...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, mcasas+med...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [MediaRecorder] Cleanup how start events are emitted

    No functional changes in the non-seekable webm case, just renames
    the functions involved and some variables to make it clearer what
    is happening.

    In the seekable case, we may have already emitted the start event,
    so the DCHECK is changed to a conditional.
    Bug: 40482588
    Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
    Auto-Submit: Dale Curtis <dalec...@chromium.org>
    Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
    Commit-Queue: Dale Curtis <dalec...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1483463}
    Files:
    • M third_party/blink/renderer/modules/mediarecorder/media_recorder.cc
    • M third_party/blink/renderer/modules/mediarecorder/media_recorder.h
    • M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.cc
    Change size: S
    Delta: 3 files changed, 17 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eugene Zemtsov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I64e9f47fcbfe4105a6da20456b546c336b1b3a9b
    Gerrit-Change-Number: 6711232
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Markus Handell <hand...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages