[HoT][Bling] Restructure Identity Docs view [chromium/src : main]
0 views
Skip to first unread message
Julia Sobiech (Gerrit)
May 12, 2026, 9:43:05 AM (6 days ago) May 12
to Vidhan Jain, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org
Attention needed from Vidhan Jain
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Julia Sobiech (Gerrit)
May 15, 2026, 6:10:24 AM (3 days ago) May 15
to Vidhan Jain, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org
Attention needed from Julia Sobiech and Vidhan Jain
Message from Julia Sobiech![]( "Open in Gerrit")
Attention is currently required from:
- Julia Sobiech
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
6:30 AM (3 hours ago) 6:30 AM
to Julia Sobiech, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org
Attention needed from Julia Sobiech
Vidhan Jain voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Julia Sobiech
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Julia Sobiech (Gerrit)
6:30 AM (3 hours ago) 6:30 AM
to Vidhan Jain, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org
Julia Sobiech voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:34 AM (2 hours ago) 7:34 AM
to Julia Sobiech, Vidhan Jain, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[HoT][Bling] Restructure Identity Docs view
The IdentityDocsTableViewController now displays Passports, National ID
Cards, and Drivers Licenses in separate sections, each with a
descriptive header. Identity docs page implementation is altered to
match the Travel Docs more closely.
Bug: 491417038
Change-Id: I4c7d4285608907ffa7a6be9071bfbcc7ce79ea00
Reviewed-by: Vidhan Jain <vid...@google.com>
Commit-Queue: Julia Sobiech <jsob...@google.com>
Cr-Commit-Position: refs/heads/main@{#1632080}
Files:
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/coordinator/identity_docs_coordinator.mm
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/coordinator/identity_docs_coordinator_unittest.mm
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/coordinator/identity_docs_mediator.mm
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/coordinator/identity_docs_mediator_unittest.mm
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/ui/identity_docs_consumer.h
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/ui/identity_docs_table_view_controller.h
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/ui/identity_docs_table_view_controller.mm
Change size: M
Delta: 7 files changed, 126 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vidhan Jain
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages