blink: Add inputs for grit actions [chromium/src : main]
0 views
Skip to first unread message
Takuto Ikuta (Gerrit)
Jul 31, 2026, 5:16:59 AM (5 days ago) Jul 31
to Takuto Ikuta, Tommy Steimel, Mike West, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Mike West and Tommy Steimel
Takuto Ikuta voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mike West
- Tommy Steimel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Steimel (Gerrit)
Aug 3, 2026, 11:56:51 AM (2 days ago) Aug 3
to Takuto Ikuta, Mike West, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Mike West and Takuto Ikuta
Tommy Steimel added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/media_controls/BUILD.gn
Line 184, Patchset 2 (Latest):
inputs += [ "resources/default_200_percent/mediaremoting_cast.png" ]Tommy Steimel . unresolved
Why isn't this needed on Android?
Related details
Attention is currently required from:
- Mike West
- Takuto Ikuta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takuto Ikuta (Gerrit)
Aug 4, 2026, 2:05:06 AM (yesterday) Aug 4
to Takuto Ikuta, Tommy Steimel, Mike West, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Mike West and Tommy Steimel
Takuto Ikuta added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/media_controls/BUILD.gn
Line 184, Patchset 2 (Latest):
inputs += [ "resources/default_200_percent/mediaremoting_cast.png" ]Tommy Steimel . unresolved
Why isn't this needed on Android?
Takuto Ikuta
GRIT doesn't enable `scale_factors=2x` for Android
https://source.chromium.org/chromium/chromium/src/+/main:tools/grit/grit_args.gni;l=42;drc=f720f899799643250e5c53c96a434147582b814f
so `flattenhtml` automatically strips 2x resources from `image-set()` during Android builds. Including it in `inputs` for Android would cause the `--assert-input-file-list` check to fail since the file isn't actually read.
Related details
Attention is currently required from:
- Mike West
- Tommy Steimel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Aug 4, 2026, 5:54:39 AM (yesterday) Aug 4
to Takuto Ikuta, Tommy Steimel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Takuto Ikuta and Tommy Steimel
Mike West voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Takuto Ikuta
- Tommy Steimel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Steimel (Gerrit)
Aug 4, 2026, 1:13:44 PM (18 hours ago) Aug 4
to Takuto Ikuta, Mike West, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Takuto Ikuta
Tommy Steimel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tommy Steimel
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/media_controls/BUILD.gn
Line 184, Patchset 2 (Latest):
inputs += [ "resources/default_200_percent/mediaremoting_cast.png" ]Tommy Steimel . resolved
Takuto IkutaWhy isn't this needed on Android?
GRIT doesn't enable `scale_factors=2x` for Android
https://source.chromium.org/chromium/chromium/src/+/main:tools/grit/grit_args.gni;l=42;drc=f720f899799643250e5c53c96a434147582b814f
so `flattenhtml` automatically strips 2x resources from `image-set()` during Android builds. Including it in `inputs` for Android would cause the `--assert-input-file-list` check to fail since the file isn't actually read.
Tommy Steimel
Acknowledged
Related details
Attention is currently required from:
- Takuto Ikuta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takuto Ikuta (Gerrit)
Aug 4, 2026, 11:19:37 PM (8 hours ago) Aug 4
to Takuto Ikuta, Tommy Steimel, Mike West, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Takuto Ikuta voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 4, 2026, 11:22:56 PM (8 hours ago) Aug 4
to Takuto Ikuta, Tommy Steimel, Mike West, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
blink: Add inputs for grit actions
Goal of this CL is to make the grit action runs on remote worker so that
we can reduce local resource usage and share build cache between
bots/developers. But we need to tell which files are read by grit
actions to siso from build system layer.
Although we need to specify inputs both in grit and BUILD.gn, I'll add a
check to detect which files are missed or overspecified in grit.py and
we can now rely on AI agent to fix them easily.
Extracted from https://crrev.com/c/8085243.
Bug: 535044365
Change-Id: Ifd3e033a77079aa0e41de4543bd38968507619ba
Auto-Submit: Takuto Ikuta <tik...@chromium.org>
Commit-Queue: Takuto Ikuta <tik...@chromium.org>
Reviewed-by: Mike West <mk...@chromium.org>
Reviewed-by: Tommy Steimel <ste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673871}
Files:
- M third_party/blink/public/BUILD.gn
- M third_party/blink/renderer/modules/media_controls/BUILD.gn
Change size: M
Delta: 2 files changed, 138 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tommy Steimel, +1 by Mike West
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages