Radu Nitescu (Gerrit)

unread,

Jan 21, 2026, 9:41:56 AM (yesterday) Jan 21

to Christian Xu, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Ewann Pellé

Radu Nitescu voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ewann Pellé (Gerrit)

unread,

Jan 21, 2026, 10:52:14 AM (24 hours ago) Jan 21

to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ewann Pellé added 6 comments

File ios/chrome/app/strings/ios_strings.grd

Line 1455, Patchset 5 (Latest):

      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only]..">

Ewann Pellé . unresolved

```suggestion
      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only].">
```

File ios/chrome/browser/composebox/coordinator/composebox_constants.h

Line 12, Patchset 5 (Latest):

  kRegularSearch,
  kAIM,
  kImageGeneration,
  kCanvas,

Ewann Pellé . unresolved

Nit: It would be helpful to add a brief comment for each enum value to clarify their specific use cases.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 476, Patchset 5 (Latest): [self.consumer setAIModeEnabled:mode == ComposeboxMode::kAIM];

Ewann Pellé . unresolved

duplicate?

Line 1210, Patchset 5 (Latest):- (BOOL)isEligibleToCanvas {

Ewann Pellé . unresolved

Private methods should have a comment. Same for some methods below.

Line 1257, Patchset 5 (Latest): _isMultiline || _modeHolder.mode != ComposeboxMode::kRegularSearch;

Ewann Pellé . unresolved

optional nit: Adding new values to the ComposeboxMode enum may require an update to this flow. Maybe having a switch could solve this issue.

File ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Line 1719, Patchset 5 (Latest):- (UIButton*)createCanvasButton {

Ewann Pellé . unresolved

optional nit: It seems like a lot of private methods are also missing a comment in this file.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

4:34 AM (6 hours ago) 4:34 AM

to Chromium LUCI CQ, Christian Xu, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Ewann Pellé

Radu Nitescu voted and added 6 comments

Votes added by Radu Nitescu

Auto-Submit

+1

6 comments

File ios/chrome/app/strings/ios_strings.grd

Line 1455, Patchset 5:

      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only]..">

Ewann Pellé . resolved

```suggestion
      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only].">
```

Radu Nitescu

Done

File ios/chrome/browser/composebox/coordinator/composebox_constants.h

Line 12, Patchset 5:

  kRegularSearch,
  kAIM,
  kImageGeneration,
  kCanvas,

Ewann Pellé . resolved

Nit: It would be helpful to add a brief comment for each enum value to clarify their specific use cases.

Radu Nitescu

Done

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 476, Patchset 5: [self.consumer setAIModeEnabled:mode == ComposeboxMode::kAIM];

Ewann Pellé . resolved

duplicate?

Radu Nitescu

Done

Line 1210, Patchset 5:- (BOOL)isEligibleToCanvas {

Ewann Pellé . resolved

Private methods should have a comment. Same for some methods below.

Radu Nitescu

Added comments for the newly introduced private methods.

Line 1257, Patchset 5: _isMultiline || _modeHolder.mode != ComposeboxMode::kRegularSearch;

Ewann Pellé . resolved

optional nit: Adding new values to the ComposeboxMode enum may require an update to this flow. Maybe having a switch could solve this issue.

Radu Nitescu

Right now everythin that is not regular expands the input plate. Likely this is the behavior that we will follow for other future modes.

File ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Line 1719, Patchset 5:- (UIButton*)createCanvasButton {

Ewann Pellé . resolved

optional nit: It seems like a lot of private methods are also missing a comment in this file.

Radu Nitescu

Will handle in a separate CL to avoid keep this one scoped for canvas mode.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

4:37 AM (6 hours ago) 4:37 AM

to Chromium LUCI CQ, Christian Xu, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu, Ewann Pellé and Radu Nitescu

Message from Radu Nitescu

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Ewann Pellé
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ewann Pellé (Gerrit)

unread,

4:42 AM (6 hours ago) 4:42 AM

to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ewann Pellé voted and added 2 comments

Votes added by Ewann Pellé

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Ewann Pellé . resolved

LGTM with comment.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1277, Patchset 8 (Latest):

// Whether the client is eligible to access canvas mode.  [self.consumer
// setAIModeEnabled:mode == ComposeboxMode::kAIM];

Ewann Pellé . unresolved

is this intended ?

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

5:34 AM (5 hours ago) 5:34 AM

to Ewann Pellé, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu

Radu Nitescu voted and added 1 comment

Votes added by Radu Nitescu

Auto-Submit

+1

1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1277, Patchset 8:// Whether the client is eligible to access canvas mode. [self.consumer


// setAIModeEnabled:mode == ComposeboxMode::kAIM];

Ewann Pellé . resolved

is this intended ?

Radu Nitescu

No, removed.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

8:13 AM (2 hours ago) 8:13 AM

to Radu Nitescu, Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Radu Nitescu

Christian Xu added 4 comments

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1282, Patchset 9 (Latest): if (experimental_flags::ShouldForceDisableComposeboxCreateImages()) {

Christian Xu . unresolved

We should probably have a different one for canvas.

File ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Line 1681, Patchset 9 (Parent):

    // Text drops are always allowed even if the attachment capacity is reached.
    return [self willAllowTextDrop:session];
  }

  BOOL willAllowPDFDrop = [self willAllowPDFDrop:session];
  BOOL willAllowImageDrop = [self willAllowImageDrop:session];
  BOOL willAllowTabDrop = [self willAllowTabDrop:session];
  BOOL willAllowTextDrop = [self willAllowTextDrop:session];

  return willAllowPDFDrop || willAllowImageDrop || willAllowTabDrop ||
         willAllowTextDrop;

Christian Xu . unresolved

Merge error ?

Line 1716, Patchset 9 (Parent):

/// Returns whether a tab drop will be allowed.
- (BOOL)willAllowTabDrop:(id<UIDropSession>)session {
  if (_attachTabActionsDisabled || _attachTabActionsHidden) {
    return NO;
  }

  for (UIDragItem* item in session.items) {
    if ([item.localObject isKindOfClass:[TabInfo class]]) {
      // Disallow tab drops between profiles and between incognito and
      // non-incognito sessions.
      TabInfo* tab = item.localObject;

      if ([self.delegate tabExistsOnCurrentProfile:tab]) {
        return YES;
      }
    }
  }

  return NO;
}

/// Returns whether a PDF drop will be allowed based on the Composebox mode,
/// whether a drag and drop action is allowed, and whether there is a PDF in the
/// drop session.

Christian Xu . unresolved

Same here

Line 1765, Patchset 9 (Parent):

    } else if ([self willAllowTabDrop:session] &&
               [item.localObject isKindOfClass:[TabInfo class]]) {
      [self performDropForTab:item.localObject];
    } else if ([self willAllowTextDrop:session] &&
               [item.itemProvider
                   hasItemConformingToTypeIdentifier:UTTypeText.identifier]) {
      [self performDropForText:item.itemProvider];
    }
  }
  // Drop complete.
  _dragSessionWithinInputPlate = NO;
}

/// Performs a drop for dragged text from a given `itemProvider`.
- (void)performDropForText:(NSItemProvider*)itemProvider {
  CHECK([itemProvider hasItemConformingToTypeIdentifier:UTTypeText.identifier]);

  __weak __typeof(self) weakSelf = self;
  [itemProvider loadObjectOfClass:[NSString class]
                completionHandler:^(NSString* text, NSError* error) {
                  [weakSelf handleTextDrop:text error:error];
                }];
}

/// Performs a drop for a dragged tab with `tabInfo`.
- (void)performDropForTab:(TabInfo*)tabInfo {
  CHECK(self.mutator);
  CHECK(tabInfo);
  CHECK_EQ(tabInfo.incognito, _theme.incognito);
  web::WebState* webState =
      [self.delegate webStateForTabOnCurrentProfile:tabInfo];

  if (!webState) {
    return;
  }

  [self.mutator processTab:webState webStateID:tabInfo.tabID];
}

Christian Xu . unresolved

Here too

Open in Gerrit

Related details

Attention is currently required from:

Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

9:08 AM (1 hour ago) 9:08 AM

to Ewann Pellé, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Ewann Pellé

Radu Nitescu voted and added 4 comments

Votes added by Radu Nitescu

Auto-Submit

+1

4 comments

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1282, Patchset 9: if (experimental_flags::ShouldForceDisableComposeboxCreateImages()) {

Christian Xu . resolved

We should probably have a different one for canvas.

Radu Nitescu

Added a separate one

File ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Line 1681, Patchset 9 (Parent):

    // Text drops are always allowed even if the attachment capacity is reached.
    return [self willAllowTextDrop:session];
  }

  BOOL willAllowPDFDrop = [self willAllowPDFDrop:session];
  BOOL willAllowImageDrop = [self willAllowImageDrop:session];
  BOOL willAllowTabDrop = [self willAllowTabDrop:session];
  BOOL willAllowTextDrop = [self willAllowTextDrop:session];

  return willAllowPDFDrop || willAllowImageDrop || willAllowTabDrop ||
         willAllowTextDrop;

Christian Xu . resolved

Merge error ?

Radu Nitescu

Done

Line 1716, Patchset 9 (Parent):

/// Returns whether a tab drop will be allowed.
- (BOOL)willAllowTabDrop:(id<UIDropSession>)session {
  if (_attachTabActionsDisabled || _attachTabActionsHidden) {
    return NO;
  }

  for (UIDragItem* item in session.items) {
    if ([item.localObject isKindOfClass:[TabInfo class]]) {
      // Disallow tab drops between profiles and between incognito and
      // non-incognito sessions.
      TabInfo* tab = item.localObject;

      if ([self.delegate tabExistsOnCurrentProfile:tab]) {
        return YES;
      }
    }
  }

  return NO;
}

/// Returns whether a PDF drop will be allowed based on the Composebox mode,
/// whether a drag and drop action is allowed, and whether there is a PDF in the
/// drop session.

Christian Xu . resolved

Same here

Radu Nitescu

Done

Christian Xu . resolved

Here too

Radu Nitescu

Done

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[iOS][AIM] Add canvas option in the composebox input plate [chromium/src : main]

Radu Nitescu (Gerrit)

Radu Nitescu voted

Related details

Ewann Pellé (Gerrit)

Ewann Pellé added 6 comments

Related details

Radu Nitescu (Gerrit)

Radu Nitescu voted and added 6 comments

Votes added by Radu Nitescu

6 comments

Related details

Radu Nitescu (Gerrit)

Message from Radu Nitescu

Related details

Ewann Pellé (Gerrit)

Ewann Pellé voted and added 2 comments

Votes added by Ewann Pellé

2 comments

Related details

Radu Nitescu (Gerrit)

Radu Nitescu voted and added 1 comment

Votes added by Radu Nitescu

1 comment

Related details

Christian Xu (Gerrit)

Christian Xu added 4 comments

Related details

Radu Nitescu (Gerrit)

Radu Nitescu voted and added 4 comments

Votes added by Radu Nitescu

4 comments

Related details