Delay price drop and product image acquisition on Tab Resumption [chromium/src : main]
0 views
Skip to first unread message
Chris Lu (Gerrit)
Oct 10, 2025, 4:20:30 PM (9 hours ago) Oct 10
to David Maunder, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mdjone...@chromium.org, yuezhang...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder
Chris Lu added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_mediator.mm
Line 1087, Patchset 16 (Latest):
[self.delegate tabResumptionHelperDidReceiveItem];Chris Lu . unresolved
If we set _itemConfig and call this, the card is added to the magic stack. I don't quite see divergent logic where only in arm 6, we add the card and then go fetch the image and update it later. It seems like we always did that?
Related details
Attention is currently required from:
- David Maunder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Lu (Gerrit)
Oct 10, 2025, 5:53:45 PM (8 hours ago) Oct 10
to David Maunder, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mdjone...@chromium.org, yuezhang...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder
Chris Lu added 2 comments![]( "Open in Gerrit")
File ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_mediator.mm
Line 1087, Patchset 16 (Latest):
[self.delegate tabResumptionHelperDidReceiveItem];Chris Lu . resolved
If we set _itemConfig and call this, the card is added to the magic stack. I don't quite see divergent logic where only in arm 6, we add the card and then go fetch the image and update it later. It seems like we always did that?
Chris Lu
Acknowledged
File ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_view.mm
Line 126, Patchset 16 (Latest):
- (void)shopCardDataCompleted:(TabResumptionItem*)item {Chris Lu . unresolved
Is there any way we can avoid completely recreating the entire contents and just update the price chip and the image? I am not sure what specific things we are waiting for in TabResumptionMediatorProxy::CanApplyOptimizationOnDemand, but if being able to specifically update elements helps us understand what exactly to expect in this code path.
Chris Lu (Gerrit)
Oct 10, 2025, 7:29:25 PM (6 hours ago) Oct 10
to David Maunder, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mdjone...@chromium.org, yuezhang...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder
Chris Lu voted and added 2 comments![]( "Open in Gerrit")
Votes added by Chris Lu
| Code-Review | +1 |
2 comments
Patchset-level comments
File ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_view.mm
Line 126, Patchset 16 (Latest):
- (void)shopCardDataCompleted:(TabResumptionItem*)item {Chris Lu . resolved
Is there any way we can avoid completely recreating the entire contents and just update the price chip and the image? I am not sure what specific things we are waiting for in TabResumptionMediatorProxy::CanApplyOptimizationOnDemand, but if being able to specifically update elements helps us understand what exactly to expect in this code path.
Chris Lu
discussed offline, will keep as is.
Related details
Attention is currently required from:
- David Maunder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Maunder (Gerrit)
Oct 10, 2025, 7:57:47 PM (6 hours ago) Oct 10
to Chris Lu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mdjone...@chromium.org, yuezhang...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
David Maunder voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 10, 2025, 8:00:52 PM (6 hours ago) Oct 10
to David Maunder, Chris Lu, AyeAye, chromium...@chromium.org, mdjone...@chromium.org, yuezhang...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Delay price drop and product image acquisition on Tab Resumption
This arm introduces a new arm on the price drop variation of
Tab resumption which acquires the price drop and product image after
the card is rendered and updates the card (if applicable). This
is to reduce the overall latency of the card.
Bug: 450903479
Change-Id: I1b11230f21e82711e305615a02640072c3e61db8
Commit-Queue: David Maunder <dav...@chromium.org>
Reviewed-by: Chris Lu <thegre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528446}
Files:
- M components/commerce/core/commerce_feature_list.cc
- M components/commerce/core/commerce_feature_list.h
- M ios/chrome/browser/content_suggestions/ui_bundled/magic_stack/magic_stack_module_contents_factory.mm
- M ios/chrome/browser/content_suggestions/ui_bundled/magic_stack/magic_stack_ranking_model.mm
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/BUILD.gn
- A ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_consumer.h
- A ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_consumer_source.h
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_item.h
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_item.mm
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_mediator.mm
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_view.h
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_view.mm
- M ios/chrome/browser/flags/about_flags.mm
Change size: M
Delta: 13 files changed, 184 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Lu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages