Clean up kWebRtcAllowWgcWindowZeroHz feature flag [chromium/src : main]

0 views
Skip to first unread message

Steve Becker (Gerrit)

unread,
Sep 19, 2025, 7:49:58 PM (3 days ago) Sep 19
to Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org

Steve Becker voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdc371f62cd756e412407d91c6fb2d0800f95dd
Gerrit-Change-Number: 6968748
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Becker <ste...@microsoft.com>
Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 23:49:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Henrik Andreasson (Gerrit)

unread,
Sep 22, 2025, 6:43:41 AM (22 hours ago) Sep 22
to Steve Becker, AyeAye, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Steve Becker

Henrik Andreasson voted and added 1 comment

Votes added by Henrik Andreasson

Code-Review+1

1 comment

File content/browser/media/capture/desktop_capture_device.cc
Line 919, Patchset 1 (Latest): // 0Hz support is by enabled for WGC window capture but disabled by default
Henrik Andreasson . unresolved

remove "by"

Open in Gerrit

Related details

Attention is currently required from:
  • Steve Becker
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9fdc371f62cd756e412407d91c6fb2d0800f95dd
    Gerrit-Change-Number: 6968748
    Gerrit-PatchSet: 1
    Gerrit-Owner: Steve Becker <ste...@microsoft.com>
    Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
    Gerrit-CC: Ale Bzk <ales...@chromium.org>
    Gerrit-CC: Per Åhgren <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
    Gerrit-Attention: Steve Becker <ste...@microsoft.com>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 10:43:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steve Becker (Gerrit)

    unread,
    Sep 22, 2025, 12:24:42 PM (17 hours ago) Sep 22
    to Olga Sharonova, Alexander Cooper, Henrik Andreasson, AyeAye, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Alexander Cooper and Olga Sharonova

    Steve Becker added 1 comment

    File content/browser/media/capture/desktop_capture_device.cc
    Line 919, Patchset 1: // 0Hz support is by enabled for WGC window capture but disabled by default
    Henrik Andreasson . resolved

    remove "by"

    Steve Becker

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Cooper
    • Olga Sharonova
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9fdc371f62cd756e412407d91c6fb2d0800f95dd
    Gerrit-Change-Number: 6968748
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steve Becker <ste...@microsoft.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
    Gerrit-CC: Ale Bzk <ales...@chromium.org>
    Gerrit-CC: Per Åhgren <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
    Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 16:24:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Henrik Andreasson <hen...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexander Cooper (Gerrit)

    unread,
    Sep 22, 2025, 1:24:11 PM (16 hours ago) Sep 22
    to Steve Becker, Olga Sharonova, Henrik Andreasson, AyeAye, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Olga Sharonova and Steve Becker

    Alexander Cooper voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Olga Sharonova
    • Steve Becker
    Gerrit-Attention: Steve Becker <ste...@microsoft.com>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 17:24:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages