Fix OWNERS file parsing for some media OWNERS [chromium/src : main]
0 views
Skip to first unread message
Vikram Pasupathy (Gerrit)
Mar 11, 2026, 1:12:58 AMMar 11
to Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Xiaohan Wang
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vikram Pasupathy . resolved
currently, when I run
```
git cl owners --batch --show-all content/browser/media/key_system_support_win.h
```
I see
```
Owners for content/browser/media/key_system_support_win.h:
- elad...@chromium.org
- blun...@chromium.org
- to...@chromium.org
- libe...@chromium.org
- tgui...@chromium.org
- tmath...@chromium.org
- xhw...@chromium.org
- jop...@chromium.org
- eug...@chromium.org
- mfo...@chromium.org
- ol...@chromium.org
- dalec...@chromium.org
- bo...@chromium.org
- arthurs...@chromium.org
- cl...@chromium.org
- ale...@chromium.org
- kin...@chromium.org
- na...@chromium.org
- a...@chromium.org
- cr...@chromium.org
- dgo...@chromium.org
- dtap...@chromium.org
- rak...@chromium.org
```
So looks like everything after the first "cdm" is not being registered.
So I just made this single-file.
Related details
Attention is currently required from:
- Xiaohan Wang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Mar 11, 2026, 7:04:48 PMMar 11
to Vikram Pasupathy, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Vikram Pasupathy
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaohan Wang
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Vikram Pasupathy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Mar 12, 2026, 12:52:17 AMMar 12
to Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 12:55:39 AMMar 12
to Vikram Pasupathy, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix OWNERS file parsing for some media OWNERS
This CL splits these comma-separated rules into individual line-by-line
rules across media-related OWNERS files to ensure robust and correct
ownership resolution.
I verified that media/cdm/OWNERS didn't register, as well as the
mirroring_service_host.h didn't allow OWNERS in media/cast/OWNERS who
were not already in media/OWNERS.
Example of it working is in mojo_audio_output*/input* in the
media/mojo/OWNERS file.
Change-Id: I9062f3259ee90ee487da66b6c7bda22f1fd650e3
Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598213}
Files:
- M chrome/browser/media/OWNERS
- M content/browser/media/OWNERS
- M media/mojo/services/OWNERS
Change size: S
Delta: 3 files changed, 9 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xiaohan Wang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages