[webcodecs] Fix AudioDecoder throwing UTF8 characters instead of numbers [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Nov 12, 2025, 7:06:45 PM (10 hours ago) Nov 12
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov and jj
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
Line 66, Patchset 3 (Latest):
for (const T& value_ : supported_values) {Dale Curtis . unresolved
Drop `_`
Related details
Attention is currently required from:
- Eugene Zemtsov
- jj
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
jj (Gerrit)
Nov 12, 2025, 7:12:48 PM (10 hours ago) Nov 12
to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Eugene Zemtsov
jj voted and added 1 comment![]( "Open in Gerrit")
Votes added by jj
| Commit-Queue | +1 |
1 comment
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
Line 66, Patchset 3 (Latest):
for (const T& value_ : supported_values) {Dale Curtis . unresolved
Drop `_`
jj
I appended the `_` here to avoid a shadowing warning with the `value` arg. Maybe this variable could be renamed to something else?
Related details
Attention is currently required from:
- Dale Curtis
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
jj (Gerrit)
Nov 12, 2025, 7:17:41 PM (10 hours ago) Nov 12
to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Eugene Zemtsov
jj added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
jjDrop `_`
I appended the `_` here to avoid a shadowing warning with the `value` arg. Maybe this variable could be renamed to something else?
jj
Done
Related details
Attention is currently required from:
- Dale Curtis
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Nov 12, 2025, 7:18:57 PM (10 hours ago) Nov 12
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
Line 66, Patchset 3:
for (const T& value_ : supported_values) {Dale Curtis . resolved
jjDrop `_`
I appended the `_` here to avoid a shadowing warning with the `value` arg. Maybe this variable could be renamed to something else?
Dale Curtis
`val` is fine. `_` is reserved for member variables.
Line 67, Patchset 4 (Latest):
supported_values_str.push_back(base::ToString(val));Dale Curtis . unresolved
Oh yeah, does `.Ascii()` work instead?
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
jj (Gerrit)
Nov 12, 2025, 7:25:12 PM (10 hours ago) Nov 12
to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Eugene Zemtsov
jj voted and added 1 comment![]( "Open in Gerrit")
Votes added by jj
| Commit-Queue | +0 |
1 comment
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
Line 67, Patchset 4 (Latest):
supported_values_str.push_back(base::ToString(val));Dale Curtis . unresolved
Oh yeah, does `.Ascii()` work instead?
jj
`T` here is `const int`, so unfortunately not:
```
../../third_party/blink/renderer/modules/webcodecs/audio_encoder.cc:67:39: error: member reference base type 'const int' is not a structure or union
67 | supported_values_str.push_back(val.Ascii());
| ~~~^~~~~~
```
Related details
Attention is currently required from:
- Dale Curtis
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Nov 12, 2025, 7:29:39 PM (10 hours ago) Nov 12
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov and jj
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
Line 67, Patchset 4 (Latest):
supported_values_str.push_back(base::ToString(val));Dale Curtis . resolved
jjOh yeah, does `.Ascii()` work instead?
`T` here is `const int`, so unfortunately not:
```
../../third_party/blink/renderer/modules/webcodecs/audio_encoder.cc:67:39: error: member reference base type 'const int' is not a structure or union
67 | supported_values_str.push_back(val.Ascii());
| ~~~^~~~~~
```
Attention is currently required from:
- Eugene Zemtsov
- jj
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages