Fix TestAddCardWithCvcRecordsUserAction [chromium/src : main]
0 views
Skip to first unread message
Oleksandr Tara (Gerrit)
Nov 3, 2025, 8:34:18 AM (10 days ago) Nov 3
to Ioana Pandele, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Ioana Pandele
Oleksandr Tara voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Ioana Pandele
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ioana Pandele (Gerrit)
Nov 3, 2025, 8:35:47 AM (10 days ago) Nov 3
to Oleksandr Tara, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Oleksandr Tara
Ioana Pandele voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Oleksandr Tara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oleksandr Tara (Gerrit)
Nov 3, 2025, 8:36:31 AM (10 days ago) Nov 3
to yiwen qian, Ioana Pandele, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Oleksandr Tara
Oleksandr Tara added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Oleksandr Tara . resolved
@yiwe...@chromium.org Once you have the time, please update the test to not rely on real time.
Related details
Attention is currently required from:
- Oleksandr Tara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oleksandr Tara (Gerrit)
Nov 3, 2025, 8:36:37 AM (10 days ago) Nov 3
to yiwen qian, Ioana Pandele, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Oleksandr Tara voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 3, 2025, 8:39:13 AM (10 days ago) Nov 3
to Oleksandr Tara, yiwen qian, Ioana Pandele, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix TestAddCardWithCvcRecordsUserAction
Not familiar with the codebase but it seems like the card the test tries
to add is already expired. It is therefore not added. I've tested the
fix locally and the test passes.
This and the next test should probably be updated because they will
start failing in a year.
Bug: 457076512
Change-Id: I98c37daf6663a4638948b6ac9813f3b621ac7cee
Owners-Override: Oleksandr Tara <ot...@google.com>
Reviewed-by: Ioana Pandele <ioa...@chromium.org>
Commit-Queue: Oleksandr Tara <ot...@google.com>
Cr-Commit-Position: refs/heads/main@{#1539306}
Files:
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_credit_card_mediator_unittest.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ioana Pandele
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 6, 2025, 6:49:41 PM (6 days ago) Nov 6
to Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao
yiwen qian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
yiwen qian . resolved
Hi Qihui, could you please review this CL? Thank you!
Related details
Attention is currently required from:
- Qihui Zhao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Nov 10, 2025, 3:13:19 PM (2 days ago) Nov 10
to yiwen qian, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from yiwen qian
Qihui Zhao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- yiwen qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 10, 2025, 7:37:04 PM (2 days ago) Nov 10
to Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao
yiwen qian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Qihui Zhao . resolved
Any test that will be affected by this flag?
yiwen qian
The AutofillAddCreditCardMediatorTest.TestAddCardWithCvcRecordsUserAction test is failing on the M142, M143
Related details
Attention is currently required from:
- Qihui Zhao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Nov 10, 2025, 7:41:51 PM (2 days ago) Nov 10
to yiwen qian, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from yiwen qian
Qihui Zhao voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- yiwen qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Nov 10, 2025, 7:47:18 PM (2 days ago) Nov 10
to yiwen qian, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from yiwen qian
Qihui Zhao added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_credit_card_mediator_unittest.mm
Line 42, Patchset 2 (Latest):
void SetUp() override {
PlatformTest::SetUp();
feature_list_.InitAndEnableFeature(
autofill::features::kAutofillEnableCvcStorageAndFilling);
}Qihui Zhao . unresolved
Let's remove this block and do, I think it should work.
`base::test::ScopedFeatureList feature_list_{autofill::features::kAutofillEnableCvcStorageAndFilling};`
Related details
Attention is currently required from:
- yiwen qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 11, 2025, 2:33:33 AM (yesterday) Nov 11
to Tommy Martino, Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino
yiwen qian added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_credit_card_mediator_unittest.mm
Line 42, Patchset 2 (Latest):
void SetUp() override {
PlatformTest::SetUp();
feature_list_.InitAndEnableFeature(
autofill::features::kAutofillEnableCvcStorageAndFilling);
}Qihui Zhao . resolved
Let's remove this block and do, I think it should work.
`base::test::ScopedFeatureList feature_list_{autofill::features::kAutofillEnableCvcStorageAndFilling};`
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 11, 2025, 2:33:42 AM (yesterday) Nov 11
to Tommy Martino, Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
yiwen qian removed Tommy Martino from this change![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 11, 2025, 3:16:16 AM (yesterday) Nov 11
to Tommy Martino, Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao and Tommy Martino
yiwen qian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
yiwen qian . resolved
Hi Tommy, could you please review this CL? Thank you!
Related details
Attention is currently required from:
- Qihui Zhao
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Nov 11, 2025, 12:36:55 PM (yesterday) Nov 11
to yiwen qian, Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino and yiwen qian
Qihui Zhao voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tommy Martino
- yiwen qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Martino (Gerrit)
10:44 AM (12 hours ago) 10:44 AM
to yiwen qian, Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from yiwen qian
Tommy Martino voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- yiwen qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
2:39 PM (8 hours ago) 2:39 PM
to Tommy Martino, Qihui Zhao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
yiwen qian voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:06 PM (7 hours ago) 3:06 PM
to yiwen qian, Tommy Martino, Qihui Zhao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[CVC storage IOS] Fix TestAddCardWithCvcRecordsUserAction
Bug: 457603723
Change-Id: Ica1ab389accdbc6f36ccf5cd320a727843293a58
Reviewed-by: Tommy Martino <tmar...@chromium.org>
Reviewed-by: Qihui Zhao <qihu...@google.com>
Commit-Queue: yiwen qian <yiwe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1543878}
Files:
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_credit_card_mediator_unittest.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tommy Martino, +1 by Qihui Zhao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages