Stepan Khapugin (Gerrit)

unread,

Mar 10, 2026, 3:10:16 PMMar 10

to Christian Xu, Ananya Seelam, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam and Christian Xu

Stepan Khapugin voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Ananya Seelam
Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 10, 2026, 5:07:35 PMMar 10

to Stepan Khapugin, Gauthier Ambard, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu, Gauthier Ambard and Stepan Khapugin

Ananya Seelam voted and added 3 comments

Votes added by Ananya Seelam

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Ananya Seelam . resolved

lgtm % some nits!

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1607, Patchset 1 (Latest): return _aimEligibilityService->IsAimEligible() &&

Ananya Seelam . unresolved

nit: I think we can remove this since IsFuseboxEligible() checks IsAimEligible() as well. See: https://source.chromium.org/chromium/chromium/src/+/main:components/omnibox/browser/aim_eligibility_service.cc;l=534

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 1 (Latest): aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Ananya Seelam . unresolved

nit: same as above, not sure if we need to also check `aimAllowed`.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Gauthier Ambard
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Gauthier Ambard (Gerrit)

unread,

Mar 11, 2026, 4:45:22 AMMar 11

to Stepan Khapugin, Ananya Seelam, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu and Stepan Khapugin

Gauthier Ambard voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 9:11:14 AMMar 11

to Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu

Stepan Khapugin voted and added 2 comments

Votes added by Stepan Khapugin

Auto-Submit	+1
Commit-Queue	+1

2 comments

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1607, Patchset 1: return _aimEligibilityService->IsAimEligible() &&

Ananya Seelam . resolved

nit: I think we can remove this since IsFuseboxEligible() checks IsAimEligible() as well. See: https://source.chromium.org/chromium/chromium/src/+/main:components/omnibox/browser/aim_eligibility_service.cc;l=534

Stepan Khapugin

Done

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 1: aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Ananya Seelam . resolved

nit: same as above, not sure if we need to also check `aimAllowed`.

Stepan Khapugin

aimAllowed also checks the form factor (we currently enable it separately on tablets), so I will keep this as is. But when we ship fusebox, we'll be able to remove the IsDisableComposeboxFromAIMNTPEnabled() check and then we can swap IsAimEligible with IsFuseboxEligible above.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 11, 2026, 9:14:22 AMMar 11

to Stepan Khapugin, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Stepan Khapugin

Christian Xu voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 11, 2026, 9:14:47 AMMar 11

to Stepan Khapugin, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Stepan Khapugin

Christian Xu voted

Code-Review	-1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 11, 2026, 9:15:25 AMMar 11

to Stepan Khapugin, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Stepan Khapugin

Christian Xu added 1 comment

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 2 (Latest): aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Christian Xu . unresolved

This should not change AIM availability on the NTP it should redirect the AIM button to the web instead of fusebox.

Open in Gerrit

Related details

Attention is currently required from:

Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 11, 2026, 9:16:10 AMMar 11

to Stepan Khapugin, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu and Stepan Khapugin

Christian Xu voted and added 1 comment

Votes added by Christian Xu

Commit-Queue

+1

1 comment

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 2 (Latest): aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Christian Xu . unresolved

This should not change AIM availability on the NTP it should redirect the AIM button to the web instead of fusebox.

Christian Xu

This is handled at `openMIA` in the coordinator

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 9:20:05 AMMar 11

to Christian Xu, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu

Stepan Khapugin added 1 comment

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 2 (Latest): aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Christian Xu . unresolved

This should not change AIM availability on the NTP it should redirect the AIM button to the web instead of fusebox.

Christian Xu

This is handled at `openMIA` in the coordinator

Stepan Khapugin

I don't think it's correct. I think to have a correct comparison across experiment arms, this should be fully disabled for non-fusebox users. Let's confirm with PM.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 10:01:09 AMMar 11

to Gauthier Ambard, Christian Xu, Ananya Seelam, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam, Christian Xu and Gauthier Ambard

Stepan Khapugin voted and added 1 comment

Votes added by Stepan Khapugin

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Stepan Khapugin . resolved

Prepping this alternative CL while waiting for PM decision on how to proceed.

Open in Gerrit

Related details

Attention is currently required from:

Ananya Seelam
Christian Xu
Gauthier Ambard

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 10:01:10 AMMar 11

to Gauthier Ambard, Christian Xu, Ananya Seelam, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam, Christian Xu and Gauthier Ambard

Stepan Khapugin voted Auto-Submit+0

Auto-Submit

+0

satisfied_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 10:01:24 AMMar 11

to Christian Xu, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu

Stepan Khapugin voted and added 1 comment

Votes added by Stepan Khapugin

Auto-Submit

+0

1 comment

File ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator.mm

Line 646, Patchset 2: aimAllowed = aimAllowed && _aimEligibilityService->IsFuseboxEligible();

Christian Xu . unresolved

This should not change AIM availability on the NTP it should redirect the AIM button to the web instead of fusebox.

Christian Xu

This is handled at `openMIA` in the coordinator

Stepan Khapugin

I don't think it's correct. I think to have a correct comparison across experiment arms, this should be fully disabled for non-fusebox users. Let's confirm with PM.

Stepan Khapugin

Per offline discussion, even if we're going with what I think is the intention here, there should be an additional check for IsComposeboxIOSEnabled(). Added.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 11, 2026, 10:05:30 AMMar 11

to Stepan Khapugin, Chromium LUCI CQ, Gauthier Ambard, Christian Xu, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Christian Xu and Gauthier Ambard

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ananya Seelam . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Gauthier Ambard

Submit Requirements:

Code-Coverage

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 11, 2026, 10:10:36 AMMar 11

to Stepan Khapugin, Ananya Seelam, Chromium LUCI CQ, Gauthier Ambard, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Gauthier Ambard and Stepan Khapugin

Christian Xu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Gauthier Ambard
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 11, 2026, 2:47:40 PMMar 11

to Chris Lu, Christian Xu, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Chris Lu

Stepan Khapugin voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

Mar 11, 2026, 2:55:06 PMMar 11

to Stepan Khapugin, Christian Xu, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Stepan Khapugin

Chris Lu voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 11, 2026, 10:05:59 PMMar 11

to Stepan Khapugin, Chris Lu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Chris Lu and Stepan Khapugin

Ananya Seelam added 1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1607, Patchset 2 (Latest): return _aimEligibilityService->IsFuseboxEligible();

Ananya Seelam . unresolved

Sorry for the churn here, but we should actually keep the `IsAimEligible` check in thie CL. Just found out that we will need to remove the `IsAimEligible` check in `IsFuseboxEligible` so keeping it here would be good to future proof this CL. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 11, 2026, 10:54:30 PMMar 11

to Stepan Khapugin, Chris Lu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Chris Lu and Stepan Khapugin

Ananya Seelam added 1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1607, Patchset 2 (Latest): return _aimEligibilityService->IsFuseboxEligible();

Ananya Seelam . resolved

Sorry for the churn here, but we should actually keep the `IsAimEligible` check in thie CL. Just found out that we will need to remove the `IsAimEligible` check in `IsFuseboxEligible` so keeping it here would be good to future proof this CL. Thank you!

Ananya Seelam

Nevermind confirmed with Moe that we can keep the mobile code as is. Please disregard the above message!

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 12, 2026, 9:04:48 AMMar 12

to Stepan Khapugin, Chris Lu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Chris Lu, Christian Xu and Stepan Khapugin

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Ananya Seelam . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu
Christian Xu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Stepan Khapugin (Gerrit)

unread,

Mar 12, 2026, 9:37:15 AMMar 12

to Ananya Seelam, Chris Lu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam, Chris Lu and Christian Xu

Stepan Khapugin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Ananya Seelam
Chris Lu
Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 12, 2026, 9:39:18 AMMar 12

to Stepan Khapugin, Ananya Seelam, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam, Chris Lu and Stepan Khapugin

Christian Xu voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Ananya Seelam
Chris Lu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ananya Seelam (Gerrit)

unread,

Mar 12, 2026, 11:48:48 AMMar 12

to Stepan Khapugin, Christian Xu, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Chris Lu, Christian Xu and Stepan Khapugin

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Ananya Seelam . resolved

still lgtm

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu
Christian Xu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Mar 12, 2026, 11:59:39 AMMar 12

to Stepan Khapugin, Ananya Seelam, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Attention needed from Ananya Seelam, Chris Lu and Stepan Khapugin

Christian Xu voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Ananya Seelam
Chris Lu
Stepan Khapugin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 12, 2026, 1:00:48 PMMar 12

to Stepan Khapugin, Christian Xu, Ananya Seelam, Chris Lu, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, thegreenf...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[iOS][aim-eligibility] Gate iOS fusebox on `IsFuseboxEligible`

1. Gate fusebox on fusebox eligibility
2. Redirect AIM NTP shortcut to web, depending on fusebox eligibility,
when it normally opens fusebox.

Bug: b:489854090

Change-Id: Ia49da7fb627130763692e617b1abc05096f4190f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653643

Auto-Submit: Stepan Khapugin <stkha...@chromium.org>

Commit-Queue: Christian Xu <chris...@chromium.org>

Reviewed-by: Christian Xu <chris...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1598504}

Files:

M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator_unittest.mm
M ios/chrome/browser/composebox/eg_tests/composebox_app_interface.h
M ios/chrome/browser/composebox/eg_tests/composebox_app_interface.mm
M ios/chrome/browser/composebox/eg_tests/composebox_egtest.mm
M ios/chrome/browser/ntp/ui_bundled/BUILD.gn
M ios/chrome/browser/ntp/ui_bundled/new_tab_page_coordinator.mm

Change size: S

Delta: 7 files changed, 21 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Christian Xu

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Stepan Khapugin (Gerrit)

unread,

Mar 12, 2026, 1:15:30 PMMar 12

to Christian Xu, Gauthier Ambard, Ananya Seelam, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Stepan Khapugin abandoned this change.

View Change

Abandoned

Stepan Khapugin abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[iOS][aim-eligibility] Gate iOS fusebox on `IsFuseboxEligible` [chromium/src : main]

Stepan Khapugin (Gerrit)

Stepan Khapugin voted

Related details

Ananya Seelam (Gerrit)

Ananya Seelam voted and added 3 comments

Votes added by Ananya Seelam

3 comments

Related details

Gauthier Ambard (Gerrit)

Gauthier Ambard voted Code-Review+1

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin voted and added 2 comments

Votes added by Stepan Khapugin

2 comments

Related details

Christian Xu (Gerrit)

Christian Xu voted

Related details

Christian Xu (Gerrit)

Christian Xu voted

Related details

Christian Xu (Gerrit)

Christian Xu added 1 comment

Related details

Christian Xu (Gerrit)

Christian Xu voted and added 1 comment

Votes added by Christian Xu

1 comment

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin added 1 comment

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin voted and added 1 comment

Votes added by Stepan Khapugin

1 comment

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin voted Auto-Submit+0

Stepan Khapugin (Gerrit)

Stepan Khapugin voted and added 1 comment

Votes added by Stepan Khapugin

1 comment

Related details

Ananya Seelam (Gerrit)

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam

1 comment

Related details

Christian Xu (Gerrit)

Christian Xu voted Code-Review+1

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin voted Auto-Submit+1

Related details

Chris Lu (Gerrit)

Chris Lu voted

Related details

Ananya Seelam (Gerrit)

Ananya Seelam added 1 comment

Related details

Ananya Seelam (Gerrit)

Ananya Seelam added 1 comment

Related details

Ananya Seelam (Gerrit)

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam

1 comment

Related details

Stepan Khapugin (Gerrit)

Stepan Khapugin voted Commit-Queue+2

Related details

Christian Xu (Gerrit)

Christian Xu voted

Related details

Ananya Seelam (Gerrit)

Ananya Seelam voted and added 1 comment

Votes added by Ananya Seelam