[Gardener] Revert "media: Remove raw pointer version of VF::WrapExternalYuvDataWithLayout" [chromium/src : main]

0 views
Skip to first unread message

Sana Akbani (Gerrit)

unread,
Oct 9, 2025, 6:56:45 PM (2 days ago) Oct 9
to Rubber Stamper, Dale Curtis, Chromium LUCI CQ, Colin Blundell, Eugene Zemtsov, AyeAye, chromium...@chromium.org, oshima...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org
Attention needed from Colin Blundell and Eugene Zemtsov

Sana Akbani voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic158a0a6b2e4201c0a9d26016705b426e200f4de
Gerrit-Change-Number: 7030024
Gerrit-PatchSet: 1
Gerrit-Owner: Sana Akbani <sanaa...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Oct 2025 22:56:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Oct 9, 2025, 6:57:33 PM (2 days ago) Oct 9
to Sana Akbani, Dale Curtis, Chromium LUCI CQ, Colin Blundell, Eugene Zemtsov, AyeAye, chromium...@chromium.org, oshima...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org
Attention needed from Colin Blundell and Eugene Zemtsov

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Eugene Zemtsov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic158a0a6b2e4201c0a9d26016705b426e200f4de
    Gerrit-Change-Number: 7030024
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sana Akbani <sanaa...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
    Gerrit-CC: Dale Curtis <dalec...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Oct 2025 22:57:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 9, 2025, 6:58:04 PM (2 days ago) Oct 9
    to Sana Akbani, Rubber Stamper, Dale Curtis, Colin Blundell, Eugene Zemtsov, AyeAye, chromium...@chromium.org, oshima...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Gardener] Revert "media: Remove raw pointer version of VF::WrapExternalYuvDataWithLayout"

    This reverts commit 59b4e645b3dc2e328259455c4b4fb735c18ee330.

    Reason for revert: Suspected cause of breakages for VideoDecoderTest on ChromeOS. See failures: https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel-gtest

    Original change's description:
    > media: Remove raw pointer version of VF::WrapExternalYuvDataWithLayout
    >
    > Bug: 338570700
    > Change-Id: I956e8421ca5aa57c90e497cef50e70b5c552db6b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7023869
    > Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
    > Reviewed-by: Colin Blundell <blun...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1527651}
    Bug: 338570700
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: Ic158a0a6b2e4201c0a9d26016705b426e200f4de
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Sana Akbani <sanaa...@google.com>
    Owners-Override: Sana Akbani <sanaa...@google.com>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1527816}
    Files:
    • M components/chromeos_camera/mjpeg_decode_accelerator_unittest.cc
    • M media/base/video_frame.cc
    • M media/base/video_frame.h
    • M media/gpu/chromeos/generic_dmabuf_video_frame_mapper.cc
    • M media/gpu/chromeos/gpu_memory_buffer_video_frame_mapper.cc
    • M media/gpu/test/video_test_helpers.cc
    • M media/gpu/vaapi/vaapi_dmabuf_video_frame_mapper.cc
    Change size: M
    Delta: 7 files changed, 52 insertions(+), 37 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic158a0a6b2e4201c0a9d26016705b426e200f4de
    Gerrit-Change-Number: 7030024
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Eugene Zemtsov (Gerrit)

    unread,
    Oct 10, 2025, 7:10:41 PM (6 hours ago) Oct 10
    to Sana Akbani, Chromium LUCI CQ, Rubber Stamper, Dale Curtis, Colin Blundell, Eugene Zemtsov, AyeAye, chromium...@chromium.org, oshima...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org

    Eugene Zemtsov has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages