media: Default to NV12 in VideoEncodeAcceleratorAdapter [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Jan 20, 2026, 1:54:00 PM (12 hours ago) Jan 20
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jan 20, 2026, 1:54:27 PM (12 hours ago) Jan 20
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dale Curtis . unresolved
Also, I'd tag this with a bug and add some description on how you tested it.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jan 20, 2026, 4:22:49 PM (10 hours ago) Jan 20
to Eugene Zemtsov, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Eugene Zemtsov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Eugene Zemtsov
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File-level comment, Patchset 3:
Dale Curtis . resolved
Eugene ZemtsovWhy not fuchsia too?
Fuchsia only support I420 for now. crbug.com/40241991
Also, I'd tag this with a bug and add some description on how you tested it.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jan 20, 2026, 4:24:50 PM (10 hours ago) Jan 20
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
File media/video/video_encode_accelerator_adapter.h
Line 202, Patchset 5 (Latest):
#if BUILDFLAG(IS_FUCHSIA)Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jan 20, 2026, 4:46:10 PM (9 hours ago) Jan 20
to Eugene Zemtsov, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Eugene Zemtsov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eugene Zemtsov
| Commit-Queue | +2 |
1 comment
File media/video/video_encode_accelerator_adapter.h
Can you tag this as TODO(crbug.com/40241991) ?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 20, 2026, 7:53:28 PM (6 hours ago) Jan 20
to Eugene Zemtsov, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: media/video/video_encode_accelerator_adapter.h
Insertions: 1, Deletions: 0.
@@ -200,6 +200,7 @@
VideoEncodeAccelerator::Config::EncoderType required_encoder_type_ =
VideoEncodeAccelerator::Config::EncoderType::kHardware;
#if BUILDFLAG(IS_FUCHSIA)
+ // TODO(crbug.com/40241991): Fuchsia only supports I420 for now.
static constexpr VideoPixelFormat kDefaultPixelFormat = PIXEL_FORMAT_I420;
#else
static constexpr VideoPixelFormat kDefaultPixelFormat = PIXEL_FORMAT_NV12;
```
Change information
Commit message:
media: Default to NV12 in VideoEncodeAcceleratorAdapter
Updates VideoEncodeAcceleratorAdapter to default to PIXEL_FORMAT_NV12 on
most platforms (excluding Fuchsia).
This aligns better with hardware encoder preferences.
Bug: 477318782, 40241991
Test: CI/CQ bots
Change-Id: Iffb518ff1ea726a386dfacdf64f246eb15e43f01
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571970}
Files:
- M media/video/video_encode_accelerator_adapter.cc
- M media/video/video_encode_accelerator_adapter.h
- M media/video/video_encode_accelerator_adapter_test.cc
Change size: M
Delta: 3 files changed, 34 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages