[M152] [ios][composebox] Pass fetched Drive item icons to Composebox input items [chromium/src : refs/branch-heads/7977]
0 views
Skip to first unread message
chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
5:52 AM (2 hours ago) 5:52 AM
to Elmehdi Rahmaoui, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org
chrome-che...@chops-service-accounts.iam.gserviceaccount.com voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
5:53 AM (2 hours ago) 5:53 AM
to Elmehdi Rahmaoui, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:51 AM (1 hour ago) 6:51 AM
to Elmehdi Rahmaoui, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, marq+...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M152] [ios][composebox] Pass fetched Drive item icons to Composebox input items
Original change's description:
> [ios][composebox] Pass fetched Drive item icons to Composebox input items
>
> Populate and pass the custom or placeholder icon of picked Drive items
> from RootDriveFilePickerCoordinator through to ComposeboxInputItemView.
> - Add `GetFetchedImage()` to DriveFilePickerImageFetcher to allow synchronous
> lookup of cached thumbnails/icons for a DriveItem.
> - Add an `icon` property to ComposeboxPickerDriveResult.
> - Populate `icon` in RootDriveFilePickerCoordinator using the cached image or fallback placeholder image.
> - Thread `icon` through ComposeboxInputPlateCoordinator and Mediator to set `leadingIconImage` on the input item.
> - Update ComposeboxInputItemView to prefer `item.leadingIconImage` over the default `SymbolMyDrive` symbol.
>
> Bug: 540385191
> Change-Id: If06af6c1d9dfc39a6e0dbefbe4335a9b0fcc759c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8158753
> Reviewed-by: Quentin Pubert <qpu...@google.com>
> Commit-Queue: Elmehdi Rahmaoui <erah...@google.com>
> Reviewed-by: Stepan Khapugin <stkha...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1670435}
(cherry picked from commit 59fb5f0e3ee9db55732dc273d581623bd57d051b)
Bug: 542890017,540385191
Change-Id: If06af6c1d9dfc39a6e0dbefbe4335a9b0fcc759c
Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7977@{#668}
Cr-Branched-From: b7fe14017379ddffae396d944fb8b59a5896c261-refs/heads/main@{#1669021}
Files:
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_coordinator.mm
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.h
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
- M ios/chrome/browser/composebox/shared/coordinator/composebox_picker_drive_result.h
- M ios/chrome/browser/composebox/ui/composebox_input_item_view.mm
- M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_image_fetcher.h
- M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_image_fetcher.mm
- M ios/chrome/browser/drive_file_picker/coordinator/root_drive_file_picker_coordinator.mm
Change size: S
Delta: 8 files changed, 30 insertions(+), 6 deletions(-)
Branch: refs/branch-heads/7977
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages