[CSS] Fix false-positive cycle detection in container queries [chromium/src : main]
0 views
Skip to first unread message
Kurt Catti-Schmidt (Gerrit)
Mar 11, 2026, 11:15:37 AMMar 11
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Anders Hartvoll Ruud
Kurt Catti-Schmidt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 11, 2026, 12:34:42 PMMar 11
to Kurt Catti-Schmidt, Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Anders Hartvoll Ruud and Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.css complete.
- AtScopeAncestor: base median = 3.9799999997019766 -> patched median = 4.039999999850989
- CSSCountersCreate: base median = 20.440000000223517 -> patched median = 20.520000000204888
- CSSCountersReversedCreate1: base median = 20.779999999329448 -> patched median = 20.85
- CSSCountersReversedCreate2: base median = 199.02999999999446 -> patched median = 200.59000000003726
- CSSCountersReversedCreate3: base median = 144.9800000000745 -> patched median = 145.8099999997765
- CSSLogicalDirection: base median = 9.560000000149012 -> patched median = 9.639999999897555
- CSSPropertySetterGetter: base median = 14769.650104925793 -> patched median = 14928.675661535688
- CSSPropertySetterGetterMethods: base median = 16824.913758333056 -> patched median = 16975.489384874218
- ChangeStyleNewRuleInExistingStylesheet: base median = 11.900000000002912 -> patched median = 11.959999999403953
- ClassDescendantSelector: base median = 2096.823300876875 -> patched median = 2100.190097355552
- CustomPropertiesDependency: base median = 17.119999999552967 -> patched median = 17.140000000596046
- CustomPropertiesNonRootInheritance: base median = 8.019999999552965 -> patched median = 8.060000000149012
- CustomPropertiesRootInheritance: base median = 7.930000000447035 -> patched median = 7.959999999776483
- Document::rebuildLayoutTree: base median = 0.013956521739130966 -> patched median = 0.014034782608696124
- HasDescendantInAncestorPositionInvalidation: base median = 1731.6881492846246 -> patched median = 1747.2987280728278
- HasDescendantInvalidation: base median = 6039.028915426894 -> patched median = 6144.867376090988
- HasDescendantInvalidationAllSubjects: base median = 3192.416215916186 -> patched median = 3222.441308633074
- HasDescendantInvalidationMultipleSubjects: base median = 5016.725595596445 -> patched median = 5093.10978894206
- HasDescendantInvalidationWithoutNonMatchingHasRule: base median = 6037.827831433147 -> patched median = 6142.822389813745
- HasInvalidationFiltering: base median = 19777.56116920777 -> patched median = 19957.993228601845
- HasSiblingInvalidation: base median = 6131.734858906671 -> patched median = 6465.170995102129
- HasSiblingInvalidationAllSubjects: base median = 2994.9516375197054 -> patched median = 3021.4775306642687
- PseudoClassSelectors: base median = 8541.306426523774 -> patched median = 8605.30839531303
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/142f704c090000
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Mar 11, 2026, 1:18:53 PMMar 11
to Rune Lillesveen, Steinar H Gunderson, chrom...@appspot.gserviceaccount.com, Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Anders Hartvoll Ruud and Rune Lillesveen
Kurt Catti-Schmidt added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kurt Catti-Schmidt . resolved
Adding Rune, who wrote the test
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Mar 11, 2026, 5:30:08 PMMar 11
to Kurt Catti-Schmidt, Rune Lillesveen, Steinar H Gunderson, chrom...@appspot.gserviceaccount.com, Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Anders Hartvoll Ruud and Kurt Catti-Schmidt
Rune Lillesveen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Rune Lillesveen . resolved
I'll defer to andruud@ since he reviewed this attempt:
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Mar 12, 2026, 5:49:54 AMMar 12
to Kurt Catti-Schmidt, Rune Lillesveen, Steinar H Gunderson, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Kurt Catti-Schmidt
Anders Hartvoll Ruud added 5 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/media_query_evaluator.cc
Line 1834, Patchset 4 (Latest):
if (unparsed->VariableDataValue() &&Anders Hartvoll Ruud . unresolved
We should just `CHECK()` that it exists.
Line 1835, Patchset 4 (Latest):
unparsed->VariableDataValue()->NeedsVariableResolution()) {Anders Hartvoll Ruud . unresolved
Maybe move this to `StyleCascade::ResolveSubstitutions()`?
Line 1836, Patchset 4 (Latest):
StyleResolverState state(container->GetDocument(), *container);
state.CreateNewClonedStyle(container->ComputedStyleRef());Anders Hartvoll Ruud . unresolved
Doing this twice is painful; `ComputedValue` should do whatever needs to be done after its own setup is already on the stack.
Line 1839, Patchset 4 (Latest):
StyleCascade::ResolveSubstitutions(Anders Hartvoll Ruud . unresolved
OK, but then let's drop the comment (near the function definition) about it being intended for the inspector.
Also, I don't remember if we already tried and rejected this in CL:7517065, for some reason. Hopefully not.
Line 1847, Patchset 4 (Latest):
// guaranteed-invalid matching.Anders Hartvoll Ruud . unresolved
Not sure what we mean by "matching" here. But anyway, we'll probably handle this differently inside `ComputeValue`.
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages