[presubmit/sync] Turn deprecated API warning into error for mobile OSes [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Aug 4, 2026, 5:27:12 PM (14 hours ago) Aug 4
to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Andrew Grieve

Victor Vianna voted and added 2 comments

Votes added by Victor Vianna

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
Gerrit-Change-Number: 8192775
Gerrit-PatchSet: 6
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 21:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Aug 4, 2026, 9:16:57 PM (10 hours ago) Aug 4
to Victor Vianna, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Victor Vianna

Andrew Grieve voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 01:16:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    5:35 AM (2 hours ago) 5:35 AM
    to Mahmoud Rashad, Gauthier Ambard, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Gauthier Ambard and Mahmoud Rashad

    Victor Vianna added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Victor Vianna . resolved

    +mmrashad@ for components/sync
    +gambard@ for ios/

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gauthier Ambard
    • Mahmoud Rashad
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 09:35:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mahmoud Rashad (Gerrit)

    unread,
    6:16 AM (1 hour ago) 6:16 AM
    to Victor Vianna, Gauthier Ambard, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Gauthier Ambard and Victor Vianna

    Mahmoud Rashad voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gauthier Ambard
    • Victor Vianna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 10:15:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    6:16 AM (1 hour ago) 6:16 AM
    to Gauthier Ambard, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Gauthier Ambard

    Victor Vianna voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gauthier Ambard
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 10:16:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gauthier Ambard (Gerrit)

    unread,
    7:18 AM (6 minutes ago) 7:18 AM
    to Victor Vianna, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Victor Vianna

    Gauthier Ambard voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 11:17:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    7:19 AM (4 minutes ago) 7:19 AM
    to Gauthier Ambard, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org

    Victor Vianna voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I236f5b2d1f4b69d5ae512729501d80ccecf99a03
    Gerrit-Change-Number: 8192775
    Gerrit-PatchSet: 6
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 11:19:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    7:20 AM (4 minutes ago) 7:20 AM
    to Gauthier Ambard, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org

    Victor Vianna voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Wed, 05 Aug 2026 11:19:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages