Add MEDIA_EXPORT for AudioManagerApple [chromium/src : main]
Olga Sharonova (Gerrit)
Olga Sharonova added 1 comment![]( "Open in Gerrit")
The problem is unclear. Chromium builds just fine at the moment.
Related details
- Qihu Yuan
- Tomas Gunnarsson
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomas Gunnarsson (Gerrit)
Tomas Gunnarsson added 1 comment![]( "Open in Gerrit")
can you add the problematic build configuration to the bug?
Related details
- Qihu Yuan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihu Yuan (Gerrit)
Qihu Yuan added 1 comment![]( "Open in Gerrit")
The problem is unclear. Chromium builds just fine at the moment.
The issue occurs when using AudioManagerMac across module boundaries (Mac Debug). While the internal Chromium build works (since AudioManagerApple isn't used across modules internally), its missing MEDIA_EXPORT breaks symbol visibility for derived classes in external modules. This appears to be an oversight in the export design.
cc@tommi@chromium.org
Related details
- Olga Sharonova
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomas Gunnarsson (Gerrit)
Tomas Gunnarsson added 1 comment![]( "Open in Gerrit")
Qihu YuanThe problem is unclear. Chromium builds just fine at the moment.
The issue occurs when using AudioManagerMac across module boundaries (Mac Debug). While the internal Chromium build works (since AudioManagerApple isn't used across modules internally), its missing MEDIA_EXPORT breaks symbol visibility for derived classes in external modules. This appears to be an oversight in the export design.
cc@tommi@chromium.org
Sounds like you're fixing something that's an issue with an external project and not something that is a part of any of the targets in chromium. How would this get detected if it regressed?
Related details
- Olga Sharonova
- Qihu Yuan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihu Yuan (Gerrit)
Qihu Yuan added 1 comment![]( "Open in Gerrit")
Qihu YuanThe problem is unclear. Chromium builds just fine at the moment.
Tomas GunnarssonThe issue occurs when using AudioManagerMac across module boundaries (Mac Debug). While the internal Chromium build works (since AudioManagerApple isn't used across modules internally), its missing MEDIA_EXPORT breaks symbol visibility for derived classes in external modules. This appears to be an oversight in the export design.
cc@tommi@chromium.org
Sounds like you're fixing something that's an issue with an external project and not something that is a part of any of the targets in chromium. How would this get detected if it regressed?
You’re right—this is indeed an issue that surfaces only in external usage scenarios, and it does not affect Chromium’s current internal builds.
If the focus remains solely on Chromium’s existing targets, we understand that this may not be treated as a required fix. We can certainly work around it in our own code by adding the MEDIA_EXPORT locally.
I could also contribute a minimal test target to validate cross-module usage, though I recognize that may not be needed for Chromium.
Please advise on your preference.
Related details
- Olga Sharonova
- Tomas Gunnarsson
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olga Sharonova (Gerrit)
Olga Sharonova added 1 comment![]( "Open in Gerrit")
Qihu YuanThe problem is unclear. Chromium builds just fine at the moment.
Tomas GunnarssonThe issue occurs when using AudioManagerMac across module boundaries (Mac Debug). While the internal Chromium build works (since AudioManagerApple isn't used across modules internally), its missing MEDIA_EXPORT breaks symbol visibility for derived classes in external modules. This appears to be an oversight in the export design.
cc@tommi@chromium.org
Qihu YuanSounds like you're fixing something that's an issue with an external project and not something that is a part of any of the targets in chromium. How would this get detected if it regressed?
You’re right—this is indeed an issue that surfaces only in external usage scenarios, and it does not affect Chromium’s current internal builds.
If the focus remains solely on Chromium’s existing targets, we understand that this may not be treated as a required fix. We can certainly work around it in our own code by adding the MEDIA_EXPORT locally.
I could also contribute a minimal test target to validate cross-module usage, though I recognize that may not be needed for Chromium.
Please advise on your preference.
It's preferable to not add any code Chromium does not benefit from directly, as any new code always means an added maintenance cost.
Related details
- Qihu Yuan
- Tomas Gunnarsson
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |