[locales] Add Android xml pseudolocales [chromium/src : main]

Trevor Perrier (Gerrit)

unread,

Feb 16, 2022, 1:25:49 PM2/16/22

to Matt Stark, Andrew Grieve, android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention is currently required from: Matt Stark, Andrew Grieve.

Trevor Perrier would like Matt Stark and Andrew Grieve to review this change.

View Change

[locales] Add Android xml pseudolocales

This CL adds ar-XB and en-XA to unofficial Android builds.

The languages can be found under the names:
  - RTL pseudolocale (ar-XB)
  - Long strings pseudolocale (en-XA)

Bug: 1297917
Change-Id: Ifbba4d59c277e16955ec6613abcc48bc212d5379
---
M android_webview/java/strings/android_webview_strings.grd
M base/win/embedded_i18n/generate_embedded_i18n.gni
M build/config/locales.gni
M chrome/android/features/keyboard_accessory/internal/java/strings/android_keyboard_accessory_strings.grd
M chrome/android/features/start_surface/internal/java/strings/android_chrome_start_surface_strings.grd
M chrome/android/features/tab_ui/java/strings/android_chrome_tab_ui_strings.grd
M chrome/android/features/vr/java/strings/android_chrome_vr_strings.grd
M chrome/android/webapk/strings/android_webapk_strings.grd
M chrome/app/chromium_strings.grd
M chrome/app/generated_resources.grd
M chrome/app/google_chrome_strings.grd
M chrome/browser/password_check/android/internal/java/strings/android_password_check_strings.grd
M chrome/browser/touch_to_fill/android/internal/java/strings/android_touch_to_fill_strings.grd
M chrome/browser/ui/android/strings/android_chrome_strings.grd
M components/autofill/android/java/strings/autofill_strings.grd
M components/autofill_assistant/android/internal/java/strings/android_chrome_autofill_assistant_strings.grd
M components/browser_ui/strings/android/browser_ui_strings.grd
M components/components_locale_settings.grd
M components/components_strings.grd
M components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd
M components/javascript_dialogs/android/javascript_dialogs_android_strings.grd
M components/media_router/browser/android/java/strings/android_chrome_media_router_strings.grd
M components/permissions/android/permissions_android_strings.grd
M components/webapps/browser/android/android_webapps_strings.grd
M content/public/android/java/strings/android_content_strings.grd
M ui/android/java/strings/android_ui_strings.grd
M weblayer/browser/java/weblayer_strings.grd
27 files changed, 186 insertions(+), 96 deletions(-)

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Trevor Perrier (Gerrit)

unread,

Feb 16, 2022, 1:25:56 PM2/16/22

to android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Matt Stark, Andrew Grieve.

View Change

1 comment:

Patchset:
- Patch Set #3:
  Hi Andrew and Matt,
  This is the follow up CL that actually adds the pseudolocales to android_bundle_locales_as_resources. It puts the pseudolocales on the all_chrome_locales list and then removes them as needed later on.
  PTAL - thanks!

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Andrew Grieve (Gerrit)

unread,

Feb 16, 2022, 4:01:19 PM2/16/22

to Trevor Perrier, android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Matt Stark, Trevor Perrier.

Patch set 5:Code-Review +1

View Change

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Matt Stark (Gerrit)

unread,

Feb 16, 2022, 9:39:06 PM2/16/22

to Trevor Perrier, android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Trevor Perrier.

View Change

1 comment:

Patchset:
- Patch Set #3:
  Hi Andrew and Matt, […]
  I don't have permission to vote, but LGTM

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Andrew Grieve (Gerrit)

unread,

Feb 16, 2022, 9:42:40 PM2/16/22

to Trevor Perrier, android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Trevor Perrier.

Patch set 5:Owners-Override +1

View Change

1 comment:

Patchset:
- Patch Set #5:
  Adding OO+1 since this is a broad refactor.

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Trevor Perrier (Gerrit)

unread,

Feb 17, 2022, 2:46:46 PM2/17/22

to android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Trevor Perrier.

Patch set 5:Commit-Queue +2

View Change

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Trevor Perrier (Gerrit)

unread,

Feb 18, 2022, 12:57:53 PM2/18/22

to android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Trevor Perrier.

Patch set 6:Commit-Queue +2

View Change

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Feb 18, 2022, 1:00:54 PM2/18/22

to Trevor Perrier, android-web...@chromium.org, autofill_ass...@google.com, browser-comp...@chromium.org, cricke...@chromium.org, davidj...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, grt+...@chromium.org, hanxi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, mfoltz...@chromium.org, mxcai+wat...@chromium.org, pkotwic...@chromium.org, roblia...@chromium.org, srahim...@chromium.org, vasilii+watchlis...@chromium.org, vmpstr...@chromium.org, webapks-...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Andrew Grieve, Matt Stark, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change



5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Andrew Grieve: Looks good to me; Looks good to me
  Trevor Perrier: Commit

[locales] Add Android xml pseudolocales

This CL adds ar-XB and en-XA to unofficial Android builds.

The languages can be found under the names:
  - RTL pseudolocale (ar-XB)
  - Long strings pseudolocale (en-XA)

Bug: 1297917
Change-Id: Ifbba4d59c277e16955ec6613abcc48bc212d5379

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3467575
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Owners-Override: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Trevor Perrier <per...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973013}

27 files changed, 191 insertions(+), 96 deletions(-)

To view, visit change 3467575. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward