Gemini's crack at addressing this comment: [chromium/src : main]

0 views

Skip to first unread message

Rune Lillesveen (Gerrit)

unread,

5:29 AM (4 hours ago) 5:29 AM

to Mason Freed, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Attention needed from Mason Freed

Rune Lillesveen added 2 comments

File third_party/blink/renderer/core/css/style_engine.cc

Line 1276, Patchset 1 (Latest): (!element->IsPseudoElement() &&

Rune Lillesveen . unresolved

If it doesn't cause any problems, I think we should drop the IsPseudoElement() condition in case we have a getComputedStyle() API in the future that would support e.g. getting computed styles for ::marker on a generated ::before element when the ::marker is not generated. Otherwise, this could become a hard-to-find invalidation problem.

File third_party/blink/renderer/core/dom/element.cc

Line 10947, Patchset 1 (Latest): if (func(*pseudo_element->GetComputedStyle())) {

Rune Lillesveen . unresolved

This seems messy. In MarkElementsForRecalc, we already traverse pseudo elements, and then we do it again here. Perhaps this is necessary for the ::-webkit-scrollbar-* ones mentioned above since they're typically not part of the traversal?

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages