Fix HLS live streams to start at live edge instead [chromium/src : main]

0 views
Skip to first unread message

Ted (Chromium) Meyer (Gerrit)

unread,
Nov 12, 2025, 5:18:08 PMNov 12
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis

Ted (Chromium) Meyer voted and added 1 comment

Votes added by Ted (Chromium) Meyer

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ted (Chromium) Meyer . resolved

I ended up addressing my comments from the other CL here, mostly because I think it's worth getting this fixed sooner - live content starting at 3 segments from the end was something that both myself and the old android implementation overlooked in the spec.

The only real test changes now are correctly not requesting the early segments (when/if there are any), as well as having to add a new sample manifest to hls_rendition_impl_unittest in order to get the timestamp math to be nice enough to not need to change the test semantics.

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
Gerrit-Change-Number: 7147199
Gerrit-PatchSet: 3
Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 22:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Nov 12, 2025, 7:03:11 PMNov 12
to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review+1

1 comment

File media/formats/hls/segment_stream_unittest.cc
Line 258, Patchset 4 (Latest): "#EXTINF:9.2,", // This long
Dale Curtis . unresolved
If you want:
```
  // clang-format off
  // clang-format on
```
Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
    Gerrit-Change-Number: 7147199
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Comment-Date: Thu, 13 Nov 2025 00:02:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ted (Chromium) Meyer (Gerrit)

    unread,
    Nov 12, 2025, 10:23:21 PMNov 12
    to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

    Ted (Chromium) Meyer voted and added 1 comment

    Votes added by Ted (Chromium) Meyer

    Commit-Queue+2

    1 comment

    File media/formats/hls/segment_stream_unittest.cc
    Line 258, Patchset 4 (Latest): "#EXTINF:9.2,", // This long
    Dale Curtis . resolved
    If you want:
    ```
      // clang-format off
      // clang-format on
    ```
    Ted (Chromium) Meyer

    I prefer the whimsical approach.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
      Gerrit-Change-Number: 7147199
      Gerrit-PatchSet: 4
      Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Comment-Date: Thu, 13 Nov 2025 03:23:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ted (Chromium) Meyer (Gerrit)

      unread,
      Nov 13, 2025, 12:15:02 PMNov 13
      to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

      Ted (Chromium) Meyer voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
        Gerrit-Change-Number: 7147199
        Gerrit-PatchSet: 6
        Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
        Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
        Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 17:14:50 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Nov 13, 2025, 3:16:15 PMNov 13
        to Ted (Chromium) Meyer, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Fix HLS live streams to start at live edge instead

        Live HLS streams were starting playback at the oldest available segment
        (beginning of the DVR window) instead of at the live edge, causing users
        to see stale content from hours ago rather than the current live stream.

        This is based on
        https://chromium-review.googlesource.com/c/chromium/src/+/7095648,
        but with fixed tests.
        Fixed: 456214597
        Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
        Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
        Commit-Queue: Ted (Chromium) Meyer <tmath...@chromium.org>
        Reviewed-by: Dale Curtis <dalec...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1544416}
        Files:
        • M media/filters/hls_manifest_demuxer_engine_unittest.cc
        • M media/filters/hls_rendition_impl_unittest.cc
        • M media/formats/hls/segment_stream.cc
        • M media/formats/hls/segment_stream.h
        • M media/formats/hls/segment_stream_unittest.cc
        Change size: M
        Delta: 5 files changed, 134 insertions(+), 38 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Ted (Chromium) Meyer, +1 by Dale Curtis
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie283941ee85958dc23eb3d2cdc6fa0a88fb8ad5a
        Gerrit-Change-Number: 7147199
        Gerrit-PatchSet: 7
        Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
        Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages