[RTCLogging] Add RTCLoggingDispatcher [chromium/src : main]

0 views
Skip to first unread message

Guido Urdaneta (Gerrit)

unread,
Mar 2, 2026, 7:17:38 PM (3 days ago) Mar 2
to Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

Guido Urdaneta added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Guido Urdaneta . resolved

tsepez@: please review IPC
tkent@: please review runtime_enabled_features.json5 (feel free to take a look at the follow-up CL with the blink code https://crrev.com/c/7620303)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
Gerrit-Change-Number: 7617174
Gerrit-PatchSet: 6
Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 00:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
Mar 2, 2026, 7:18:10 PM (3 days ago) Mar 2
to Tom Sepez, Kent Tamura, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Kent Tamura and Tom Sepez

Guido Urdaneta added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Guido Urdaneta . resolved

tsepez@: please review IPC
tkent@: please review runtime_enabled_features.json5 (feel free to take a look at the follow-up CL with the blink code https://crrev.com/c/7620303)

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
Gerrit-Change-Number: 7617174
Gerrit-PatchSet: 6
Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 00:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Mar 2, 2026, 7:25:23 PM (3 days ago) Mar 2
to Guido Urdaneta, Kent Tamura, Tom Sepez, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Guido Urdaneta and Tom Sepez

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Code-Review+1

1 comment

Patchset-level comments
Guido Urdaneta . resolved

tsepez@: please review IPC
tkent@: please review runtime_enabled_features.json5 (feel free to take a look at the follow-up CL with the blink code https://crrev.com/c/7620303)

Kent Tamura

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
  • Tom Sepez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
    Gerrit-Change-Number: 7617174
    Gerrit-PatchSet: 6
    Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 00:24:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Guido Urdaneta <gui...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guido Urdaneta (Gerrit)

    unread,
    Mar 2, 2026, 8:32:32 PM (3 days ago) Mar 2
    to Rakina Zata Amni, Dave Tapuska, Kent Tamura, Tom Sepez, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
    Attention needed from Rakina Zata Amni and Tom Sepez

    Guido Urdaneta added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6:
    Guido Urdaneta . resolved

    rakina@: Please review content/public

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rakina Zata Amni
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
    Gerrit-Change-Number: 7617174
    Gerrit-PatchSet: 7
    Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Dave Tapuska <dtap...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 01:32:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rakina Zata Amni (Gerrit)

    unread,
    Mar 2, 2026, 11:34:15 PM (3 days ago) Mar 2
    to Guido Urdaneta, Dave Tapuska, Kent Tamura, Tom Sepez, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
    Attention needed from Guido Urdaneta and Tom Sepez

    Rakina Zata Amni voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Guido Urdaneta
    • Tom Sepez
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 04:34:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guido Urdaneta (Gerrit)

    unread,
    Mar 4, 2026, 5:57:28 AM (yesterday) Mar 4
    to Palak Agarwal, Rakina Zata Amni, Dave Tapuska, Kent Tamura, Tom Sepez, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
    Attention needed from Palak Agarwal and Tom Sepez

    Guido Urdaneta added 1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Guido Urdaneta . resolved

    agpalak@: PTAL

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Palak Agarwal
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
    Gerrit-Change-Number: 7617174
    Gerrit-PatchSet: 7
    Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Dave Tapuska <dtap...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 10:57:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Mar 4, 2026, 1:03:01 PM (yesterday) Mar 4
    to Guido Urdaneta, Palak Agarwal, Rakina Zata Amni, Dave Tapuska, Kent Tamura, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
    Attention needed from Guido Urdaneta and Palak Agarwal

    Tom Sepez voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Guido Urdaneta
    • Palak Agarwal
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
    Gerrit-Change-Number: 7617174
    Gerrit-PatchSet: 7
    Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Dave Tapuska <dtap...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 18:02:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Palak Agarwal (Gerrit)

    unread,
    8:06 AM (6 hours ago) 8:06 AM
    to Guido Urdaneta, Tom Sepez, Rakina Zata Amni, Dave Tapuska, Kent Tamura, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
    Attention needed from Guido Urdaneta

    Palak Agarwal voted and added 1 comment

    Votes added by Palak Agarwal

    Code-Review+1

    1 comment

    File content/browser/renderer_host/media/rtc_logging_dispatcher.cc
    Line 47, Patchset 7 (Latest): ReportBadMessageAndDeleteThis("RTCDiagnosticLogging feature not enabled");
    Palak Agarwal . unresolved

    Doesn't this kill the renderer?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Guido Urdaneta
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
      Gerrit-Change-Number: 7617174
      Gerrit-PatchSet: 7
      Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Dave Tapuska <dtap...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
      Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Comment-Date: Thu, 05 Mar 2026 13:06:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Guido Urdaneta (Gerrit)

      unread,
      8:24 AM (6 hours ago) 8:24 AM
      to Palak Agarwal, Tom Sepez, Rakina Zata Amni, Dave Tapuska, Kent Tamura, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

      Guido Urdaneta voted and added 1 comment

      Votes added by Guido Urdaneta

      Commit-Queue+2

      1 comment

      File content/browser/renderer_host/media/rtc_logging_dispatcher.cc
      Line 47, Patchset 7 (Latest): ReportBadMessageAndDeleteThis("RTCDiagnosticLogging feature not enabled");
      Palak Agarwal . resolved

      Doesn't this kill the renderer?

      Guido Urdaneta

      Yes.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
        Gerrit-Change-Number: 7617174
        Gerrit-PatchSet: 7
        Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
        Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
        Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
        Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Dave Tapuska <dtap...@chromium.org>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
        Gerrit-Comment-Date: Thu, 05 Mar 2026 13:24:06 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Palak Agarwal <agp...@chromium.org>
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        9:39 AM (5 hours ago) 9:39 AM
        to Guido Urdaneta, Palak Agarwal, Tom Sepez, Rakina Zata Amni, Dave Tapuska, Kent Tamura, Thomas Nguyen, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [RTCLogging] Add RTCLoggingDispatcher

        This CL introducees an RTCLoggingDispatcher, which handles IPC
        requests for WebRTC diagnostic logging.

        The functionality is gated behind a Blink RuntimeEnabledFeature flag.
        Bug: 481412281
        Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
        Reviewed-by: Palak Agarwal <agp...@chromium.org>
        Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
        Reviewed-by: Kent Tamura <tk...@chromium.org>
        Reviewed-by: Tom Sepez <tse...@chromium.org>
        Commit-Queue: Guido Urdaneta <gui...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1594647}
        Files:
        • M chrome/browser/chrome_content_browser_client.cc
        • M chrome/browser/chrome_content_browser_client.h
        • M chrome/browser/media/webrtc/rtc_diagnostic_logging_unittest.cc
        • M content/browser/BUILD.gn
        • M content/browser/browser_interface_binders.cc
        • A content/browser/renderer_host/media/rtc_logging_dispatcher.cc
        • A content/browser/renderer_host/media/rtc_logging_dispatcher.h
        • A content/browser/renderer_host/media/rtc_logging_dispatcher_unittest.cc
        • M content/public/browser/content_browser_client.cc
        • M content/public/browser/content_browser_client.h
        • M content/test/BUILD.gn
        • M third_party/blink/public/mojom/BUILD.gn
        • A third_party/blink/public/mojom/rtc_logging/DIR_METADATA
        • A third_party/blink/public/mojom/rtc_logging/OWNERS
        • A third_party/blink/public/mojom/rtc_logging/rtc_logging.mojom
        • M third_party/blink/renderer/platform/runtime_enabled_features.json5
        Change size: L
        Delta: 16 files changed, 518 insertions(+), 19 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Rakina Zata Amni, +1 by Kent Tamura, +1 by Tom Sepez, +1 by Palak Agarwal
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib82f5f4074f77edfe049ecd15645210c633ae8bb
        Gerrit-Change-Number: 7617174
        Gerrit-PatchSet: 8
        Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
        Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
        Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages