| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Would you mind helping with the reland?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Would you mind helping with the reland?
As usual, patchset 1 is a reupload of the original CL, and the other patchsets fix the issue
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
OO+1 for mechanical changes outside of //base to adapt to a //base API change
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reland "Migrate last base::Contains() to std::ranges::contains()"
This is a reland of commit b850aebace5f9df639888eb7afe0d9bd5e6acb0e
A few instances were added since the original CL's dry-run and that
caused failures due IWYU issues. They are now addressed by this reland.
Original change's description:
> Migrate last base::Contains() to std::ranges::contains()
>
> base::Contains() is an alias to std::ranges::contains() since
> crrev.com/c/7415207, so this CL has no behavior change.
>
> I saved headers for last to avoid issues with transitive includes.
>
> Bug: 470391351
> Change-Id: I63c08ad83c5a87999abdfc8d954614f00fa97315
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7459684
> Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
> Commit-Queue: Victor Vianna <victor...@google.com>
> Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1570327}
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8692490039601896801
A revert for this change was not created because there are merged changes depending on it.
Sample failed build: https://ci.chromium.org/b/8692490039601896801
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7486435&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8692490039601896801&type=BUG
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |