[//media] Streamline PCVR waiting on token [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
12:36 PM (2 hours ago) 12:36 PM
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Vasiliy Telezhnikov

Colin Blundell added 1 comment

File media/renderers/paint_canvas_video_renderer.cc
Line 1641, Patchset 1 (Parent): rgb_shared_image->BeginRasterAccess(canvas_ri, rgb_sync_token,
Colin Blundell . unresolved

Just to confirm as this is something I'm a little unsure about wrt sync tokens: It doesn't matter to have the GL interface end up being the one directly waiting on `rgb_sync_token` here, does it - i.e., the net effect is the same?

Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaece63d4c65844aa6273895fce37b28ba81a6257
Gerrit-Change-Number: 7638531
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Mar 2026 17:36:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages