[iOS] Update Ask Gemini Chip Text and Prefilled Prompt for Floaty [chromium/src : main]

0 views
Skip to first unread message

Joemer Ramos (Gerrit)

unread,
Dec 5, 2025, 3:34:11 PM (2 days ago) Dec 5
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro

Joemer Ramos voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
Gerrit-Change-Number: 7232431
Gerrit-PatchSet: 1
Gerrit-Owner: Joemer Ramos <joeme...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
Gerrit-Attention: Adam Arcaro <ada...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 20:34:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Arcaro (Gerrit)

unread,
Dec 5, 2025, 4:02:54 PM (2 days ago) Dec 5
to Joemer Ramos, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Joemer Ramos

Adam Arcaro added 1 comment

File ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
Line 39, Patchset 1 (Latest): @"page. Use a concise, casual tone. Limit to 100 words.";
Adam Arcaro . unresolved

We should still submit official strings for these, so they can eventually be translated

Open in Gerrit

Related details

Attention is currently required from:
  • Joemer Ramos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
    Gerrit-Change-Number: 7232431
    Gerrit-PatchSet: 1
    Gerrit-Owner: Joemer Ramos <joeme...@google.com>
    Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 21:02:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joemer Ramos (Gerrit)

    unread,
    Dec 5, 2025, 11:19:38 PM (2 days ago) Dec 5
    to Joemer Ramos, AyeAye, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Adam Arcaro

    Joemer Ramos voted and added 1 comment

    Votes added by Joemer Ramos

    Auto-Submit+1

    1 comment

    File ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
    Line 39, Patchset 1: @"page. Use a concise, casual tone. Limit to 100 words.";
    Adam Arcaro . resolved

    We should still submit official strings for these, so they can eventually be translated

    Joemer Ramos

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Arcaro
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
      Gerrit-Change-Number: 7232431
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joemer Ramos <joeme...@google.com>
      Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
      Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
      Gerrit-Attention: Adam Arcaro <ada...@google.com>
      Gerrit-Comment-Date: Sat, 06 Dec 2025 04:19:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Adam Arcaro (Gerrit)

      unread,
      Dec 6, 2025, 1:08:28 PM (12 hours ago) Dec 6
      to Joemer Ramos, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Joemer Ramos

      Adam Arcaro voted and added 2 comments

      Votes added by Adam Arcaro

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Adam Arcaro . resolved

      Thanks Joemer!

      File ios/chrome/app/strings/ios_strings.grd
      Line 452, Patchset 3 (Latest): <message name="IDS_IOS_ASK_GEMINI_CHIP_CUE_LABEL" desc="The contextual cue label for the Ask Gemini Chip [iOS only]">
      Adam Arcaro . unresolved

      nit: This doesn't look properly formatted

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joemer Ramos
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
        Gerrit-Change-Number: 7232431
        Gerrit-PatchSet: 3
        Gerrit-Owner: Joemer Ramos <joeme...@google.com>
        Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
        Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
        Gerrit-Attention: Joemer Ramos <joeme...@google.com>
        Gerrit-Comment-Date: Sat, 06 Dec 2025 18:08:19 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Joemer Ramos (Gerrit)

        unread,
        Dec 6, 2025, 9:23:08 PM (3 hours ago) Dec 6
        to Joemer Ramos, Adam Arcaro, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Joemer Ramos voted and added 1 comment

        Votes added by Joemer Ramos

        Auto-Submit+1
        Commit-Queue+2

        1 comment

        File ios/chrome/app/strings/ios_strings.grd
        Line 452, Patchset 3: <message name="IDS_IOS_ASK_GEMINI_CHIP_CUE_LABEL" desc="The contextual cue label for the Ask Gemini Chip [iOS only]">
        Adam Arcaro . resolved

        nit: This doesn't look properly formatted

        Joemer Ramos

        Done

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
          Gerrit-Change-Number: 7232431
          Gerrit-PatchSet: 4
          Gerrit-Owner: Joemer Ramos <joeme...@google.com>
          Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
          Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
          Gerrit-Comment-Date: Sun, 07 Dec 2025 02:23:01 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Dec 6, 2025, 10:52:22 PM (2 hours ago) Dec 6
          to Joemer Ramos, Adam Arcaro, AyeAye, chromium...@chromium.org, srahim...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

          Chromium LUCI CQ submitted the change with unreviewed changes

          Unreviewed changes

          3 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: ios/chrome/app/strings/ios_strings.grd
          Insertions: 1, Deletions: 1.

          @@ -449,7 +449,7 @@
                     =1 {{domain} and 1 other}
                     other {{domain} and {count} others}}
                 </message>
          -            <message name="IDS_IOS_ASK_GEMINI_CHIP_CUE_LABEL" desc="The contextual cue label for the Ask Gemini Chip [iOS only]">
          +      <message name="IDS_IOS_ASK_GEMINI_CHIP_CUE_LABEL" desc="The contextual cue label for the Ask Gemini Chip [iOS only]">
                   Get insights with Gemini
                 </message>
                 <message name="IDS_IOS_ASK_GEMINI_CHIP_PREFILL_PROMPT" desc="Prefill prompt passed to the floaty when the Ask Gemini Chip is tapped [iOS only]">
          ```

          Change information

          Commit message:
          [iOS] Update Ask Gemini Chip Text and Prefilled Prompt for Floaty

          The Ask Gemini Omnibox Chip text and the prompt that shows when a
          user opens the floaty with the flag kAskGeminiChipPrepopulateFloaty
          enabled is being changed.

          UI Video: crbug.com/466413500#attachment71556098
          Fixed: 466413500
          Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
          Reviewed-by: Adam Arcaro <ada...@google.com>
          Auto-Submit: Joemer Ramos <joeme...@google.com>
          Commit-Queue: Joemer Ramos <joeme...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1555182}
          Files:
          • M ios/chrome/app/strings/ios_strings.grd
          • A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_ASK_GEMINI_CHIP_CUE_LABEL.png.sha1
          • A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_ASK_GEMINI_CHIP_PREFILL_PROMPT.png.sha1
          • M ios/chrome/browser/intelligence/bwg/model/bwg_tab_helper.mm
          • M ios/chrome/browser/location_bar/badge/coordinator/BUILD.gn
          • M ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
          Change size: S
          Delta: 6 files changed, 17 insertions(+), 4 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Adam Arcaro
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
          Gerrit-Change-Number: 7232431
          Gerrit-PatchSet: 5
          Gerrit-Owner: Joemer Ramos <joeme...@google.com>
          Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages