Fix unsafe buffer usage in Windows audio code [chromium/src : main]
0 views
Skip to first unread message
Lloyd Huang (Gerrit)
May 12, 2026, 10:14:55 AM (6 days ago) May 12
to Mark Foltz, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Jordan Bayles and Mark Foltz
Lloyd Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jordan Bayles
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Foltz (Gerrit)
May 13, 2026, 4:10:35 PM (5 days ago) May 13
to Lloyd Huang, Henrik Andreasson, Mark Foltz, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson, Jordan Bayles and Lloyd Huang
Mark Foltz added 4 comments![]( "Open in Gerrit")
Patchset-level comments
Mark Foltz . resolved
Thanks! A few suggestions for simpification and modernization.
+henrika as I am not very familiar with Windows audio code.
File media/audio/win/waveout_output_win.cc
Line 73, Patchset 1 (Latest):
DCHECK_GE(n, 0);Mark Foltz . unresolved
base::HeapArray will prevent out-of-bounds indexing, so these DCHECKS are redundant now.
Line 155, Patchset 1 (Latest):
for (int ix = 0; ix != num_buffers_; ++ix) {Mark Foltz . unresolved
```suggestion
for (auto& buffer : buffers_) {
```
etc.
Line 157, Patchset 1 (Latest):
WAVEHDR* buffer = GetBuffer(ix);Mark Foltz . unresolved
```suggestion
WAVEHDR& wave_hdr = buffer.header;
```
Related details
Attention is currently required from:
- Henrik Andreasson
- Jordan Bayles
- Lloyd Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Bayles (Gerrit)
May 13, 2026, 5:54:16 PM (5 days ago) May 13
to Lloyd Huang, Henrik Andreasson, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson and Lloyd Huang
Jordan Bayles added 1 comment![]( "Open in Gerrit")
File media/audio/win/waveout_output_win.cc
Line 69, Patchset 1 (Latest):
return buffer_size_;Jordan Bayles . unresolved
Should we still have a const version of this method? or is it not needed?
Related details
Attention is currently required from:
- Henrik Andreasson
- Lloyd Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henrik Andreasson (Gerrit)
May 15, 2026, 5:42:02 AM (3 days ago) May 15
to Lloyd Huang, Mark Foltz, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Lloyd Huang
Henrik Andreasson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Henrik Andreasson
| Code-Review | +1 |
2 comments
Patchset-level comments
Henrik Andreasson . resolved
Thanks for fixing!
File media/audio/win/waveout_output_win.h
Line 13, Patchset 1 (Parent):
#include <stdint.h>Henrik Andreasson . unresolved
You've added `#include <cstdint>`, so the existing `#include <stdint.h>` is now redundant and can be removed.
Related details
Attention is currently required from:
- Lloyd Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lloyd Huang (Gerrit)
1:25 AM (8 hours ago) 1:25 AM
to Henrik Andreasson, Mark Foltz, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson, Jordan Bayles and Mark Foltz
Lloyd Huang added 5 comments![]( "Open in Gerrit")
File media/audio/win/waveout_output_win.h
Line 13, Patchset 1 (Parent):
#include <stdint.h>Henrik Andreasson . resolved
You've added `#include <cstdint>`, so the existing `#include <stdint.h>` is now redundant and can be removed.
Lloyd Huang
Done
File media/audio/win/waveout_output_win.cc
Should we still have a const version of this method? or is it not needed?
Lloyd Huang
I removed `GetBuffer()` now that the callers iterate over `buffers_` directly, so a const overload is no longer needed.
base::HeapArray will prevent out-of-bounds indexing, so these DCHECKS are redundant now.
Lloyd Huang
Done
```suggestion
for (auto& buffer : buffers_) {
```etc.
Lloyd Huang
Done
```suggestion
WAVEHDR& wave_hdr = buffer.header;
```
Attention is currently required from:
- Henrik Andreasson
- Jordan Bayles
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Bayles (Gerrit)
1:54 AM (7 hours ago) 1:54 AM
to Lloyd Huang, Henrik Andreasson, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson, Lloyd Huang and Mark Foltz
Jordan Bayles voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Henrik Andreasson
- Lloyd Huang
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kelsen Liu (Gerrit)
2:29 AM (7 hours ago) 2:29 AM
to Lloyd Huang, Jordan Bayles, Henrik Andreasson, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson, Lloyd Huang and Mark Foltz
Kelsen Liu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Henrik Andreasson
- Lloyd Huang
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages