[RTCLogging] Add support for for stopping logs in WebRtcRemoteEventLogManager [chromium/src : main]

0 views
Skip to first unread message

Guido Urdaneta (Gerrit)

unread,
Apr 21, 2026, 9:44:17 AM (2 days ago) Apr 21
to Palak Agarwal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Palak Agarwal

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
Gerrit-Change-Number: 7779874
Gerrit-PatchSet: 2
Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 13:44:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Palak Agarwal (Gerrit)

unread,
9:46 AM (9 hours ago) 9:46 AM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Guido Urdaneta

Palak Agarwal voted and added 1 comment

Votes added by Palak Agarwal

Code-Review+1

1 comment

File chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
Line 618, Patchset 5 (Latest):void WebRtcRemoteEventLogManager::RenderProcessHostExitedDestroyed(
Palak Agarwal . unresolved

Do we need this function? We can just call StopLogging directly from WebRtcEventLogManager::RenderProcessExitedInternal.

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
    Gerrit-Change-Number: 7779874
    Gerrit-PatchSet: 5
    Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 13:46:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guido Urdaneta (Gerrit)

    unread,
    10:02 AM (8 hours ago) 10:02 AM
    to Palak Agarwal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org

    Guido Urdaneta added 1 comment

    File chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
    Line 618, Patchset 5 (Latest):void WebRtcRemoteEventLogManager::RenderProcessHostExitedDestroyed(
    Palak Agarwal . resolved

    Do we need this function? We can just call StopLogging directly from WebRtcEventLogManager::RenderProcessExitedInternal.

    Guido Urdaneta

    Keeping it since existing code is calling it in a couple of places.
    We can consider a removal in the future when we start also removing deprecated functionality.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
      Gerrit-Change-Number: 7779874
      Gerrit-PatchSet: 5
      Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 14:02:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Palak Agarwal <agp...@chromium.org>
      satisfied_requirement
      open
      diffy

      Guido Urdaneta (Gerrit)

      unread,
      10:02 AM (8 hours ago) 10:02 AM
      to Palak Agarwal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org

      Guido Urdaneta voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
      Gerrit-Change-Number: 7779874
      Gerrit-PatchSet: 5
      Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 14:02:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Guido Urdaneta (Gerrit)

      unread,
      11:19 AM (7 hours ago) 11:19 AM
      to Palak Agarwal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
      Gerrit-Comment-Date: Thu, 23 Apr 2026 15:18:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      12:31 PM (6 hours ago) 12:31 PM
      to Guido Urdaneta, Palak Agarwal, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [RTCLogging] Add support for for stopping logs in WebRtcRemoteEventLogManager

      Add support for Finish and Cancel operations that store/upload and
      delete current log files correspondingly.
      Bug: 481412281
      Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
      Reviewed-by: Palak Agarwal <agp...@chromium.org>
      Commit-Queue: Guido Urdaneta <gui...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1619575}
      Files:
      • M chrome/browser/media/webrtc/webrtc_event_log_manager.cc
      • M chrome/browser/media/webrtc/webrtc_event_log_manager.h
      • M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
      • M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
      • M chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
      Change size: M
      Delta: 5 files changed, 119 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Palak Agarwal
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifc5ecc75f080f2e42382c83dcc3b2bcf38332679
      Gerrit-Change-Number: 7779874
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
      Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages