[iOS] Disable feedback in Chrome based on capability [chromium/src : main]

0 views
Skip to first unread message

Jérôme Lebel (Gerrit)

unread,
May 11, 2026, 9:27:26 AM (7 days ago) May 11
to Menghan Yang, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Menghan Yang

Jérôme Lebel voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Menghan Yang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
Gerrit-Change-Number: 7830731
Gerrit-PatchSet: 8
Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
Gerrit-Reviewer: Menghan Yang <my...@google.com>
Gerrit-Attention: Menghan Yang <my...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 13:27:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Menghan Yang (Gerrit)

unread,
May 12, 2026, 12:05:57 PM (6 days ago) May 12
to Jérôme Lebel, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Jérôme Lebel

Menghan Yang voted and added 1 comment

Votes added by Menghan Yang

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Menghan Yang . resolved

Lgtm, sorry for the delay!

Open in Gerrit

Related details

Attention is currently required from:
  • Jérôme Lebel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
    Gerrit-Change-Number: 7830731
    Gerrit-PatchSet: 12
    Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Reviewer: Menghan Yang <my...@google.com>
    Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 16:05:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    James Lee (Gerrit)

    unread,
    May 13, 2026, 4:40:37 AM (5 days ago) May 13
    to Jérôme Lebel, Mark Cogan, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Jérôme Lebel and Mark Cogan

    James Lee voted and added 2 comments

    Votes added by James Lee

    Code-Review+1

    2 comments

    Commit Message
    Line 9, Patchset 12 (Latest):Removes the feedback button from popo up menu, if CanSubmitFeedback
    James Lee . unresolved

    nit: typo

    File ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator_unittest.mm
    Line 559, Patchset 12 (Latest):// Tests that the Report an Issue item is hidden when the capability is false.
    James Lee . unresolved

    Can you please also add a test that the feedback item is shown for signed out users?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jérôme Lebel
    • Mark Cogan
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
      Gerrit-Change-Number: 7830731
      Gerrit-PatchSet: 12
      Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
      Gerrit-Reviewer: James Lee <ljj...@google.com>
      Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
      Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
      Gerrit-Reviewer: Menghan Yang <my...@google.com>
      Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
      Gerrit-Attention: Mark Cogan <ma...@chromium.org>
      Gerrit-Comment-Date: Wed, 13 May 2026 08:40:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jérôme Lebel (Gerrit)

      unread,
      2:19 AM (7 hours ago) 2:19 AM
      to James Lee, Mark Cogan, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Mark Cogan

      Jérôme Lebel voted and added 2 comments

      Votes added by Jérôme Lebel

      Auto-Submit+1
      Commit-Queue+1

      2 comments

      Commit Message
      Line 9, Patchset 12:Removes the feedback button from popo up menu, if CanSubmitFeedback
      James Lee . resolved

      nit: typo

      Jérôme Lebel

      Done

      File ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator_unittest.mm
      Line 559, Patchset 12:// Tests that the Report an Issue item is hidden when the capability is false.
      James Lee . resolved

      Can you please also add a test that the feedback item is shown for signed out users?

      Jérôme Lebel

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mark Cogan
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Gerrit-Change-Number: 7830731
        Gerrit-PatchSet: 16
        Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: James Lee <ljj...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
        Gerrit-Reviewer: Menghan Yang <my...@google.com>
        Gerrit-Attention: Mark Cogan <ma...@chromium.org>
        Gerrit-Comment-Date: Mon, 18 May 2026 06:19:37 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: James Lee <ljj...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Jérôme Lebel (Gerrit)

        unread,
        4:17 AM (5 hours ago) 4:17 AM
        to Mark Cogan, James Lee, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
        Attention needed from Mark Cogan

        Jérôme Lebel voted Auto-Submit+0

        Auto-Submit+0
        Gerrit-Comment-Date: Mon, 18 May 2026 08:17:37 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Mark Cogan (Gerrit)

        unread,
        4:18 AM (5 hours ago) 4:18 AM
        to Jérôme Lebel, James Lee, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
        Attention needed from Jérôme Lebel

        Mark Cogan voted and added 1 comment

        Votes added by Mark Cogan

        Code-Review+1
        Commit-Queue+2

        1 comment

        Patchset-level comments
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Jérôme Lebel
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Gerrit-Change-Number: 7830731
        Gerrit-PatchSet: 16
        Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: James Lee <ljj...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
        Gerrit-Reviewer: Menghan Yang <my...@google.com>
        Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Comment-Date: Mon, 18 May 2026 08:18:07 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Jérôme Lebel (Gerrit)

        unread,
        5:29 AM (4 hours ago) 5:29 AM
        to Mark Cogan, James Lee, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Jérôme Lebel voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Gerrit-Change-Number: 7830731
        Gerrit-PatchSet: 16
        Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: James Lee <ljj...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
        Gerrit-Reviewer: Menghan Yang <my...@google.com>
        Gerrit-Comment-Date: Mon, 18 May 2026 09:29:13 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Jérôme Lebel (Gerrit)

        unread,
        5:33 AM (4 hours ago) 5:33 AM
        to Mark Cogan, James Lee, Menghan Yang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Jérôme Lebel voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Gerrit-Change-Number: 7830731
        Gerrit-PatchSet: 17
        Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: James Lee <ljj...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
        Gerrit-Reviewer: Menghan Yang <my...@google.com>
        Gerrit-Comment-Date: Mon, 18 May 2026 09:32:48 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        5:37 AM (4 hours ago) 5:37 AM
        to Jérôme Lebel, Mark Cogan, James Lee, Menghan Yang, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        16 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        [iOS] Disable feedback in Chrome based on capability

        Removes the feedback button from pop up menu, if CanSubmitFeedback
        capability is false.
        This solution is temporary until Chrome can migrate to Aloha feedback.
        Aloha feedback takes care of the value of CanSubmitFeedback
        capability.
        Bug: 512043635
        Fixed: 511976440
        Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Reviewed-by: Menghan Yang <my...@google.com>
        Reviewed-by: James Lee <ljj...@google.com>
        Commit-Queue: Jérôme Lebel <jle...@chromium.org>
        Reviewed-by: Mark Cogan <ma...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1632034}
        Files:
        • M components/signin/internal/identity_manager/account_capabilities_list.h
        • M components/signin/public/identity_manager/account_capabilities.cc
        • M components/signin/public/identity_manager/account_capabilities.h
        • M components/signin/public/identity_manager/account_capabilities_test_mutator.cc
        • M components/signin/public/identity_manager/account_capabilities_test_mutator.h
        • M components/signin/public/identity_manager/account_capabilities_unittest.cc
        • M ios/chrome/browser/popup_menu/DEPS
        • M ios/chrome/browser/popup_menu/coordinator/BUILD.gn
        • M ios/chrome/browser/popup_menu/coordinator/popup_menu_coordinator.mm
        • M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator.h
        • M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator.mm
        • M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator_unittest.mm
        • M ios/chrome/test/providers/user_feedback/test_user_feedback.mm
        Change size: M
        Delta: 13 files changed, 170 insertions(+), 16 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Mark Cogan, +1 by Menghan Yang, +1 by James Lee
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic505a92b47c6cd606894eeec7708386f6e76ba40
        Gerrit-Change-Number: 7830731
        Gerrit-PatchSet: 18
        Gerrit-Owner: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: James Lee <ljj...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
        Gerrit-Reviewer: Menghan Yang <my...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages