Remove unused GlobalMediaControls flags [chromium/src : main]

0 views
Skip to first unread message

Yiren Wang (Gerrit)

unread,
Mar 4, 2026, 8:51:06 PM (17 hours ago) Mar 4
to Osama Fathy, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, rrsilva+wat...@google.com, steimel+...@chromium.org, tbarzi...@chromium.org
Attention needed from Osama Fathy

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Osama Fathy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I389e5ded23d6eae7150d12f23c980aedec2da258
Gerrit-Change-Number: 7635845
Gerrit-PatchSet: 2
Gerrit-Owner: Yiren Wang <y...@chromium.org>
Gerrit-Reviewer: Osama Fathy <osama...@google.com>
Gerrit-Reviewer: Yiren Wang <y...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Osama Fathy <osama...@google.com>
Gerrit-Comment-Date: Thu, 05 Mar 2026 01:50:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Osama Fathy (Gerrit)

unread,
5:06 AM (9 hours ago) 5:06 AM
to Yiren Wang, Tommy Steimel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, rrsilva+wat...@google.com, steimel+...@chromium.org, tbarzi...@chromium.org
Attention needed from Tommy Steimel and Yiren Wang

Osama Fathy voted and added 1 comment

Votes added by Osama Fathy

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Osama Fathy . resolved

ash/login lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Tommy Steimel
  • Yiren Wang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I389e5ded23d6eae7150d12f23c980aedec2da258
Gerrit-Change-Number: 7635845
Gerrit-PatchSet: 2
Gerrit-Owner: Yiren Wang <y...@chromium.org>
Gerrit-Reviewer: Osama Fathy <osama...@google.com>
Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
Gerrit-Reviewer: Yiren Wang <y...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Tommy Steimel <ste...@chromium.org>
Gerrit-Attention: Yiren Wang <y...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Mar 2026 10:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tommy Steimel (Gerrit)

unread,
12:32 PM (2 hours ago) 12:32 PM
to Yiren Wang, Osama Fathy, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, rrsilva+wat...@google.com, steimel+...@chromium.org, tbarzi...@chromium.org
Attention needed from Yiren Wang

Tommy Steimel added 1 comment

File tools/metrics/histograms/enums.xml
File-level comment, Patchset 2 (Parent):
Tommy Steimel . unresolved

There's a comment for this enum saying:

```
Don't remove entries when removing a flag; they are still used to decode data
from previous Chrome versions
```

https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;l=8067;drc=073458c8bff169183fce9daac994e695948735a4

Open in Gerrit

Related details

Attention is currently required from:
  • Yiren Wang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I389e5ded23d6eae7150d12f23c980aedec2da258
    Gerrit-Change-Number: 7635845
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yiren Wang <y...@chromium.org>
    Gerrit-Reviewer: Osama Fathy <osama...@google.com>
    Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
    Gerrit-Reviewer: Yiren Wang <y...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Yiren Wang <y...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 17:31:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages