ash: Add chrome/browser/ash/file_manager/BUILD.gn. [chromium/src : main]

0 views
Skip to first unread message

Yuta Hijikata (Gerrit)

unread,
Jul 2, 2024, 11:59:18 PM (2 days ago) Jul 2
to Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kyle Horimoto

Yuta Hijikata added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Yuta Hijikata . resolved

Please take a look!

Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 3
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 03:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyle Horimoto (Gerrit)

unread,
Jul 3, 2024, 7:07:25 PM (2 days ago) Jul 3
to Yuta Hijikata, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Yuta Hijikata

Kyle Horimoto voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuta Hijikata
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 5
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Yuta Hijikata <yth...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 23:07:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jul 4, 2024, 1:10:28 AM (yesterday) Jul 4
to Yuta Hijikata, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kyle Horimoto and Yuta Hijikata

Hidehiko Abe added 5 comments

File chrome/browser/ash/file_manager/BUILD.gn
Line 103, Patchset 7 (Latest): public_deps = [
Hidehiko Abe . unresolved

can these be just deps?

Line 202, Patchset 7 (Latest): public_deps = [
Hidehiko Abe . unresolved

ditto

Line 256, Patchset 7 (Latest): public_deps = [
Hidehiko Abe . unresolved

ditto

Line 365, Patchset 7 (Latest): public_deps = [
Hidehiko Abe . unresolved

ditto

File chrome/browser/ash/file_manager/virtual_tasks/BUILD.gn
Line 41, Patchset 7 (Latest): public_deps = [
Hidehiko Abe . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
  • Yuta Hijikata
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 7
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Attention: Yuta Hijikata <yth...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 05:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuta Hijikata (Gerrit)

unread,
Jul 4, 2024, 1:15:22 AM (yesterday) Jul 4
to Kyle Horimoto, Hidehiko Abe, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hidehiko Abe and Kyle Horimoto

Yuta Hijikata added 1 comment

File chrome/browser/ash/file_manager/BUILD.gn
Hidehiko Abe . unresolved

can these be just deps?

Yuta Hijikata

Per https://chat.google.com/room/AAAAEwXCkuM/sbVLIrIIX7w/XYZBsIRjz_A?cls=10, I thought things included from *.h files should be put in `public_deps`?

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 7
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 05:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jul 4, 2024, 3:34:10 AM (yesterday) Jul 4
to Yuta Hijikata, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kyle Horimoto and Yuta Hijikata

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Hidehiko Abe . resolved

thank you for offline chat.
I'm ok to move forward, but I still think we have to clean up public_deps.
In some sense it makes some unwanted dependencies human-invisible.

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
  • Yuta Hijikata
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 7
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Attention: Yuta Hijikata <yth...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 07:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuta Hijikata (Gerrit)

unread,
Jul 4, 2024, 5:14:38 AM (23 hours ago) Jul 4
to Hidehiko Abe, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hidehiko Abe and Kyle Horimoto

Yuta Hijikata voted and added 5 comments

Votes added by Yuta Hijikata

Commit-Queue+1

5 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Yuta Hijikata . resolved

Resolved merge conflict. Please have another look, thanks!

File chrome/browser/ash/file_manager/BUILD.gn
Line 202, Patchset 7: public_deps = [
Hidehiko Abe . resolved

ditto

Yuta Hijikata

Acknowledged

Line 256, Patchset 7: public_deps = [
Hidehiko Abe . resolved

ditto

Yuta Hijikata

Acknowledged

Line 365, Patchset 7: public_deps = [
Hidehiko Abe . resolved

ditto

Yuta Hijikata

Acknowledged

File chrome/browser/ash/file_manager/virtual_tasks/BUILD.gn
Line 41, Patchset 7: public_deps = [
Hidehiko Abe . resolved

ditto

Yuta Hijikata

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 8
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 09:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuta Hijikata (Gerrit)

unread,
Jul 4, 2024, 5:15:00 AM (23 hours ago) Jul 4
to Hidehiko Abe, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hidehiko Abe and Kyle Horimoto

Yuta Hijikata added 1 comment

File chrome/browser/ash/file_manager/BUILD.gn
Line 103, Patchset 7: public_deps = [
Hidehiko Abe . resolved

can these be just deps?

Yuta Hijikata

Per https://chat.google.com/room/AAAAEwXCkuM/sbVLIrIIX7w/XYZBsIRjz_A?cls=10, I thought things included from *.h files should be put in `public_deps`?

Yuta Hijikata

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 8
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 09:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
Comment-In-Reply-To: Yuta Hijikata <yth...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jul 4, 2024, 11:35:16 AM (17 hours ago) Jul 4
to Yuta Hijikata, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kyle Horimoto and Yuta Hijikata

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

File chrome/browser/apps/app_service/BUILD.gn
Line 273, Patchset 8 (Latest): allow_circular_includes_from += [
"//chrome/browser/ash/app_restore",
"//chrome/browser/ash/apps",
"//chrome/browser/ash/arc",
"//chrome/browser/ash/arc/app_shortcuts",
"//chrome/browser/ash/arc/intent_helper",
"//chrome/browser/ash/arc/nearby_share",
"//chrome/browser/ash/arc/privacy_items",
"//chrome/browser/ash/arc/session",
"//chrome/browser/ash/arc/tracing",
"//chrome/browser/ash/child_accounts",
"//chrome/browser/ash/child_accounts/on_device_controls",
"//chrome/browser/ash/child_accounts/time_limits",
"//chrome/browser/ash/crosapi",
"//chrome/browser/ash/guest_os",
"//chrome/browser/ash/remote_apps",
"//chrome/browser/ash/system_logs",
"//chrome/browser/ash/system_web_apps/apps",
"//chrome/browser/ash/system_web_apps/apps/camera_app",
"//chrome/browser/ash/system_web_apps/apps/media_app",
"//chrome/browser/ash/app_mode/web_app",
"//chrome/browser/ash/file_manager",
Hidehiko Abe . unresolved

could you keep sorting?

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
  • Yuta Hijikata
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 8
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Attention: Yuta Hijikata <yth...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 15:35:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuta Hijikata (Gerrit)

unread,
Jul 4, 2024, 9:41:08 PM (7 hours ago) Jul 4
to Hidehiko Abe, Kyle Horimoto, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kyle Horimoto

Yuta Hijikata voted and added 1 comment

Votes added by Yuta Hijikata

Commit-Queue+2

1 comment

File chrome/browser/apps/app_service/BUILD.gn
Line 273, Patchset 8: allow_circular_includes_from += [

"//chrome/browser/ash/app_restore",
"//chrome/browser/ash/apps",
"//chrome/browser/ash/arc",
"//chrome/browser/ash/arc/app_shortcuts",
"//chrome/browser/ash/arc/intent_helper",
"//chrome/browser/ash/arc/nearby_share",
"//chrome/browser/ash/arc/privacy_items",
"//chrome/browser/ash/arc/session",
"//chrome/browser/ash/arc/tracing",
"//chrome/browser/ash/child_accounts",
"//chrome/browser/ash/child_accounts/on_device_controls",
"//chrome/browser/ash/child_accounts/time_limits",
"//chrome/browser/ash/crosapi",
"//chrome/browser/ash/guest_os",
"//chrome/browser/ash/remote_apps",
"//chrome/browser/ash/system_logs",
"//chrome/browser/ash/system_web_apps/apps",
"//chrome/browser/ash/system_web_apps/apps/camera_app",
"//chrome/browser/ash/system_web_apps/apps/media_app",
"//chrome/browser/ash/app_mode/web_app",
"//chrome/browser/ash/file_manager",
Hidehiko Abe . resolved

could you keep sorting?

Yuta Hijikata

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 9
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
Gerrit-CC: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 01:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 4, 2024, 10:39:02 PM (6 hours ago) Jul 4
to Yuta Hijikata, Hidehiko Abe, Kyle Horimoto, AyeAye, chromium...@chromium.org, Nancy Wang, shuche...@chromium.org, cros-enterpris...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, yhanad...@chromium.org, mtomas...@chromium.org, nona+...@chromium.org, arc-review...@google.com, andysjl...@chromium.org, jackshira+wat...@google.com, djacob...@chromium.org, alandin...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, vakh+safe_br...@chromium.org, yhanada+...@chromium.org, nwoked...@chromium.org, phshah...@chromium.org, druber...@chromium.org, kinuko+...@chromium.org, crost...@chromium.org, hidehik...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, chromeos-ca...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, mxcai+watch...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tsergea...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/apps/app_service/BUILD.gn
Insertions: 2, Deletions: 2.

@@ -272,6 +272,7 @@
     # TODO(crbug.com/40251079): Remove circular dependencies.
     allow_circular_includes_from += [
       "//chrome/browser/ash/app_restore",
+      "//chrome/browser/ash/app_mode/web_app",

       "//chrome/browser/ash/apps",
       "//chrome/browser/ash/arc",
       "//chrome/browser/ash/arc/app_shortcuts",
@@ -284,14 +285,13 @@

       "//chrome/browser/ash/child_accounts/on_device_controls",
       "//chrome/browser/ash/child_accounts/time_limits",
       "//chrome/browser/ash/crosapi",
+      "//chrome/browser/ash/file_manager",

       "//chrome/browser/ash/guest_os",
       "//chrome/browser/ash/remote_apps",
       "//chrome/browser/ash/system_logs",
       "//chrome/browser/ash/system_web_apps/apps",
       "//chrome/browser/ash/system_web_apps/apps/camera_app",
       "//chrome/browser/ash/system_web_apps/apps/media_app",
-      "//chrome/browser/ash/app_mode/web_app",
-      "//chrome/browser/ash/file_manager",
     ]
   }
 
```

Change information

Commit message:
ash: Add chrome/browser/ash/file_manager/BUILD.gn.
Bug: 335292921
Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Commit-Queue: Yuta Hijikata <yth...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323520}
Files:
  • M chrome/browser/BUILD.gn
  • M chrome/browser/apps/app_service/BUILD.gn
  • M chrome/browser/ash/BUILD.gn
  • M chrome/browser/ash/app_list/BUILD.gn
  • M chrome/browser/ash/app_list/search/local_image_search/BUILD.gn
  • M chrome/browser/ash/arc/BUILD.gn
  • M chrome/browser/ash/arc/file_system_watcher/BUILD.gn
  • M chrome/browser/ash/arc/fileapi/BUILD.gn
  • M chrome/browser/ash/arc/nearby_share/BUILD.gn
  • M chrome/browser/ash/arc/session/BUILD.gn
  • M chrome/browser/ash/crosapi/BUILD.gn
  • M chrome/browser/ash/drive/BUILD.gn
  • M chrome/browser/ash/exo/BUILD.gn
  • A chrome/browser/ash/file_manager/BUILD.gn
  • A chrome/browser/ash/file_manager/virtual_tasks/BUILD.gn
  • M chrome/browser/ash/file_suggest/BUILD.gn
  • M chrome/browser/ash/fusebox/BUILD.gn
  • M chrome/browser/ash/guest_os/BUILD.gn
  • M chrome/browser/ash/input_method/BUILD.gn
  • M chrome/browser/ash/plugin_vm/BUILD.gn
  • M chrome/browser/ash/sharesheet/BUILD.gn
  • M chrome/browser/ash/system_web_apps/BUILD.gn
  • M chrome/browser/ash/system_web_apps/apps/BUILD.gn
  • M chrome/browser/ash/system_web_apps/apps/camera_app/BUILD.gn
  • M chrome/browser/ash/system_web_apps/apps/media_app/BUILD.gn
  • M chrome/browser/ash/wallpaper/BUILD.gn
  • M chrome/browser/chromeos/BUILD.gn
  • M chrome/browser/extensions/BUILD.gn
  • M chrome/browser/safe_browsing/BUILD.gn
  • M chrome/browser/ui/BUILD.gn
  • M chrome/browser/ui/ash/holding_space/BUILD.gn
  • M chrome/browser/ui/ash/system_web_apps/BUILD.gn
  • M chrome/browser/ui/web_applications/BUILD.gn
  • M chrome/browser/web_applications/app_service/BUILD.gn
  • M chrome/browser/webshare/chromeos/BUILD.gn
  • M chrome/test/BUILD.gn
Change size: L
Delta: 36 files changed, 665 insertions(+), 151 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hidehiko Abe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a34b03166758a9a57ef7d0bb728acb5dfeefb04
Gerrit-Change-Number: 5672081
Gerrit-PatchSet: 10
Gerrit-Owner: Yuta Hijikata <yth...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yuta Hijikata <yth...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages