Enable WebRtcDesktopCaptureBrowserTest [chromium/src : main]
0 views
Skip to first unread message
Guido Urdaneta (Gerrit)
Jul 3, 2024, 2:15:59 PM (2 days ago) Jul 3
to Tony Herre, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blundell+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, phoglun...@chromium.org
Attention needed from Tony Herre
Guido Urdaneta added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Tony Herre
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tony Herre (Gerrit)
Jul 4, 2024, 4:13:47 AM (yesterday) Jul 4
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blundell+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, phoglun...@chromium.org
Attention needed from Guido Urdaneta
Tony Herre voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
Jul 4, 2024, 10:46:51 AM (18 hours ago) Jul 4
to Tony Herre, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blundell+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, phoglun...@chromium.org
Guido Urdaneta voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 4, 2024, 12:22:17 PM (16 hours ago) Jul 4
to Guido Urdaneta, Tony Herre, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blundell+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, phoglun...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
Insertions: 4, Deletions: 3.
@@ -401,8 +401,9 @@
ASSERT_LE(frame_counter, 3);
}
-// TODO(crbug.com/40270173) flaky on ASan bots
-#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER)
+// Flaky on ASan bots. See https://crbug.com/40270173.
+// Crashes on some Macs. See https://crbug.com/351095634.
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || BUILDFLAG(IS_MAC)
#define MAYBE_RunP2PScreenshareWhileSharingScreen \
DISABLED_RunP2PScreenshareWhileSharingScreen
#else
@@ -414,7 +415,7 @@
RunP2PScreenshareWhileSharing(base::BindOnce(GetDesktopMediaIDForScreen));
}
-// TODO(crbug.com/40270173) flaky on ASan bots
+// Flaky on ASan bots. See https://crbug.com/40270173.
#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER)
#define MAYBE_RunP2PScreenshareWhileSharingTab \
DISABLED_RunP2PScreenshareWhileSharingTab
```
Change information
Commit message:
Enable WebRtcDesktopCaptureBrowserTest
This CL enables
WebRtcDesktopCaptureBrowserTest.RunP2PScreenshareWhileSharingScreen on
most bots (Mac, ASAN and LSAN excluded).
The test was crashing reliably on all platforms due to an incorrect way
to specify the screen ID.
Bug: 236354911
Change-Id: If03c212d8a815192f688bc3143109ed735808203
Reviewed-by: Tony Herre <top...@chromium.org>
Commit-Queue: Guido Urdaneta <gui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323391}
Files:
- M chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tony Herre
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages