Mitsuru Oshima (Gerrit)

unread,

Sep 18, 2025, 11:31:30 PM (5 days ago) Sep 18

to Di Wu, Tom Lukaszewicz, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Di Wu, Junichi Uekawa, Tom Lukaszewicz and Xiaoqian Dai

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Junichi Uekawa
Tom Lukaszewicz
Xiaoqian Dai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Sep 19, 2025, 12:01:33 AM (5 days ago) Sep 19

to James Cook, Adem Derinel, Di Wu, Tom Lukaszewicz, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Adem Derinel, Di Wu, James Cook, Junichi Uekawa, Tom Lukaszewicz and Xiaoqian Dai

Mitsuru Oshima added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mitsuru Oshima . resolved

jamescook@ -> c/b/extensions no need to review other dirs
xdai@ -> components/app_restore/full_restore_read_and_save_unittest.cc no need to review other dirs

Open in Gerrit

Related details

Attention is currently required from:

Adem Derinel
Di Wu
James Cook

Junichi Uekawa
Tom Lukaszewicz
Xiaoqian Dai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

James Cook (Gerrit)

unread,

Sep 19, 2025, 1:18:28 AM (5 days ago) Sep 19

to Mitsuru Oshima, Adem Derinel, Di Wu, Tom Lukaszewicz, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Adem Derinel, Di Wu, Junichi Uekawa, Mitsuru Oshima, Tom Lukaszewicz and Xiaoqian Dai

James Cook voted and added 1 comment

Votes added by James Cook

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

James Cook . resolved

LGTM for chrome/browser/extensions

Open in Gerrit

Related details

Attention is currently required from:

Adem Derinel
Di Wu
Junichi Uekawa
Mitsuru Oshima
Tom Lukaszewicz
Xiaoqian Dai

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Lukaszewicz (Gerrit)

unread,

Sep 19, 2025, 1:35:55 AM (5 days ago) Sep 19

to Mitsuru Oshima, James Cook, Adem Derinel, Di Wu, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Adem Derinel, Di Wu, Junichi Uekawa, Mitsuru Oshima and Xiaoqian Dai

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Tom Lukaszewicz . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Adem Derinel
Di Wu
Junichi Uekawa
Mitsuru Oshima

Xiaoqian Dai

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Sep 19, 2025, 2:44:03 AM (5 days ago) Sep 19

to Mitsuru Oshima, Jun Ishiguro, Tom Lukaszewicz, James Cook, Adem Derinel, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Adem Derinel, Jun Ishiguro, Junichi Uekawa, Mitsuru Oshima and Xiaoqian Dai

Di Wu voted and added 1 comment

Votes added by Di Wu

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Di Wu . unresolved

Nice refactoring. Highly recommend a gemini-cli extension developed by our own @ju...@google.com for finding out the exact definition/declaration/call sites of a function. In our case here, the function is `aura::test::CreateTestWindow()`.

Per this extension, gemini-cli reported the following files to be further refactored to complete your preparation effort. For your reference, the remaining files are:

```
   - ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
   - ash/wm/window_dimmer_unittest.cc
   - ash/wm/window_manager_unittest.cc
   - ash/wm/window_modality_controller_unittest.cc
   - ash/wm/workspace_controller_unittest.cc
   - chrome/browser/apps/app_service/metrics/app_platform_metrics_service_unittest.cc
   - chrome/browser/ash/arc/instance_throttle/arc_active_window_throttle_observer_unittest.cc
   - chrome/browser/ash/arc/instance_throttle/arc_pip_window_throttle_observer_unittest.cc
   - chrome/browser/ash/crostini/throttle/crostini_active_window_throttle_observer_unittest.cc
   - chrome/browser/ash/exo/chrome_data_exchange_delegate_unittest.cc
   - chrome/browser/ash/exo/chrome_security_delegate_unittest.cc
   - chrome/browser/performance_manager/policies/working_set_trimmer_policy_arcvm_unittest.cc
   - chrome/browser/ui/views/tabs/dragging/tab_drag_controller_interactive_uitest.cc
   - chromeos/ash/experiences/arc/ime/arc_ime_service_unittest.cc
   - content/browser/web_contents/web_contents_view_aura_unittest.cc
   - ui/aura/gestures/gesture_recognizer_unittest.cc
   - ui/aura/test/aura_test_base.cc
   - ui/aura/window_event_dispatcher_unittest.cc
   - ui/aura/window_occlusion_tracker_unittest.cc
   - ui/aura/window_unittest.cc
   - ui/snapshot/snapshot_aura_unittest.cc
   - ui/wm/core/compound_event_filter_unittest.cc
   - ui/wm/core/focus_controller_unittest.cc
   - ui/wm/core/ime_util_chromeos_unittest.cc
   - ui/wm/core/shadow_controller_unittest.cc
   - ui/wm/core/transient_window_manager_unittest.cc
   - ui/wm/core/transient_window_stacking_client_unittest.cc
```

Open in Gerrit

Related details

Attention is currently required from:

Adem Derinel
Jun Ishiguro

Junichi Uekawa
Mitsuru Oshima
Xiaoqian Dai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Sep 19, 2025, 2:47:10 AM (5 days ago) Sep 19

to Mitsuru Oshima, Jun Ishiguro, Tom Lukaszewicz, James Cook, Adem Derinel, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Adem Derinel, Jun Ishiguro, Junichi Uekawa, Mitsuru Oshima and Xiaoqian Dai

Di Wu added 1 comment

Patchset-level comments

Di Wu

Extension: https://source.corp.google.com/piper///depot/google3/experimental/users/junis/chromium_xrefs/;bpv=0

satisfied_requirement

unsatisfied_requirement

open

diffy

Adem Derinel (Gerrit)

unread,

Sep 19, 2025, 4:02:52 AM (5 days ago) Sep 19

to Mitsuru Oshima, Di Wu, Jun Ishiguro, Tom Lukaszewicz, James Cook, Junichi Uekawa, Xiaoqian Dai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Jun Ishiguro, Junichi Uekawa, Mitsuru Oshima and Xiaoqian Dai

Adem Derinel voted and added 1 comment

Votes added by Adem Derinel

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Adem Derinel . resolved

**/webauthn/** lgtm

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaoqian Dai (Gerrit)

unread,

Sep 19, 2025, 12:40:24 PM (5 days ago) Sep 19

to Mitsuru Oshima, Xiaoqian Dai, Adem Derinel, Di Wu, Jun Ishiguro, Tom Lukaszewicz, James Cook, Junichi Uekawa, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Jun Ishiguro, Junichi Uekawa and Mitsuru Oshima

Xiaoqian Dai voted and added 1 comment

Votes added by Xiaoqian Dai

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Xiaoqian Dai . resolved

components/app_restore/full_restore_read_and_save_unittest.cc LGTM

Open in Gerrit

Related details

Attention is currently required from:

Jun Ishiguro
Junichi Uekawa
Mitsuru Oshima

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Sep 19, 2025, 2:50:57 PM (4 days ago) Sep 19

to Xiaoqian Dai, Adem Derinel, Di Wu, Jun Ishiguro, Tom Lukaszewicz, James Cook, Junichi Uekawa, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Di Wu, Jun Ishiguro and Junichi Uekawa

Mitsuru Oshima added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mitsuru Oshima

Thanks, the list in this CL is indeed incomplete, due to the issue with gemini and I had to stop in the middle. The most of files above already have .bounds, so I think I can just finish the rest using standard code search that Gemini uses. (which also search xref)

That's being said, the existing one has several issues, such as it, *) couldn't handle overloading well, *) it sometimes generate bad regexp, *) generates wrong edit command. Do you think it can address these issues?

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Jun Ishiguro
Junichi Uekawa

satisfied_requirement

unsatisfied_requirement

open

diffy

Junichi Uekawa (Gerrit)

unread,

Sep 22, 2025, 12:51:25 AM (2 days ago) Sep 22

to Mitsuru Oshima, Xiaoqian Dai, Adem Derinel, Di Wu, Jun Ishiguro, Tom Lukaszewicz, James Cook, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Di Wu, Jun Ishiguro and Mitsuru Oshima

Junichi Uekawa voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Jun Ishiguro
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Sep 22, 2025, 1:26:31 AM (2 days ago) Sep 22

to Mitsuru Oshima, Junichi Uekawa, Xiaoqian Dai, Adem Derinel, Jun Ishiguro, Tom Lukaszewicz, James Cook, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Jun Ishiguro and Mitsuru Oshima

Di Wu voted and added 1 comment

Votes added by Di Wu

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Di Wu . resolved

Di Wu

I'll defer this question to @ju...@google.com. Closing this thread for now.

Open in Gerrit

Related details

Attention is currently required from:

Jun Ishiguro
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Sep 22, 2025, 1:33:33 AM (2 days ago) Sep 22

to Di Wu, Junichi Uekawa, Xiaoqian Dai, Adem Derinel, Jun Ishiguro, Tom Lukaszewicz, James Cook, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Jun Ishiguro

Mitsuru Oshima voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Jun Ishiguro

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 22, 2025, 1:57:22 AM (2 days ago) Sep 22

to Mitsuru Oshima, Di Wu, Junichi Uekawa, Xiaoqian Dai, Adem Derinel, Jun Ishiguro, Tom Lukaszewicz, James Cook, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, alandin...@chromium.org, arc-review...@google.com, chromium-a...@chromium.org, cros-report...@google.com, crost...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, jackshira+wat...@google.com, oshima...@chromium.org, phshah...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, toshikikikuchi+...@chromium.org, webauthn...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Specify bounds when creating WindowBuilderParams.

This {100, 100} is the current default avlue, and I'm planning to
change this to {}. This is a preparation to change the default
value of `bounds` to empty

(generated by gemini-cli)

Bug: None

Change-Id: I650c611efb1a7e056a4e3e9ebb4a00384f9d0acc

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6968054

Reviewed-by: Di Wu <di...@google.com>

Commit-Queue: Mitsuru Oshima <osh...@chromium.org>

Reviewed-by: Xiaoqian Dai <xd...@chromium.org>

Reviewed-by: Junichi Uekawa <uek...@chromium.org>

Reviewed-by: James Cook <jame...@chromium.org>

Commit-Queue: Di Wu <di...@google.com>

Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>

Reviewed-by: Adem Derinel <der...@google.com>

Cr-Commit-Position: refs/heads/main@{#1518525}

Files:

M ash/extended_desktop_unittest.cc
M ash/wm/gestures/wm_gesture_handler_unittest.cc
M ash/wm/layer_tree_synchronizer_unittest.cc
M ash/wm/lock_state_controller_unittest.cc
M ash/wm/screen_dimmer_unittest.cc
M ash/wm/splitview/split_view_controller_unittest.cc
M ash/wm/window_cycle/window_cycle_controller_unittest.cc
M chrome/browser/ash/arc/input_method_manager/arc_input_method_manager_service_unittest.cc
M chrome/browser/ash/arc/nearby_share/nearby_share_session_impl_unittest.cc
M chrome/browser/ash/mahi/media_app/mahi_media_app_client_unittest.cc
M chrome/browser/ash/policy/status_collector/device_status_collector_unittest.cc
M chrome/browser/extensions/extension_install_prompt_show_params_browsertest.cc
M chrome/browser/webauthn/unexportable_key_utils_chromeos_unittest.cc
M chromeos/ash/experiences/arc/arc_util_unittest.cc
M chromeos/ash/experiences/arc/metrics/arc_metrics_service_unittest.cc
M components/app_restore/full_restore_read_and_save_unittest.cc
M components/guest_os/guest_os_engagement_metrics_unittest.cc
M ui/aura_extra/window_position_in_root_monitor_unittest.cc
M ui/views/widget/window_reorderer_unittest.cc
M ui/wm/core/window_animations_unittest.cc
M ui/wm/core/window_util_unittest.cc

Change size: M

Delta: 21 files changed, 102 insertions(+), 85 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Di Wu, +1 by Adem Derinel, +1 by James Cook, +1 by Xiaoqian Dai, +1 by Tom Lukaszewicz, +1 by Junichi Uekawa

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Specify bounds when creating WindowBuilderParams. [chromium/src : main]

Mitsuru Oshima (Gerrit)

New activity on the change

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima added 1 comment

Related details

James Cook (Gerrit)

James Cook voted and added 1 comment

Votes added by James Cook

1 comment

Related details

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

1 comment

Related details

Di Wu (Gerrit)

Di Wu voted and added 1 comment

Votes added by Di Wu

1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Adem Derinel (Gerrit)

Adem Derinel voted and added 1 comment

Votes added by Adem Derinel

1 comment

Related details

Xiaoqian Dai (Gerrit)

Xiaoqian Dai voted and added 1 comment

Votes added by Xiaoqian Dai

1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima added 1 comment

Related details

Junichi Uekawa (Gerrit)

Junichi Uekawa voted Code-Review+1

Related details

Di Wu (Gerrit)

Di Wu voted and added 1 comment

Votes added by Di Wu

1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information