Refactor: Move capture_util_mac.* to desktop_capture_util_mac.* [chromium/src : main]

0 views
Skip to first unread message

Tove Petersson (Gerrit)

unread,
6:35 AM (3 hours ago) 6:35 AM
to Olga Sharonova, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Olga Sharonova

Tove Petersson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olga Sharonova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0628a89ecae5e6505c10beee6866bb876cf9c140
Gerrit-Change-Number: 7849383
Gerrit-PatchSet: 1
Gerrit-Owner: Tove Petersson <to...@chromium.org>
Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
Gerrit-Comment-Date: Mon, 18 May 2026 10:35:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Sharonova (Gerrit)

unread,
7:25 AM (2 hours ago) 7:25 AM
to Tove Petersson, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Tove Petersson

Olga Sharonova voted and added 1 comment

Votes added by Olga Sharonova

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Olga Sharonova . resolved

LGTM - thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Tove Petersson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0628a89ecae5e6505c10beee6866bb876cf9c140
    Gerrit-Change-Number: 7849383
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tove Petersson <to...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Tove Petersson <to...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 11:25:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tove Petersson (Gerrit)

    unread,
    7:29 AM (2 hours ago) 7:29 AM
    to Olga Sharonova, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

    Tove Petersson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0628a89ecae5e6505c10beee6866bb876cf9c140
    Gerrit-Change-Number: 7849383
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tove Petersson <to...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Mon, 18 May 2026 11:29:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:32 AM (2 hours ago) 7:32 AM
    to Tove Petersson, Olga Sharonova, chromium...@chromium.org, Rijubrata Bhaumik, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Refactor: Move capture_util_mac.* to desktop_capture_util_mac.*

    Move desktop-capture-related utilities from capture_util_mac.* to
    desktop_capture_util_mac.* and remove the original files. Also
    update references in pip_screen_capture_coordinator_impl.cc,
    in_process_video_capture_device_launcher.cc, and BUILD.gn.
    Change-Id: I0628a89ecae5e6505c10beee6866bb876cf9c140
    Commit-Queue: Tove Petersson <to...@chromium.org>
    Reviewed-by: Olga Sharonova <ol...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1632079}
    Files:
    • M content/browser/BUILD.gn
    • D content/browser/media/capture/capture_util_mac.h
    • D content/browser/media/capture/capture_util_mac.mm
    • M content/browser/media/capture/desktop_capture_util_mac.h
    • M content/browser/media/capture/desktop_capture_util_mac.mm
    • M content/browser/media/capture/pip_screen_capture_coordinator_impl.cc
    • M content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
    Change size: M
    Delta: 7 files changed, 62 insertions(+), 91 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Olga Sharonova
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0628a89ecae5e6505c10beee6866bb876cf9c140
    Gerrit-Change-Number: 7849383
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tove Petersson <to...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages