[//ui] Remove GpuMemoryBuffer(Handle)'s id field [chromium/src : main]
1 view
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jul 3, 2025, 9:36:01 AM7/3/25
to Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jul 4, 2025, 3:23:02 AM7/4/25
to Colin Blundell, Hirokazu Honda, Alexander Cooper, Antonio Sartori, Kentaro Hara, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Alexander Cooper, Antonio Sartori, Hirokazu Honda and Kentaro Hara
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Thanks!
+Hiro for //chromeos/ash
+Alex for //device
+Antonio for //gpu/ipc and //ui/gfx/mojom
+Kentaro for //third_party/blink
Related details
Attention is currently required from:
- Alexander Cooper
- Antonio Sartori
- Hirokazu Honda
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Jul 4, 2025, 3:30:02 AM7/4/25
to Colin Blundell, Hirokazu Honda, Alexander Cooper, Kentaro Hara, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Alexander Cooper, Colin Blundell, Hirokazu Honda and Kentaro Hara
Antonio Sartori voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexander Cooper
- Colin Blundell
- Hirokazu Honda
- Kentaro Hara
Kentaro Hara (Gerrit)
Jul 4, 2025, 3:34:48 AM7/4/25
to Colin Blundell, Antonio Sartori, Hirokazu Honda, Alexander Cooper, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Alexander Cooper, Colin Blundell and Hirokazu Honda
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Cooper
- Colin Blundell
- Hirokazu Honda
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hirokazu Honda (Gerrit)
Jul 7, 2025, 7:06:55 AM7/7/25
to Colin Blundell, Kentaro Hara, Antonio Sartori, Alexander Cooper, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Alexander Cooper and Colin Blundell
Hirokazu Honda voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Cooper
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Jul 7, 2025, 12:36:47 PM7/7/25
to Colin Blundell, Hirokazu Honda, Kentaro Hara, Antonio Sartori, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Attention needed from Colin Blundell
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2025, 2:53:49 AM7/8/25
to Colin Blundell, Alexander Cooper, Hirokazu Honda, Kentaro Hara, Antonio Sartori, Vasiliy Telezhnikov, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, feature-v...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//ui] Remove GpuMemoryBuffer(Handle)'s id field
This CL starts the process of eliminating GpuMemoryBufferId. To do so
we remove GpuMemoryBuffer::id_ and GpuMemoryBufferHandle::id, which are
interdependent (they are copied back and forth). To minimize the spread
of the CL, I currently leave in GpuMemoryBufferImpl and its subclasses
taking in an `id` param in the constructor, which is now just ignored.
Followup will remove GpuMemoryBufferId altogether.
Bug: 404905709
Change-Id: I361ba5aad9c3b8fb6dd4d4ab8e66f440447d27a4
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Hirokazu Honda <hi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1483578}
Files:
- M chrome/browser/vr/graphics_delegate_android.cc
- M chromeos/ash/experiences/arc/video_accelerator/gpu_arc_video_decode_accelerator.cc
- M chromeos/ash/experiences/arc/video_accelerator/gpu_arc_video_frame_pool.cc
- M components/viz/service/frame_sinks/video_capture/gpu_memory_buffer_video_frame_pool.cc
- M content/browser/media/capture/io_surface_capture_device_base_mac.cc
- M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
- M device/vr/android/xr_image_transport_base.cc
- M device/vr/openxr/android/openxr_graphics_binding_open_gles.cc
- M gpu/command_buffer/client/fake_gpu_memory_buffer.cc
- M gpu/command_buffer/client/test_shared_image_interface.cc
- M gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
- M gpu/command_buffer/service/shared_image/iosurface_image_backing_factory_unittest.cc
- M gpu/ipc/common/gpu_memory_buffer_impl.cc
- M gpu/ipc/common/gpu_memory_buffer_impl.h
- M gpu/ipc/common/gpu_memory_buffer_impl_dxgi.cc
- M gpu/ipc/common/gpu_memory_buffer_impl_io_surface.cc
- M gpu/ipc/common/gpu_memory_buffer_impl_native_pixmap.cc
- M gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.cc
- M gpu/ipc/service/gpu_memory_buffer_factory_dxgi.cc
- M gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc
- M gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
- M media/capture/video/apple/gpu_memory_buffer_tracker_apple.cc
- M media/capture/video/apple/video_capture_device_avfoundation.mm
- M media/capture/video/chromeos/gpu_memory_buffer_tracker_cros.cc
- M media/capture/video/win/gpu_memory_buffer_tracker_win.cc
- M media/gpu/chromeos/mailbox_video_frame_converter_unittest.cc
- M media/gpu/chromeos/native_pixmap_frame_resource.cc
- M media/gpu/mac/video_toolbox_frame_converter.cc
- M media/gpu/test/test_gbm_buffer_manager.cc
- M services/video_capture/ash/video_frame_handler_ash.cc
- M third_party/blink/renderer/platform/video_capture/video_capture_impl_test.cc
- M ui/gfx/gpu_memory_buffer_handle.cc
- M ui/gfx/gpu_memory_buffer_handle.h
- M ui/gfx/mojom/buffer_types.mojom
- M ui/gfx/mojom/buffer_types_mojom_traits.cc
- M ui/gfx/mojom/buffer_types_mojom_traits.h
- M ui/gfx/mojom/mojom_traits_unittest.cc
Change size: M
Delta: 37 files changed, 16 insertions(+), 78 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hirokazu Honda, +1 by Antonio Sartori, +1 by Vasiliy Telezhnikov, +1 by Kentaro Hara, +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages