WebUI: Remove no longer necessary CheckPatchFormatted overrides [chromium/src : main]

0 views
Skip to first unread message

Demetrios Papadopoulos (Gerrit)

unread,
Aug 3, 2026, 1:59:54 PM (2 days ago) Aug 3
to Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, rginda...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, oshima...@chromium.org, cros-essential...@chromium.org
Attention needed from Rebekah Potter

Demetrios Papadopoulos voted and added 2 comments

Votes added by Demetrios Papadopoulos

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Demetrios Papadopoulos . resolved

LGTM

File components/sync/service/resources/PRESUBMIT.py
Line 14, Patchset 2 (Latest): return []
Demetrios Papadopoulos . unresolved

Should we delete this entire file? It seems like a no-op now.

Open in Gerrit

Related details

Attention is currently required from:
  • Rebekah Potter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0327b312e9c8183f8639eeb8c822bbffadc1727b
Gerrit-Change-Number: 8178734
Gerrit-PatchSet: 2
Gerrit-Owner: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Attention: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Aug 2026 17:59:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rebekah Potter (Gerrit)

unread,
Aug 4, 2026, 6:12:27 PM (13 hours ago) Aug 4
to Alexander Bolodurin, Demetrios Papadopoulos, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, rginda...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, oshima...@chromium.org, cros-essential...@chromium.org
Attention needed from Alexander Bolodurin and Demetrios Papadopoulos

Rebekah Potter voted and added 2 comments

Votes added by Rebekah Potter

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rebekah Potter . resolved

+alexbn@ for ui/file_manager

File components/sync/service/resources/PRESUBMIT.py
Line 14, Patchset 2: return []
Demetrios Papadopoulos . resolved

Should we delete this entire file? It seems like a no-op now.

Rebekah Potter

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Bolodurin
  • Demetrios Papadopoulos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0327b312e9c8183f8639eeb8c822bbffadc1727b
    Gerrit-Change-Number: 8178734
    Gerrit-PatchSet: 3
    Gerrit-Owner: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-Reviewer: Alexander Bolodurin <ale...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Attention: Alexander Bolodurin <ale...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Aug 2026 22:12:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Demetrios Papadopoulos <dpa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Demetrios Papadopoulos (Gerrit)

    unread,
    2:04 AM (5 hours ago) 2:04 AM
    to Rebekah Potter, Alexander Bolodurin, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, rginda...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, oshima...@chromium.org, cros-essential...@chromium.org
    Attention needed from Alexander Bolodurin and Rebekah Potter

    Demetrios Papadopoulos voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Bolodurin
    • Rebekah Potter
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0327b312e9c8183f8639eeb8c822bbffadc1727b
      Gerrit-Change-Number: 8178734
      Gerrit-PatchSet: 3
      Gerrit-Owner: Rebekah Potter <rbpo...@chromium.org>
      Gerrit-Reviewer: Alexander Bolodurin <ale...@chromium.org>
      Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
      Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
      Gerrit-Attention: Rebekah Potter <rbpo...@chromium.org>
      Gerrit-Attention: Alexander Bolodurin <ale...@chromium.org>
      Gerrit-Comment-Date: Wed, 05 Aug 2026 06:03:54 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages