Enable the use of SurfaceView for CompositorView [chromium/src : main]

0 views

Skip to first unread message

Shakti Sahu (Gerrit)

unread,

Jan 20, 2026, 11:40:59 PM (2 hours ago) Jan 20

to Phil Yan, Abdelrahman Eed, Vasiliy Telezhnikov, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org

Attention needed from Frank Liberato and Phil Yan

Shakti Sahu added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/media/DocumentPictureInPictureActivity.java

Line 183, Patchset 6 (Latest): constraints.useSurfaceView = ChromeFeatureList.sEnableSurfaceViewForCompositor.isEnabled();

Shakti Sahu . unresolved

I would wish if we didn't have to change each callsite to set this finch flag.
I am trying to move the factory to chorme layer so that we can set the flag in CompositorViewFactory.
https://chromium-review.googlesource.com/c/chromium/src/+/7500317

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato
Phil Yan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Phil Yan (Gerrit)

unread,

12:36 AM (2 hours ago) 12:36 AM

to Abdelrahman Eed, Shakti Sahu, Vasiliy Telezhnikov, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org

Attention needed from Frank Liberato and Shakti Sahu

Phil Yan added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/media/DocumentPictureInPictureActivity.java

Line 183, Patchset 6 (Latest): constraints.useSurfaceView = ChromeFeatureList.sEnableSurfaceViewForCompositor.isEnabled();

Shakti Sahu . unresolved

I would wish if we didn't have to change each callsite to set this finch flag.
I am trying to move the factory to chorme layer so that we can set the flag in CompositorViewFactory.
https://chromium-review.googlesource.com/c/chromium/src/+/7500317

Phil Yan

Thank you! I'll move the flag checks to both CompositorViewFactory and ThinWebViewFactory once it's merged.

To double check, shall we keep the new `useSurfaceView` param in the ThinWebViewConstraints and set it to `true` if the flag is enabled in CompositorViewFactory and ThinWebViewFactory?

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato
Shakti Sahu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shakti Sahu (Gerrit)

unread,

1:30 AM (1 hour ago) 1:30 AM

to Phil Yan, Abdelrahman Eed, Vasiliy Telezhnikov, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org

Attention needed from Frank Liberato and Phil Yan

Shakti Sahu added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/media/DocumentPictureInPictureActivity.java

Line 183, Patchset 6 (Latest): constraints.useSurfaceView = ChromeFeatureList.sEnableSurfaceViewForCompositor.isEnabled();

Shakti Sahu . unresolved

I would wish if we didn't have to change each callsite to set this finch flag.
I am trying to move the factory to chorme layer so that we can set the flag in CompositorViewFactory.
https://chromium-review.googlesource.com/c/chromium/src/+/7500317

Phil Yan

Thank you! I'll move the flag checks to both CompositorViewFactory and ThinWebViewFactory once it's merged.
To double check, shall we keep the new `useSurfaceView` param in the ThinWebViewConstraints and set it to `true` if the flag is enabled in CompositorViewFactory and ThinWebViewFactory?

Shakti Sahu

Yea, we can do that. Or, probably better we can keep `useSurfaceView` param out of `ThinWebViewConstraints` and pass it in the constructor of `CompositorViewImpl` and `ThinWebViewImpl`. That way the clients dont need to worry about this param and the callsites remain as-is.

```
public CompositorViewImpl(
            Context context, boolean useSurfaceView, WindowAndroid windowAndroid, ThinWebViewConstraints constraints)
```

wdyt?

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato
Phil Yan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages