[OpenScreen] Update script to support Windows sender laptops [chromium/src : main]

0 views

Skip to first unread message

Bailey Myers-Morgan (Gerrit)

unread,

Nov 12, 2025, 6:48:04 PM (11 hours ago) Nov 12

to Zijie He, chromium...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Zijie He

Bailey Myers-Morgan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Bailey Myers-Morgan . resolved

Note that the failed builder is still expected: As you can see both builders are failing on "sink not found", which is unrelated to the script (and an improvement from the previous state).

Open in Gerrit

Related details

Attention is currently required from:

Zijie He

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zijie He (Gerrit)

unread,

Nov 12, 2025, 8:32:20 PM (9 hours ago) Nov 12

to Bailey Myers-Morgan, chromium...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Bailey Myers-Morgan

Zijie He voted and added 3 comments

Votes added by Zijie He

Code-Review

3 comments

File chrome/test/media_router/performance/openscreen_cast_performance_test.py

Line 179, Patchset 17 (Latest):

    key_path = os.path.expanduser('~/.ssh/id_ed25519')
    ssh_command = [

Zijie He . unresolved

I think this is not necessary since you are connecting from a linux host to the sender (may be mac or windows). So this command itself is always running on linux.

It's definitely not wrong though.

Line 301, Patchset 17 (Latest): send_ssh_command(args.sender, args.username, download_commands,

Zijie He . unresolved

QQ, does it mean that even on windows, the sender still has the ssh-server installed?

Another question is that do you plan to manage these senders via puppet as well?

Line 500, Patchset 17 (Latest): cleanup_command = (

Zijie He . unresolved

Nit, I think the pattern of SENDER_CHROMEDRIVER_CHECK_CMD is more readable 👍

Open in Gerrit

Related details

Attention is currently required from:

Bailey Myers-Morgan

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages