webcodecs: Stop using duration in VpxVideoEncoder for rate control [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Sep 19, 2025, 8:28:23 PM (2 days ago) Sep 19
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review+1

1 comment

File media/video/vpx_video_encoder.cc
Line 843, Patchset 1 (Latest): // No real way to figure out duration, use time passed since the last frame
Dale Curtis . unresolved

Probably this should use frame_duration in this case? But yeah, still leaves a case where no frame duration and no timestamp == guess.

Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I60e9b01b9338476c2fc9f7492f1346dadc68d4f2
Gerrit-Change-Number: 6968650
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Sat, 20 Sep 2025 00:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages