Switch to non-deprecated kCGImageByteOrder constants [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Sep 18, 2025, 4:46:51 PM (3 days ago) Sep 18
to Avi Drissman, Elad Alon, Justin Cohen, Lei Zhang, Reilly Grant, Florin Malita, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
Attention needed from Elad Alon, Florin Malita, Justin Cohen, Lei Zhang, Nico Weber and Reilly Grant

Avi Drissman added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Avi Drissman . resolved

Elad for c/b/m/webrtc
Justin for ios
thestig for printing
Reilly for services
Florin for skia, Blink
Nico for ui/

Open in Gerrit

Related details

Attention is currently required from:
  • Elad Alon
  • Florin Malita
  • Justin Cohen
  • Lei Zhang
  • Nico Weber
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia15632c7221e252ad2032deece179e2582fc7cbb
Gerrit-Change-Number: 6966823
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Elad Alon <elad...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Florin Malita <fma...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 20:46:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Sep 18, 2025, 4:50:04 PM (3 days ago) Sep 18
to Avi Drissman, Elad Alon, Lei Zhang, Reilly Grant, Florin Malita, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
Attention needed from Avi Drissman, Elad Alon, Florin Malita, Lei Zhang, Nico Weber and Reilly Grant

Justin Cohen added 1 comment

Patchset-level comments
Justin Cohen . resolved

ios/chrome/browser/snapshots/model/image_file_manager_unittest.mm LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Elad Alon
  • Florin Malita
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Florin Malita <fma...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 20:50:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Sep 18, 2025, 4:50:14 PM (3 days ago) Sep 18
to Avi Drissman, Elad Alon, Lei Zhang, Reilly Grant, Florin Malita, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
Attention needed from Avi Drissman, Elad Alon, Florin Malita, Lei Zhang, Nico Weber and Reilly Grant

Justin Cohen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Elad Alon
  • Florin Malita
  • Lei Zhang
  • Nico Weber
  • Reilly Grant
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Gerrit-Comment-Date: Thu, 18 Sep 2025 20:50:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Sep 18, 2025, 5:19:26 PM (3 days ago) Sep 18
    to Avi Drissman, Reilly Grant, Justin Cohen, Elad Alon, Lei Zhang, Florin Malita, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
    Attention needed from Avi Drissman, Elad Alon, Florin Malita, Lei Zhang and Nico Weber

    Reilly Grant voted and added 1 comment

    Votes added by Reilly Grant

    Code-Review+1

    1 comment

    Patchset-level comments
    Reilly Grant . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Elad Alon
    • Florin Malita
    • Lei Zhang
    • Nico Weber
    Gerrit-Attention: Florin Malita <fma...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Sep 2025 21:19:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 18, 2025, 5:29:04 PM (3 days ago) Sep 18
    to Avi Drissman, Lei Zhang, Reilly Grant, Justin Cohen, Elad Alon, Florin Malita, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
    Attention needed from Avi Drissman, Elad Alon, Florin Malita and Nico Weber

    Lei Zhang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Elad Alon
    • Florin Malita
    • Nico Weber
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Elad Alon <elad...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Florin Malita <fma...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Sep 2025 21:28:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Sep 19, 2025, 10:10:15 AM (2 days ago) Sep 19
    to Avi Drissman, Nico Weber, Lei Zhang, Reilly Grant, Justin Cohen, Elad Alon, Florin Malita, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
    Attention needed from Avi Drissman, Elad Alon and Florin Malita

    Nico Weber voted and added 1 comment

    Votes added by Nico Weber

    Code-Review+1

    1 comment

    Patchset-level comments
    Nico Weber . resolved

    thank you!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Elad Alon
    • Florin Malita
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia15632c7221e252ad2032deece179e2582fc7cbb
    Gerrit-Change-Number: 6966823
    Gerrit-PatchSet: 1
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
    Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Elad Alon <elad...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Florin Malita <fma...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 14:10:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Florin Malita (Gerrit)

    unread,
    Sep 19, 2025, 10:19:43 AM (2 days ago) Sep 19
    to Avi Drissman, Nico Weber, Lei Zhang, Reilly Grant, Justin Cohen, Elad Alon, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
    Attention needed from Avi Drissman and Elad Alon

    Florin Malita voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Elad Alon
    Gerrit-Comment-Date: Fri, 19 Sep 2025 14:19:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Elad Alon (Gerrit)

    unread,
    Sep 19, 2025, 2:12:52 PM (2 days ago) Sep 19
    to Avi Drissman, Florin Malita, Nico Weber, Lei Zhang, Reilly Grant, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org
    Attention needed from Avi Drissman

    Elad Alon voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 18:12:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Sep 19, 2025, 2:16:58 PM (2 days ago) Sep 19
    to Avi Drissman, Elad Alon, Florin Malita, Nico Weber, Lei Zhang, Reilly Grant, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org

    Avi Drissman voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 19 Sep 2025 18:16:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 19, 2025, 2:20:20 PM (2 days ago) Sep 19
    to Avi Drissman, Elad Alon, Florin Malita, Nico Weber, Lei Zhang, Reilly Grant, Justin Cohen, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, blink-...@chromium.org, chfreme...@chromium.org, cros-print...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rsesek...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Switch to non-deprecated kCGImageByteOrder constants
    Bug: 445708498
    Change-Id: Ia15632c7221e252ad2032deece179e2582fc7cbb
    Reviewed-by: Nico Weber <tha...@chromium.org>
    Reviewed-by: Justin Cohen <justi...@chromium.org>
    Commit-Queue: Avi Drissman <a...@chromium.org>
    Reviewed-by: Reilly Grant <rei...@chromium.org>
    Reviewed-by: Elad Alon <elad...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Reviewed-by: Florin Malita <fma...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1518081}
    Files:
    Change size: M
    Delta: 11 files changed, 36 insertions(+), 31 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nico Weber, +1 by Reilly Grant, +1 by Lei Zhang, +1 by Justin Cohen, +1 by Elad Alon, +1 by Florin Malita
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia15632c7221e252ad2032deece179e2582fc7cbb
    Gerrit-Change-Number: 6966823
    Gerrit-PatchSet: 2
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
    Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages