affiliations: use try_emplace in ParseResponse [chromium/src : main]
0 views
Skip to first unread message
Chris Davis (Gerrit)
Jul 31, 2026, 6:47:53 PM (5 days ago) Jul 31
to Ohene Osei, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, fgal...@chromium.org, mar...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, grt+...@chromium.org, eme-r...@chromium.org
Attention needed from Ohene Osei
Chris Davis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ohene Osei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Greg Thompson (Gerrit)
Aug 3, 2026, 8:35:14 AM (2 days ago) Aug 3
to Ohene Osei, grt+...@chromium.org, Akrosh Gandhi, Chris Davis, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, fgal...@chromium.org, mar...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, eme-r...@chromium.org
Attention needed from Akrosh Gandhi and Chris Davis
Greg Thompson removed grt+...@chromium.org from this change![]( "Open in Gerrit")
Attention is currently required from:
- Akrosh Gandhi
- Chris Davis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Davis (Gerrit)
Aug 3, 2026, 1:14:32 PM (2 days ago) Aug 3
to Ohene Osei, Akrosh Gandhi, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, fgal...@chromium.org, mar...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, eme-r...@chromium.org
Attention needed from Akrosh Gandhi and Ohene Osei
Chris Davis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Akrosh Gandhi
- Ohene Osei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Viktor Semeniuk (Gerrit)
4:03 AM (3 hours ago) 4:03 AM
to Ohene Osei, Ioana Treib, Chris Davis, Akrosh Gandhi, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, fgal...@chromium.org, mar...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, eme-r...@chromium.org
Attention needed from Akrosh Gandhi, Ioana Treib and Ohene Osei
Viktor Semeniuk voted and added 3 comments![]( "Open in Gerrit")
Votes added by Viktor Semeniuk
| Code-Review | +1 |
3 comments
Patchset-level comments
File components/affiliations/core/browser/lookup_affiliation_response_parser.cc
Line 135, Patchset 5 (Latest):
if (is_class_requested && *first_facet_class_index == result.size()) {Viktor Semeniuk . unresolved
`std::optional<T>` supports direct equality comparison with `T` without dereferencing. If the optional is `std::nullopt`, comparison with a value safely evaluates to false.
File components/affiliations/core/browser/lookup_affiliation_response_parser_unittest.cc
Line 251, Patchset 5 (Latest):
}Viktor Semeniuk . unresolved
We can also add the following test cases
```
TEST(LookupAffiliationResponseParserTest, IgnoreDuplicateEquivalenceClasses) {
std::vector<FacetURI> requested_facet_uris = {
FacetURI::FromCanonicalSpec("https://example.com")};
affiliation_pb::LookupAffiliationByHashPrefixResponse response;
auto* affiliation1 = response.add_affiliations();
affiliation1->add_facet()->set_id("https://example.com");
affiliation1->add_facet()->set_id("https://example2.com");
// Duplicate equivalence class in the same response.
auto* affiliation2 = response.add_affiliations();
affiliation2->add_facet()->set_id("https://example.com");
affiliation2->add_facet()->set_id("https://example2.com");
AffiliationFetcherInterface::ParsedFetchResponse result;
EXPECT_TRUE(ParseLookupAffiliationResponse(requested_facet_uris, response, &result));
EXPECT_EQ(1u, result.affiliations.size());
}
TEST(LookupAffiliationResponseParserTest, IgnoreUnrequestedEquivalenceClasses) {
std::vector<FacetURI> requested_facet_uris = {
FacetURI::FromCanonicalSpec("https://example.com")};affiliation_pb::LookupAffiliationByHashPrefixResponse response;
auto* affiliation = response.add_affiliations();
affiliation->add_facet()->set_id("https://unrequested.example.com");
affiliation->add_facet()->set_id("https://unrequested2.example.com");
AffiliationFetcherInterface::ParsedFetchResponse result;
EXPECT_TRUE(ParseLookupAffiliationResponse(requested_facet_uris, response, &result));
EXPECT_TRUE(result.affiliations.empty());
}
```
Related details
Attention is currently required from:
- Akrosh Gandhi
- Ioana Treib
- Ohene Osei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages