Remove Chromium uses of deprecated der::Input::As* methods [chromium/src : main]
0 views
Skip to first unread message
David Benjamin (Gerrit)
Nov 11, 2025, 12:34:11 PM (yesterday) Nov 11
to chromium...@chromium.org, dougste...@chromium.org, net-r...@chromium.org, webauthn...@chromium.org, feature-me...@chromium.org, ryanchu...@chromium.org, derinel+wat...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org
David Benjamin has uploaded the change for review![]( "Open in Gerrit")
Commit message
Remove Chromium uses of deprecated der::Input::As* methods
der::Input is a remnant of before span existed. We'll eventually turn it
into a span typedef, at which point these methods will be gone. Instead,
use base::as_string_view. Or, in a few places, use the bytes-based
version of a function which avoids the conversion at all.
Bug: 42290536
Change-Id: I60b294e85cd9b5638e81f9d6dca8514a3c64292a
Change diff
Change information
Files:
- M chrome/common/net/x509_certificate_model.cc
- M components/media_router/common/providers/cast/certificate/cast_crl.cc
- M components/media_router/common/providers/cast/certificate/net_parsed_certificate.cc
- M components/trusted_vault/recovery_key_store_certificate.cc
- M device/fido/enclave/attestation.cc
- M net/cert/asn1_util.cc
- M net/cert/cert_verify_proc_android.cc
- M net/cert/cert_verify_proc_builtin.cc
- M net/cert/cert_verify_proc_builtin_unittest.cc
- M net/cert/ev_root_ca_metadata.cc
- M net/cert/internal/revocation_checker.cc
- M net/cert/internal/trust_store_chrome.cc
- M net/cert/internal/trust_store_mac_unittest.cc
- M net/cert/internal/trust_store_nss_unittest.cc
- M net/cert/x509_certificate_unittest.cc
- M net/test/cert_builder.cc
- M net/tools/cert_verify_tool/verify_using_path_builder.cc
Change size: M
Delta: 17 files changed, 69 insertions(+), 56 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Nov 11, 2025, 12:35:44 PM (yesterday) Nov 11
to Matt Mueller, Chromium Sync Reviews, Martin Kreichgauer, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from Chromium Sync Reviews, Martin Kreichgauer, Matt Mueller and Shawn Quereshi
David Benjamin voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Chromium Sync Reviews
- Martin Kreichgauer
- Matt Mueller
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Nov 11, 2025, 12:36:34 PM (yesterday) Nov 11
to David Benjamin, Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, Matt Mueller, Martin Kreichgauer, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from Marc Treib, Martin Kreichgauer, Matt Mueller and Shawn Quereshi
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
tr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)
Related details
Attention is currently required from:
- Marc Treib
- Martin Kreichgauer
- Matt Mueller
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Nov 11, 2025, 12:42:24 PM (yesterday) Nov 11
to Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, Matt Mueller, Martin Kreichgauer, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from Marc Treib, Martin Kreichgauer, Matt Mueller and Shawn Quereshi
David Benjamin added 1 comment![]( "Open in Gerrit")
File net/cert/asn1_util.cc
Line 380, Patchset 2 (Latest):
*out_contents = extension.base::as_string_view(value);David Benjamin . unresolved
Bah, multi-cursor gone awry. One moment...
Related details
Attention is currently required from:
- Marc Treib
- Martin Kreichgauer
- Matt Mueller
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Nov 11, 2025, 12:49:38 PM (yesterday) Nov 11
to Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, Matt Mueller, Martin Kreichgauer, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from Marc Treib, Martin Kreichgauer, Matt Mueller and Shawn Quereshi
David Benjamin added 1 comment![]( "Open in Gerrit")
File net/cert/asn1_util.cc
Line 380, Patchset 2:
*out_contents = extension.base::as_string_view(value);David Benjamin . resolved
Bah, multi-cursor gone awry. One moment...
David Benjamin
Done
Related details
Attention is currently required from:
- Marc Treib
- Martin Kreichgauer
- Matt Mueller
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Nov 11, 2025, 2:13:06 PM (yesterday) Nov 11
to David Benjamin, Matt Mueller, Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, Martin Kreichgauer, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from David Benjamin, Marc Treib, Martin Kreichgauer and Shawn Quereshi
Matt Mueller voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Benjamin
- Marc Treib
- Martin Kreichgauer
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Nov 11, 2025, 3:54:17 PM (yesterday) Nov 11
to David Benjamin, Martin Kreichgauer, Matt Mueller, Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from David Benjamin, Marc Treib and Shawn Quereshi
Martin Kreichgauer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Kreichgauer
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- David Benjamin
- Marc Treib
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
3:16 AM (15 hours ago) 3:16 AM
to David Benjamin, Marc Treib, Martin Kreichgauer, Matt Mueller, Chromium Sync Reviews, Chromium LUCI CQ, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from David Benjamin and Shawn Quereshi
Marc Treib voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marc Treib
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- David Benjamin
- Shawn Quereshi
Mark Foltz (Gerrit)
8:37 AM (10 hours ago) 8:37 AM
to David Benjamin, Mark Foltz, Marc Treib, Martin Kreichgauer, Matt Mueller, Chromium Sync Reviews, Chromium LUCI CQ, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from David Benjamin and Shawn Quereshi
Mark Foltz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Foltz
| Code-Review | +1 |
1 comment
Patchset-level comments
Mark Foltz . resolved
media_router LGTM
Related details
Attention is currently required from:
- David Benjamin
- Shawn Quereshi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
11:00 AM (7 hours ago) 11:00 AM
to Mark Foltz, Marc Treib, Martin Kreichgauer, Matt Mueller, Chromium Sync Reviews, Chromium LUCI CQ, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Attention needed from Shawn Quereshi
David Benjamin voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Shawn Quereshi
Chromium LUCI CQ (Gerrit)
11:03 AM (7 hours ago) 11:03 AM
to David Benjamin, Mark Foltz, Marc Treib, Martin Kreichgauer, Matt Mueller, Chromium Sync Reviews, Shawn Quereshi, chromium...@chromium.org, derinel+wat...@google.com, dougste...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, webauthn...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove Chromium uses of deprecated der::Input::As* methods
der::Input is a remnant of before span existed. We'll eventually turn it
into a span typedef, at which point these methods will be gone. Instead,
use base::as_string_view. Or, in a few places, use the bytes-based
version of a function which avoids the conversion at all.
Bug: 41347540
Change-Id: I60b294e85cd9b5638e81f9d6dca8514a3c64292a
Reviewed-by: Marc Treib <tr...@chromium.org>
Commit-Queue: David Benjamin <davi...@chromium.org>
Reviewed-by: Matt Mueller <ma...@chromium.org>
Reviewed-by: Mark Foltz <mfo...@chromium.org>
Reviewed-by: Martin Kreichgauer <mart...@google.com>
Cr-Commit-Position: refs/heads/main@{#1543741}
Files:
- M chrome/common/net/x509_certificate_model.cc
- M components/media_router/common/providers/cast/certificate/cast_crl.cc
- M components/media_router/common/providers/cast/certificate/net_parsed_certificate.cc
- M components/trusted_vault/recovery_key_store_certificate.cc
- M device/fido/enclave/attestation.cc
- M net/cert/asn1_util.cc
- M net/cert/cert_verify_proc_android.cc
- M net/cert/cert_verify_proc_builtin.cc
- M net/cert/cert_verify_proc_builtin_unittest.cc
- M net/cert/ev_root_ca_metadata.cc
- M net/cert/internal/revocation_checker.cc
- M net/cert/internal/trust_store_chrome.cc
- M net/cert/internal/trust_store_mac_unittest.cc
- M net/cert/internal/trust_store_nss_unittest.cc
- M net/cert/x509_certificate_unittest.cc
- M net/test/cert_builder.cc
- M net/tools/cert_verify_tool/verify_using_path_builder.cc
Change size: M
Delta: 17 files changed, 69 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matt Mueller, +1 by Mark Foltz, +1 by Martin Kreichgauer, +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages