Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature [chromium/src : main]
朱思达 (Gerrit)
朱思达 uploaded patch set #2 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
8 files changed, 58 insertions(+), 10 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
8 files changed, 60 insertions(+), 11 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Attention is currently required from: 朱思达.
朱思达 uploaded patch set #4 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
9 files changed, 75 insertions(+), 7 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Attention is currently required from: 朱思达.
朱思达 uploaded patch set #5 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
9 files changed, 75 insertions(+), 9 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Attention is currently required from: 朱思达.
朱思达 uploaded patch set #6 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/base/supported_types_unittest.cc
M media/base/test_data_util.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
M media/test/pipeline_integration_test.cc
12 files changed, 235 insertions(+), 11 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Attention is currently required from: 朱思达.
朱思达 uploaded patch set #7 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/base/supported_types_unittest.cc
M media/base/test_data_util.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
M media/test/pipeline_integration_test.cc
12 files changed, 237 insertions(+), 11 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
朱思达 uploaded patch set #8 to this change.
朱思达 (Gerrit)
朱思达 uploaded patch set #9 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/base/supported_types_unittest.cc
M media/base/test_data_util.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
M media/test/pipeline_integration_test.cc
12 files changed, 239 insertions(+), 12 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
朱思达 uploaded patch set #10 to this change.
朱思达 (Gerrit)
Attention is currently required from: Dale Curtis, Xiaohan Wang.
朱思达 would like Dale Curtis and Xiaohan Wang to review this change.
朱思达 (Gerrit)
Attention is currently required from: Dale Curtis, Xiaohan Wang.
1 comment:
Patchset:
@Dale and @Xiaohan, can we look into this for 2024 now!? :)
Please feel free to comment out.
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
Dale Curtis (Gerrit)
Attention is currently required from: Xiaohan Wang, 朱思达.
1 comment:
Patchset:
I don't think we want to compile this in as disabled since it would still introduce a bunch of new security surface area. This will have to wait until we have a decision on AC3/EAC3 internally. We'll discuss this year.
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
朱思达 (Gerrit)
Attention is currently required from: Xiaohan Wang, 朱思达.
朱思达 uploaded patch set #11 to this change.
Audio: Enable AC3/EC3 compile and add `kPlatformAC3DecoderSupport` feature
The code implementation to support AC3/EC3 audio decoding has been
completed on macOS and Windows latest year. On other platforms,
since the lack of OS support, the codec has not been supported yet.
Add disabled by default feature switch `kPlatformAC3DecoderSupport`
to control the actual support on Windows and macOS.
Bug: 1430808
Bug: 1402182
Bug: 611517
Change-Id: I2b1e28ce4bb3e86666734be895ac112aec03d86a
---
M content/browser/media/media_canplaytype_browsertest.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/supported_types.cc
M media/base/supported_types_unittest.cc
M media/base/test_data_util.cc
M media/filters/ffmpeg_demuxer_unittest.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/filters/win/media_foundation_audio_decoder.cc
M media/media_options.gni
M media/mojo/services/media_foundation_service.cc
M media/test/pipeline_integration_test.cc
12 files changed, 243 insertions(+), 12 deletions(-)
To view, visit change 5175506. To unsubscribe, or for help writing mail filters, visit settings.
Alvaro Velad Galvan (Gerrit)
Alvaro Velad Galvan added 1 comment![]( "Open in Gerrit")
I don't think we want to compile this in as disabled since it would still introduce a bunch of new security surface area. This will have to wait until we have a decision on AC3/EAC3 internally. We'll discuss this year.
- Dale Curtis
- Sida Zhu
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sida Zhu (Gerrit)
Sida Zhu added 2 comments![]( "Open in Gerrit")
Alvaro Velad GalvanI don't think we want to compile this in as disabled since it would still introduce a bunch of new security surface area. This will have to wait until we have a decision on AC3/EAC3 internally. We'll discuss this year.
Any update on this decision?
Recently, some CL for Windows platform has been merged, so I think the feature is nearly ready there.
@dalec...@chromium.org Dale, what about the current decision of the media team regarding this feature now?
Recently, some CL for Windows platform has been merged, so I think the feature is nearly ready there. @dalec...@chromium.org Dale, what about the current decision of the media team regarding this feature now?
Related details
- Alvaro Velad Galvan
- Dale Curtis
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
Alvaro Velad GalvanI don't think we want to compile this in as disabled since it would still introduce a bunch of new security surface area. This will have to wait until we have a decision on AC3/EAC3 internally. We'll discuss this year.
Sida ZhuAny update on this decision?
Recently, some CL for Windows platform has been merged, so I think the feature is nearly ready there.
@dalec...@chromium.org Dale, what about the current decision of the media team regarding this feature now?
The current decision is unchanged, but I've asked our product org to reanalyze the decision in case enough inputs have changed.
Related details
- Alvaro Velad Galvan
- Sida Zhu
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sida Zhu (Gerrit)
Sida Zhu added 1 comment![]( "Open in Gerrit")
Alvaro Velad GalvanI don't think we want to compile this in as disabled since it would still introduce a bunch of new security surface area. This will have to wait until we have a decision on AC3/EAC3 internally. We'll discuss this year.
Sida ZhuAny update on this decision?
Dale CurtisRecently, some CL for Windows platform has been merged, so I think the feature is nearly ready there.
@dalec...@chromium.org Dale, what about the current decision of the media team regarding this feature now?
The current decision is unchanged, but I've asked our product org to reanalyze the decision in case enough inputs have changed.
- Alvaro Velad Galvan
- Dale Curtis
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |