[//media] Have one WrapExternalGMB variant call through to second [chromium/src : main]
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
if (shared_image) {Out of the scope of this CL, but this is always null, because the only way to get here would be getting [here](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/mojom/video_frame_mojom_traits.cc;drc=7fdf446abc06f53adddc0c7cf4cb31b83e0507c5;l=146) with SI, and the only way to get there with SI would be getting to this function with SI first.
So we could remove [this](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/mojom/media_types.mojom;drc=3d2929a07c6833b580b895ac686e3df5f2607199;l=492) and this function.
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
if (shared_image) {Out of the scope of this CL, but this is always null, because the only way to get here would be getting [here](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/mojom/video_frame_mojom_traits.cc;drc=7fdf446abc06f53adddc0c7cf4cb31b83e0507c5;l=146) with SI, and the only way to get there with SI would be getting to this function with SI first.
So we could remove [this](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/mojom/media_types.mojom;drc=3d2929a07c6833b580b895ac686e3df5f2607199;l=492) and this function.
Thanks! I'll look at this in followup.
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
[//media] Have one WrapExternalGMB variant call through to second
Will ease followup refactoring. There's no functional change.
- M media/base/video_frame.cc
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |