[iOS] Enable use of the Passkey Creation Bottom Sheet [chromium/src : main]
0 views
Skip to first unread message
Alexis Hétu (Gerrit)
Jan 14, 2026, 4:00:22 PM (4 days ago) Jan 14
to Noémie St-Onge, Rafał Godlewski, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Noémie St-Onge and Rafał Godlewski
Alexis Hétu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Noémie St-Onge
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Jan 15, 2026, 6:57:48 AM (3 days ago) Jan 15
to Alexis Hétu, Chromium LUCI CQ, Noémie St-Onge, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Alexis Hétu and Noémie St-Onge
Rafał Godlewski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rafał Godlewski
| Code-Review | +1 |
1 comment
File ios/chrome/browser/shared/public/commands/browser_coordinator_commands.h
Line 110, Patchset 5 (Latest):
// Dismiss the payments suggestions.Rafał Godlewski . unresolved
```suggestion
// Dismisses the passkey creation bottom sheet.
```
Related details
Attention is currently required from:
- Alexis Hétu
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noémie St-Onge (Gerrit)
Jan 15, 2026, 11:40:27 AM (3 days ago) Jan 15
to Alexis Hétu, Rafał Godlewski, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Alexis Hétu
Noémie St-Onge added 4 comments![]( "Open in Gerrit")
File ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
Line 499, Patchset 5 (Latest):
// Coordinator in charge of the presenting the passkey creation bottom sheet.
@property(nonatomic, strong) PasskeyCreationBottomSheetCoordinator*
passkeyCreationBottomSheetCoordinator;Noémie St-Onge . unresolved
Since we're trying to move away from properties, I think the recommendation for the BrowserCoordinator is to use ivars for new coordinators
Line 2346, Patchset 5 (Latest):
if (self.passkeyCreationBottomSheetCoordinator) {
return;
}Noémie St-Onge . unresolved
I think this is risky. If the coordinator is never stopped for whatever reason (e.g., race condition, poor implementation), this part of the UI will become blocked. I think we prefer overriding the previous instance with the new one in such cases
go/coordinator-fix-proposal
File ios/chrome/browser/passwords/ui_bundled/bottom_sheet/passkey_creation_bottom_sheet_coordinator.mm
Line 77, Patchset 5 (Latest):
- (void)viewDidDisappear {
[self.browserCoordinatorCommandsHandler dismissPasskeyCreation];
}Noémie St-Onge . unresolved
We are moving away from message forwarding go/bling-best-practices#message-forwarding
If the method isn't going to do more than call `dismissPasskeyCreation`, then the commands handler should be passed to and used by the view controller directly
File ios/chrome/browser/webauthn/model/passkey_egtest.mm
Line 25, Patchset 5 (Latest):
// Returns the matcher for the use password button.Noémie St-Onge . unresolved
```suggestion
// Returns the matcher for the "Create" button.
```
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jan 15, 2026, 2:38:36 PM (3 days ago) Jan 15
to Rafał Godlewski, Chromium LUCI CQ, Noémie St-Onge, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Noémie St-Onge and Rafał Godlewski
Alexis Hétu voted and added 5 comments![]( "Open in Gerrit")
Votes added by Alexis Hétu
| Commit-Queue | +1 |
5 comments
File ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
Line 499, Patchset 5:
// Coordinator in charge of the presenting the passkey creation bottom sheet.
@property(nonatomic, strong) PasskeyCreationBottomSheetCoordinator*
passkeyCreationBottomSheetCoordinator;Noémie St-Onge . resolved
Since we're trying to move away from properties, I think the recommendation for the BrowserCoordinator is to use ivars for new coordinators
Alexis Hétu
Done
Line 2346, Patchset 5:
if (self.passkeyCreationBottomSheetCoordinator) {
return;
}Noémie St-Onge . resolved
I think this is risky. If the coordinator is never stopped for whatever reason (e.g., race condition, poor implementation), this part of the UI will become blocked. I think we prefer overriding the previous instance with the new one in such cases
go/coordinator-fix-proposal
Alexis Hétu
Ok. Removed.
File ios/chrome/browser/passwords/ui_bundled/bottom_sheet/passkey_creation_bottom_sheet_coordinator.mm
Line 77, Patchset 5:
- (void)viewDidDisappear {
[self.browserCoordinatorCommandsHandler dismissPasskeyCreation];
}Noémie St-Onge . resolved
We are moving away from message forwarding go/bling-best-practices#message-forwarding
If the method isn't going to do more than call `dismissPasskeyCreation`, then the commands handler should be passed to and used by the view controller directly
Alexis Hétu
Done (also modified in the previous CL accordingly).
File ios/chrome/browser/shared/public/commands/browser_coordinator_commands.h
Line 110, Patchset 5:
// Dismiss the payments suggestions.Rafał Godlewski . resolved
Alexis Hétu```suggestion
// Dismisses the passkey creation bottom sheet.
```
Done
File ios/chrome/browser/webauthn/model/passkey_egtest.mm
```suggestion
// Returns the matcher for the "Create" button.
```
Attention is currently required from:
- Noémie St-Onge
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noémie St-Onge (Gerrit)
Jan 16, 2026, 12:23:56 PM (2 days ago) Jan 16
to Alexis Hétu, Rafał Godlewski, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Alexis Hétu and Rafał Godlewski
Noémie St-Onge voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jan 16, 2026, 1:24:22 PM (2 days ago) Jan 16
to Noémie St-Onge, Rafał Godlewski, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Rafał Godlewski
Alexis Hétu voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jan 16, 2026, 4:47:59 PM (2 days ago) Jan 16
to Noémie St-Onge, Rafał Godlewski, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Rafał Godlewski
Alexis Hétu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages