Add WebCodecsAv1EncodingWithQP use counter [chromium/src : main]

0 views
Skip to first unread message

Eugene Zemtsov (Gerrit)

unread,
Sep 19, 2025, 6:46:39 PM (8 hours ago) Sep 19
to Eugene Zemtsov, Dale Curtis, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
Attention needed from Dale Curtis

Eugene Zemtsov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
Gerrit-Change-Number: 6969717
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 22:46:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Sep 19, 2025, 6:50:33 PM (8 hours ago) Sep 19
to Eugene Zemtsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov

Dale Curtis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
    Gerrit-Change-Number: 6969717
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 22:50:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Sep 19, 2025, 6:50:51 PM (8 hours ago) Sep 19
    to Eugene Zemtsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
    Attention needed from Eugene Zemtsov

    Dale Curtis added 1 comment

    File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    Line 4986, Patchset 1 (Latest): // chromium/src/tools/metrics/histograms/update_use_counter_feature_enum.py
    Dale Curtis . unresolved

    Need to run this though

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
      Gerrit-Change-Number: 6969717
      Gerrit-PatchSet: 1
      Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Comment-Date: Fri, 19 Sep 2025 22:50:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Eugene Zemtsov (Gerrit)

      unread,
      Sep 19, 2025, 6:55:15 PM (8 hours ago) Sep 19
      to Eugene Zemtsov, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org

      Eugene Zemtsov added 1 comment

      File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
      Line 4986, Patchset 1 (Latest): // chromium/src/tools/metrics/histograms/update_use_counter_feature_enum.py
      Dale Curtis . resolved

      Need to run this though

      Eugene Zemtsov

      i did

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
      Gerrit-Change-Number: 6969717
      Gerrit-PatchSet: 1
      Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Comment-Date: Fri, 19 Sep 2025 22:55:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
      satisfied_requirement
      open
      diffy

      Eugene Zemtsov (Gerrit)

      unread,
      Sep 19, 2025, 7:49:45 PM (7 hours ago) Sep 19
      to Eugene Zemtsov, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org

      Eugene Zemtsov voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
      Gerrit-Change-Number: 6969717
      Gerrit-PatchSet: 1
      Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Comment-Date: Fri, 19 Sep 2025 23:49:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Sep 19, 2025, 8:29:55 PM (6 hours ago) Sep 19
      to Eugene Zemtsov, Dale Curtis, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Add WebCodecsAv1EncodingWithQP use counter

      We want to know how often users encode Av1 video with per-frame QP,
      because we want to change the range for Av1 QP.
      Bug: 446157737
      Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
      Reviewed-by: Dale Curtis <dalec...@chromium.org>
      Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1518255}
      Files:
      • M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
      • M third_party/blink/renderer/modules/webcodecs/video_encoder.cc
      • M tools/metrics/histograms/metadata/blink/enums.xml
      Change size: S
      Delta: 3 files changed, 10 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Dale Curtis
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia01527ed74e70499d4e39cec7f76cf40f997709e
      Gerrit-Change-Number: 6969717
      Gerrit-PatchSet: 2
      Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages