[//gpu] Fold FakeGpuMemoryBuffer into client_shared_image.cc [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Jul 7, 2025, 9:42:33 AMJul 7

to Colin Blundell, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mfoltz...@chromium.org, media-cro...@chromium.org, jophba...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 8, 2025, 2:54:47 AMJul 8

to Colin Blundell, Vasiliy Telezhnikov, Rijubrata Bhaumik, AyeAye, chromium...@chromium.org, mfoltz...@chromium.org, media-cro...@chromium.org, jophba...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[//gpu] Fold FakeGpuMemoryBuffer into client_shared_image.cc

Move the creation of FakeGpuMemoryBuffer from
test_shared_image_interface.cc to client_shared_image.cc and hide
FakeGpuMemoryBuffer inside client_shared_image.cc.

Followup will rename fake_gpu_memory_buffer.* and make it Linux/ChromeOS
only.

Bug: 404905709

Change-Id: I7b95fcba81283fd1e648456b9cbffd01de414fac

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6701216

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1483579}

Files:

M gpu/command_buffer/client/client_shared_image.cc
M gpu/command_buffer/client/client_shared_image.h
M gpu/command_buffer/client/fake_gpu_memory_buffer.cc
M gpu/command_buffer/client/fake_gpu_memory_buffer.h
M gpu/command_buffer/client/test_shared_image_interface.cc
M gpu/command_buffer/client/test_shared_image_interface.h
M media/capture/video/linux/v4l2_capture_delegate_gpu_helper_unittest.cc
M media/capture/video/linux/v4l2_capture_delegate_unittest.cc
M media/gpu/vaapi/vaapi_video_encode_accelerator_unittest.cc

Change size: L

Delta: 9 files changed, 125 insertions(+), 133 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages