[iOS][CX] Update fields in credential export manager [chromium/src : main]

0 views
Skip to first unread message

Tommy Martino (Gerrit)

unread,
Jan 12, 2026, 3:16:58 PMJan 12
to Rafał Godlewski, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, srahim...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Rafał Godlewski

Tommy Martino voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rafał Godlewski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4201ac514059a91a28bf5abf762a49f946ddce99
Gerrit-Change-Number: 7451966
Gerrit-PatchSet: 7
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
Gerrit-Attention: Rafał Godlewski <rg...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 20:16:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rafał Godlewski (Gerrit)

unread,
Jan 12, 2026, 3:39:55 PMJan 12
to Tommy Martino, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, srahim...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Rafał Godlewski voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4201ac514059a91a28bf5abf762a49f946ddce99
Gerrit-Change-Number: 7451966
Gerrit-PatchSet: 7
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 20:39:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 12, 2026, 4:04:23 PMJan 12
to Rafał Godlewski, Tommy Martino, AyeAye, chromium...@chromium.org, srahim...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[iOS][CX] Update fields in credential export manager

* Adds exporter display name as localized "Google Password Manager" (or "Password Manager" for unbranded builds)
* Adds exporter RP ID as "passwords.google.com"
* Makes userName empty for account item (not defined for GPM)
* Passes the email of the user signed-in account

This matches the choices made in Android exporter. Screenshots check is
skipped, cause there is no view for the added strings.
Bug: 447142330
Fixed: 447144466
Skip-Translation-Screenshots-Check: True
Change-Id: I4201ac514059a91a28bf5abf762a49f946ddce99
Reviewed-by: Tommy Martino <tmar...@chromium.org>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1568003}
Files:
  • M ios/chrome/app/strings/ios_chromium_strings.grd
  • M ios/chrome/app/strings/ios_google_chrome_strings.grd
  • M ios/chrome/browser/credential_exchange/coordinator/credential_export_coordinator.mm
  • M ios/chrome/browser/credential_exchange/coordinator/credential_export_mediator.h
  • M ios/chrome/browser/credential_exchange/coordinator/credential_export_mediator.mm
  • M ios/chrome/browser/credential_exchange/model/BUILD.gn
  • M ios/chrome/browser/credential_exchange/model/credential_export_manager.swift
  • M ios/chrome/browser/credential_exchange/model/credential_exporter.h
  • M ios/chrome/browser/credential_exchange/model/credential_exporter.mm
Change size: M
Delta: 9 files changed, 44 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tommy Martino
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4201ac514059a91a28bf5abf762a49f946ddce99
Gerrit-Change-Number: 7451966
Gerrit-PatchSet: 8
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages