Android: Fix Error Prone warnings about Charsets [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Feb 11, 2026, 4:28:14 PM (11 hours ago) Feb 11
to Andrew Grieve, Sam Maier, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, agriev...@chromium.org, android-web...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, petewi...@chromium.org
Attention needed from Sam Maier

Andrew Grieve voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sam Maier
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If713893a7ebf6c376ca29bd2c890c36e2e47400d
Gerrit-Change-Number: 7567966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Sam Maier <sma...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Feb 2026 21:28:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sam Maier (Gerrit)

unread,
Feb 11, 2026, 4:34:46 PM (11 hours ago) Feb 11
to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, agriev...@chromium.org, android-web...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, petewi...@chromium.org
Attention needed from Andrew Grieve

Sam Maier voted and added 1 comment

Votes added by Sam Maier

Code-Review+1

1 comment

File chrome/android/java/src/org/chromium/chrome/browser/omaha/ResponseParser.java
Line 22, Patchset 4 (Latest): * <?xml version="1.0" encoding=StandardCharsets.UTF_8?>
Sam Maier . unresolved

Accidental application here

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If713893a7ebf6c376ca29bd2c890c36e2e47400d
    Gerrit-Change-Number: 7567966
    Gerrit-PatchSet: 4
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Feb 2026 21:34:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Feb 11, 2026, 7:03:21 PM (9 hours ago) Feb 11
    to Andrew Grieve, Sam Maier, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, agriev...@chromium.org, android-web...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, petewi...@chromium.org

    Andrew Grieve voted and added 1 comment

    Votes added by Andrew Grieve

    Commit-Queue+2
    Owners-Override+1

    1 comment

    File chrome/android/java/src/org/chromium/chrome/browser/omaha/ResponseParser.java
    Line 22, Patchset 4: * <?xml version="1.0" encoding=StandardCharsets.UTF_8?>
    Sam Maier . resolved

    Accidental application here

    Andrew Grieve

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If713893a7ebf6c376ca29bd2c890c36e2e47400d
    Gerrit-Change-Number: 7567966
    Gerrit-PatchSet: 5
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Thu, 12 Feb 2026 00:03:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Sam Maier <sma...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 11, 2026, 8:10:45 PM (7 hours ago) Feb 11
    to Andrew Grieve, Sam Maier, chromium...@chromium.org, Rijubrata Bhaumik, agriev...@chromium.org, android-web...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, petewi...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    4 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chrome/android/java/src/org/chromium/chrome/browser/omaha/ResponseParser.java
    Insertions: 1, Deletions: 2.

    @@ -16,10 +16,9 @@
      * Parses XML responses from the Omaha Update Server.
      *
      * <pre>
    - *
      * Expects XML formatted like:
      *
    - * <?xml version="1.0" encoding=StandardCharsets.UTF_8?>
    + * <?xml version="1.0" encoding="UTF-8"?>
      *   <daystart elapsed_days="4804" elapsed_seconds="65524"/>
      *   <app appid="{appid}" status="ok">
      *     <updatecheck status="ok">
    ```

    Change information

    Commit message:
    Android: Fix Error Prone warnings about Charsets

    This fixes the ones that do not trigger NewApi lint warnings. Hoping
    Error Prone will provide a way to not trigger on NewApi-breaking ones.
    Bug: 483667439
    Change-Id: If713893a7ebf6c376ca29bd2c890c36e2e47400d
    Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
    Reviewed-by: Sam Maier <sma...@chromium.org>
    Commit-Queue: Andrew Grieve <agr...@chromium.org>
    Owners-Override: Andrew Grieve <agr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1583630}
    Files:
    • M android_webview/java/src/org/chromium/android_webview/AwContents.java
    • M android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
    • M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java
    • M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
    • M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
    • M base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java
    • M base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java
    • M build/android/stacktrace/java/org/chromium/build/FlushingReTrace.java
    • M chrome/android/java/src/org/chromium/chrome/browser/omaha/ResponseParser.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/PopularUrlsTest.java
    • M chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/FeedStream.java
    • M chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/FeedStreamTest.java
    • M chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/SingleWebFeedStreamTest.java
    • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploader.java
    • M components/cronet/android/fake/java/org/chromium/net/test/FakeUrlResponse.java
    • M components/cronet/android/fake/javatests/org/chromium/net/test/FakeUrlResponseTest.java
    • M components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
    • M components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java
    • M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
    • M components/cronet/android/test/javatests/src/org/chromium/net/apihelpers/UploadDataProvidersTest.java
    • M components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
    • M components/media_router/browser/android/java/src/org/chromium/components/media_router/caf/remoting/RemotingMediaSource.java
    • M content/public/android/junit/src/org/chromium/content_public/browser/MessagePayloadTest.java
    • M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java
    • M services/device/nfc/android/java/src/org/chromium/device/nfc/NdefMessageUtils.java
    • M services/device/nfc/android/junit/src/org/chromium/device/nfc/NFCTest.java
    Change size: L
    Delta: 26 files changed, 451 insertions(+), 439 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Sam Maier
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If713893a7ebf6c376ca29bd2c890c36e2e47400d
    Gerrit-Change-Number: 7567966
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages